Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b3aef9e-53ae-d96d-8a8d-5c005a333330@linaro.org>
Date:   Tue, 9 May 2023 10:18:05 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] nvmem: imx-ocotp: set varaiable imx_ocotp_layout
 storage-class-specifier to static
To:     Tom Rix <trix@redhat.com>, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230404183133.1925424-1-trix@redhat.com>
Content-Language: en-US
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
In-Reply-To: <20230404183133.1925424-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/04/2023 19:31, Tom Rix wrote:
> smatch reports
> drivers/nvmem/imx-ocotp.c:599:21: warning: symbol
>    'imx_ocotp_layout' was not declared. Should it be static?
> 
> This variable is only used in one file so should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

Applied thanks,

--srini
>   drivers/nvmem/imx-ocotp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvmem/imx-ocotp.c b/drivers/nvmem/imx-ocotp.c
> index ac0edb6398f1..fcea9c04be96 100644
> --- a/drivers/nvmem/imx-ocotp.c
> +++ b/drivers/nvmem/imx-ocotp.c
> @@ -596,7 +596,7 @@ static void imx_ocotp_fixup_cell_info(struct nvmem_device *nvmem,
>   	cell->read_post_process = imx_ocotp_cell_pp;
>   }
>   
> -struct nvmem_layout imx_ocotp_layout = {
> +static struct nvmem_layout imx_ocotp_layout = {
>   	.fixup_cell_info = imx_ocotp_fixup_cell_info,
>   };
>