Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a8bba97-00dd-5a02-f378-944dbc075909@redhat.com>
Date:   Tue, 9 May 2023 11:19:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 0/3] Uncore frequency scaling using TPMI
Content-Language: en-US, nl
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230418171340.681662-1-srinivas.pandruvada@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230418171340.681662-1-srinivas.pandruvada@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 4/18/23 19:13, Srinivas Pandruvada wrote:
> Implement support of uncore frequency control via TPMI (Topology Aware
> Register and PM Capsule Interface). This driver provides the similar
> functionality as the current uncore frequency driver using MSRs.
> 
> Previously I posted only 1/3 and got reviewed and addressed with
> this submission. The other two patches were links in the submission.
> 
> But it is better that all three patches considered together.
> I know this is close to merge window for 6.4, so it is fine to differ.
> 
> Srinivas Pandruvada (3):
>   platform/x86/intel-uncore-freq: Uncore frequency control via TPMI
>   platform/x86/intel-uncore-freq: Support for cluster level controls
>   platform/x86/intel-uncore-freq: tpmi: Provide cluster level control

Thank you for your patch-series, I've applied the series
(with the updated 1/3) to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> 
>  .../pm/intel_uncore_frequency_scaling.rst     |  57 ++-
>  .../x86/intel/uncore-frequency/Kconfig        |   4 +
>  .../x86/intel/uncore-frequency/Makefile       |   2 +
>  .../uncore-frequency-common.c                 |  51 ++-
>  .../uncore-frequency-common.h                 |  16 +-
>  .../uncore-frequency/uncore-frequency-tpmi.c  | 418 ++++++++++++++++++
>  .../intel/uncore-frequency/uncore-frequency.c |   1 +
>  7 files changed, 545 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/platform/x86/intel/uncore-frequency/uncore-frequency-tpmi.c
>