Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 11:51:16 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Lorenz Brun <lorenz@brun.one>
Cc:     Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: log clock enable errors
Message-ID: <ZFoXlEJ4l9SZjSEZ@corigine.com>
References: <20230507214035.3266438-1-lorenz@brun.one>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230507214035.3266438-1-lorenz@brun.one>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lsb5n3io9Bu+04JSJ9oZuWISgKB+9ZEqiRye7D94KRp8XpebZy1Mexly73Nw?=
 =?us-ascii?Q?evOEMxPgSkOsPEFg+1oQjcvzrxP2BNfoOgM9V5BTlCZP72dr4osl0x0iuKlY?=
 =?us-ascii?Q?MPR+Da3q02JrOtE6CYTGt1ZiXmeTo6zkTJYmkyJPM9MIH4gspkUwiTbAdvZw?=
 =?us-ascii?Q?4U6H1HBTQgeoXcByO/TS0/55gg4iB6DPgcnvUcfMQS9SkpTiZ8ybhluchZVU?=
 =?us-ascii?Q?Ryw9p2swgdX3qJz46iBbR69TdiDay91xfJ8tqSGnEqYGyIxlCRZmKGip26gt?=
 =?us-ascii?Q?Y4MRdgcG3UX98FDWjJdw22bHDTN3ooKg7H6QVQBIYQRkynBPl2OaulilaPTd?=
 =?us-ascii?Q?hfyTf1Ngch5l4p7NsSd7spZi7KywA66rufxeGDHMiPmZTP2W2hR2OVjq8Pk9?=
 =?us-ascii?Q?5y+9god8mHAN3gJVnpDIdM8aCvPKzUiKJ7PzJkJoHqq2FaDceYLeGAmiK88F?=
 =?us-ascii?Q?qjyzBIuJyZ1b8sBMnzQbTlK+/3gsxGG5cCVr88PDqiFN6mkWkRzGe7kEIdiq?=
 =?us-ascii?Q?aoaJ4z4aLBVeYwGrNEO+m1YpGNqQ3uwyvkxx23NYY97v5D2+lihg0HUyhlbu?=
 =?us-ascii?Q?lT65iEjsszNwME+ckYLmQy14BDjUMu2u7GUNSKbsiU2jgFK0vkCS3Qu57Thy?=
 =?us-ascii?Q?q6hmoe+bVNYuKlP7t9ZoX0B0QW70Sy6mKIBTfNAxSArrDIO1uCJtvrTFyAVb?=
 =?us-ascii?Q?0bGFIOUk05uhLY8rZQtSFpSTkCr/5bvAy5syyChrduLQ0z68asz8aHg2c1SL?=
 =?us-ascii?Q?cnmLOIq5l5pSMtjkfGqNtL2OuousjByZiAvTYntLN+QPPbRfTeAbq61bEjAr?=
 =?us-ascii?Q?1aLQE+2Lia7O4fDs3x2Gy3Yq2G3tW0djTUDUGKKA8ZYl7FyQ4yjrfHWEy5lT?=
 =?us-ascii?Q?v1Aoo0fjP1tQOlPacRQ2rCTMBcjIImN0QJwDihZN8HGPZhutlHpZiSwtmBTk?=
 =?us-ascii?Q?zqcFJqmZENCQYjaOzsF8Obrh+jBzMLDUGIllAyJAkMY+izZz1uApPgtSzljw?=
 =?us-ascii?Q?TwxHdMX8+6vQfPhnPOHe/tNQ8msINyvh3/pE5BxnGOiirwY2xS+zivu+hGkE?=
 =?us-ascii?Q?uTi0XcectpZncB7hq9f/wYqEPwXHaIuvPP1z9ibJYYcoyzymCYBCqfap7VjP?=
 =?us-ascii?Q?rcECNqoVrPO3GvXf0vhMWF4NPIRrswAH79P7tinPnYyPwHHVEerBz2kKe9Vq?=
 =?us-ascii?Q?Ty9H24ca7KTQ3MI09u6Ajktyv4KC+u/iA4kgZg4wd8rXRnypMSjXOkZKZAKA?=
 =?us-ascii?Q?Wht4GhyJndQgW1uxt2057Zx6VV0umfCul/11z2Bd9ndHJjkKOUfBgv0zAeNQ?=
 =?us-ascii?Q?0+gmwsLn7Vu44ycLR8kZCKnred6O5a9nImcRcJ8tPN4mXOhD4xBtxY4kj5I7?=
 =?us-ascii?Q?Db3q4wX1kdIWj4bjxyrv7Ryzdh/lajZP8rvdGEqnQw2N4EljQEAbY4pmMGVu?=
 =?us-ascii?Q?XE5zpghIAsGfgCMw+cavHlNUXATRpmX3r/ldNSke8h7LXRD5McXsdW1ZOu7U?=
 =?us-ascii?Q?/1RzHjxm4DiJPqy3lSrFfcUv9ph0ZrTYefXuKgLWelZANLEWBlU3YxEJ1os+?=
 =?us-ascii?Q?V59pY+ELQJnLmSf0KllwnA/ngwj8lIiBWLMsmOYAdI6WGumcTeNKRYX08uwP?=
 =?us-ascii?Q?g2OCN70Ij4rWPqclQtIUNp/g68C2NiTAs4Z+T9lHh5gSi7PIKpwFvQLbT3qa?=
 =?us-ascii?Q?gWY4YA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59f5eaf6-eb00-40b0-d31f-08db5072f31c
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 09:51:24.2090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pml78bjzF8tsLvTWS/lmIIuDZSwaYQMd620gneNelUVLg0y5aKYDMMvjFRnQjJdaRps6rz/5mxkCBEJOFq1cbc4tI6hu0UCKbwfydRESCG0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR13MB6177
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, May 07, 2023 at 11:40:35PM +0200, Lorenz Brun wrote:
> Currently errors in clk_prepare_enable are silently swallowed.
> Add a log stating which clock failed to be enabled and what the error
> code was.
> 
> Signed-off-by: Lorenz Brun <lorenz@brun.one>

Hi Lorenz,

I think this would be targeted at net-next, and thus that should be noted
in the subject.

	[PATCH net-next] ...

Link: https://kernel.org/doc/html/latest/process/maintainer-netdev.html

> ---
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index e14050e17862..ca66a573cfcb 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -3445,8 +3445,10 @@ static int mtk_clk_enable(struct mtk_eth *eth)
>  
>  	for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
>  		ret = clk_prepare_enable(eth->clks[clk]);
> -		if (ret)
> +		if (ret) {
> +			dev_err(eth->dev, "enabling clock %s failed with error %d\n", mtk_clks_source_name[clk], ret);

I see that some error logs are generated by clk_prepare_enable().
Is it common practice to also log in the caller, as you are doing above?
(Genuine question, I don't know.)

>  			goto err_disable_clks;
> +		}
>  	}
>  
>  	return 0;