Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ad64af5e-050a-e103-3619-3ef0468985c6@gmx.de>
Date:   Tue, 9 May 2023 14:08:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH] parisc: kexec: include reboot.h
To:     Simon Horman <horms@kernel.org>, Baoquan He <bhe@redhat.com>
Cc:     "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
        "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
        kexec@lists.infradead.org, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230508-parisc-kexec-include-reboot-v1-1-78a155a8a0a4@kernel.org>
 <ZFoL9ntYCCfZFCNs@bhe.users.ipa.redhat.com> <ZFo0Gd/Eucw/0gtC@kernel.org>
Content-Language: en-US
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <ZFo0Gd/Eucw/0gtC@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:8kXG0SA0J80=;fnZ+jx+0PyaBK4EpXc2kcDzgp6x
 vcfebN7G8qetIF7ZQVY6lWwUaOGDt5VFoiyOb/wjY5x6YyJOI8q2zpw5QlejhOAHqv3GmeDr5
 GXzPqqQwhtC/4OseGJ7XtbT66o7nGyyq5uY+vfgB3O0Q9mTM4yOj8UGMmKWCevzvyzE/jxlgZ
 JM9rMvtR9umAspewFSYEG/fVMnE4Vsm6ThKu18nZ+aG5pbnZhznR0s0Kul5L5VtgoId9WLIds
 0RRadYK+lpaIzILOs+JDMSYFRQatGicOYLp3kh98yLPSMc1tulXMyCFgmYecEZrOjy45ERPSe
 9NjJ1XMGnJ2lfFbP3MPlq2hr9nD3qcgdGXHISlm6m1iygQR6HsI/UmbrYoWCy1WAXXYV8N4Pp
 lCaT4XAJ0Vo4mJeoGurGgkD4Wu2qdqsVGDanjYV1KD56kgaQcqK4Uw7v57TPIbRaNMbBBltcc
 iWxG7ieq3kAZ85tRE3PKVbLR60LJ/ETUu9mv303PTBMx7vLLgyLnwNP22q7dnkYB7D9sqKyue
 OwkiJNFHi2gvhXPTWcT4YXXj7sURJOexoN1B0Z138A7zVtosRYOrm1R5cjKjoXcYiDnIK2jDU
 yRVSBCVwnGgSXh0cq2G4XCtiLkWWBCoW7RBm9r+zb05lzbYYlwaaj3rvI0cTQynx98W6D6xSS
 yvC+sKH4aqeXZFM6NGFK2f4Yu7Q45A0QNipIrTY9jPr1BYFg9PgvvfHicEsnyhtxMLBqZ+yat
 0ouSTZABlcz6we942mtjL/Lgj0xs1s/63zMvtJHLkxCIBhtIlYaWjheH3h20X+j0EXmeVYNz7
 Y3LZ9U2jPrWIfs8EU0g7MqguyTZuiaRomPz/0i3AsYQa62UQVM+HSICbjUjmCY5Ob4SuF19LM
 7uRAJgKfUA8J3eilgMTio6VXE4gfsYkt/H+PVzPrErmtdwC4sast+h1a/RLCaRs6+auYA2UCU
 Y7fzIQ==
Precedence: bulk

On 5/9/23 13:52, Simon Horman wrote:
> On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote:
>> On 05/09/23 at 09:01am, Simon Horman wrote:
>>> Include reboot.h in machine_kexec.c for declaration of
>>> machine_crash_shutdown and machine_shutdown.
>>>
>>> gcc-12 with W=1 reports:
>>>
>>>   arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes]
>>>      57 | void machine_crash_shutdown(struct pt_regs *regs)
>>>         |      ^~~~~~~~~~~~~~~~~~~~~~
>>>   arch/parisc/kernel/kexec.c:61:6: warning: no previous prototype for 'machine_shutdown' [-Wmissing-prototypes]
>>>      61 | void machine_shutdown(void)
>>>         |      ^~~~~~~~~~~~~~~~
>>>
>>> No functional changes intended.
>>> Compile tested only.
>>>
>>> Signed-off-by: Simon Horman <horms@kernel.org>
>>
>> Acked-by: Baoquan He <bhe@redhat.com>

applied to parisc for-next git tree.

Thanks!
Helge