Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5702681rwr; Tue, 9 May 2023 05:23:21 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ms5fKXYL4uqxOr6ztjE1xk0cGGG8c1Rj+B4ey3sEJ3AlX488pBUitrIH5tuoNwfM9lrq5 X-Received: by 2002:a17:902:ea11:b0:1ac:9ab8:538f with SMTP id s17-20020a170902ea1100b001ac9ab8538fmr1845420plg.24.1683635001050; Tue, 09 May 2023 05:23:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683635001; cv=none; d=google.com; s=arc-20160816; b=LApY+V6rXYo9dYfmM09jJU7usS099lDMZo2eCYJWCLMEWJqET/i46LHov1+nq0pHXp vQtGQRhkKqbeO5Kqv8XcUyg8gHO6O+IiYhhzZ2Xp+SyqRQ8Enb9tiHmJ6QsHYsgrn4nL F+XqRbEHZ0TDevkvvt36DKS71U6ieGALk6TpvBIlpuXQvmYUaUdK+OX3+KDHk6g8dk6Q QlXfsVyz53BLKtPFn1Aigr1HXpEuvCumt54dKF27xym5IUM2QrArzOJAmPf8DNQtuVbs rGKQQlU0hPVQIVILMGkeDqKT12euBvjJconDdyyD2XpU6O+P5JEvzU2BidRfs2h50wAm hGcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=VtDcNKByG3QGqBaMWteEmBlx8o79YaY4wIW5CrphOKI=; b=yjxxuGDzv0MeIq8OylCdNteOxPUPc5z95ZNizpP8Ku0NwWaepcNoepkMwD/JJuwZ+y knPULCla6sDpDgd9mrfvW8R9wEijN4h7IUd97Vt79Ujmp8/VU8oOe8PRotERmOxxDW5Y dWDz3EjczQ8t68YCp3BumWyxsXYZkwLQeVA6BEp5CUp+Pc5gf+nkJQfy/bTSqZS6G98D w8QiQXqhw+HWOmZcmWvUukhnGft6kLaHBcD/q5Ul2HCJEOxmpJlc/DD7h1zWAS1ZIWXr x99lYLOBVhmu9Oa75M5yYnSjpOH8J6c30AmFihVCjsL5FS696YtS7mBSlJKF5yQgb8Ey A3Hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ozV/VUOh"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k6-20020a170902694600b001ab23cbe13bsi1351866plt.104.2023.05.09.05.23.08; Tue, 09 May 2023 05:23:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b="ozV/VUOh"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235493AbjEIMKQ (ORCPT + 99 others); Tue, 9 May 2023 08:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235674AbjEIMKK (ORCPT ); Tue, 9 May 2023 08:10:10 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14BC94202; Tue, 9 May 2023 05:10:08 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683634206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VtDcNKByG3QGqBaMWteEmBlx8o79YaY4wIW5CrphOKI=; b=ozV/VUOhCbdvdcwqxdtfXZdcaA90ARKwOnYQBRouWIahnMXGWDMqDNjRrHC/BBYWjq5SZl 0zVkjwMN1HrH8Nj5PlcDw7JkrmEq1wl2opWaW4iHlUWYz9rS55vTCEV7bvHci0YQS0msKe OiKR9k0tA7izR2CPXGYcFUsQfK7A+x/0KRvkRZX+qrF7KiQIDhvs0oyXBpq1rxJdGhfGCh MYC6WnITSxgPyRjiVJDU49KaDy0xrS7hBHILcujYL+/hxIaH+NoGh3k9eNjkZ5FjVDbyZQ FdCg0ek5JAc2T8OI8FHkzUUTTsC4j7rKC+fqFmbcQZsqVeexs2oybxw7tmiGyQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683634206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VtDcNKByG3QGqBaMWteEmBlx8o79YaY4wIW5CrphOKI=; b=ZLjODydBGy8cvSTodcStIAcmZAy/XrGuM8TLpXQA6c10hgPy1SCLXFLe3hFmS5CqBcJDXp pZHsXusMPUdgkGCg== To: Peter Zijlstra Cc: LKML , x86@kernel.org, David Woodhouse , Andrew Cooper , Brian Gerst , Arjan van de Veen , Paolo Bonzini , Paul McKenney , Tom Lendacky , Sean Christopherson , Oleksandr Natalenko , Paul Menzel , "Guilherme G. Piccoli" , Piotr Gorski , Usama Arif , Juergen Gross , Boris Ostrovsky , xen-devel@lists.xenproject.org, Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Guo Ren , linux-csky@vger.kernel.org, Thomas Bogendoerfer , linux-mips@vger.kernel.org, "James E.J. Bottomley" , Helge Deller , linux-parisc@vger.kernel.org, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Mark Rutland , Sabin Rapan , "Michael Kelley (LINUX)" Subject: Re: [patch v3 14/36] [patch V2 14/38] cpu/hotplug: Rework sparse_irq locking in bringup_cpu() In-Reply-To: <20230509110223.GY83892@hirez.programming.kicks-ass.net> References: <20230508181633.089804905@linutronix.de> <20230508185218.013044883@linutronix.de> <20230509110223.GY83892@hirez.programming.kicks-ass.net> Date: Tue, 09 May 2023 14:10:06 +0200 Message-ID: <87ednp1za9.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09 2023 at 13:02, Peter Zijlstra wrote: > On Mon, May 08, 2023 at 09:43:49PM +0200, Thomas Gleixner wrote: >> From: Thomas Gleixner >> >> There is no harm to hold sparse_irq lock until the upcoming CPU completes >> in cpuhp_online_idle(). This allows to remove cpu_online() synchronization >> from architecture code. > > Uuuuuhh.. damn. Can you at the very least ammend the comment near > irq_lock_sparse() to mention these extra duties? Will do.