Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5820973rwr; Tue, 9 May 2023 06:49:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7m/wctDQMTNt0/OiQGQdYIUnMtbqgxMLJfuDfsDIlJ5LVee1dX/CRWTR2FKUHtzMk0nh56 X-Received: by 2002:a05:6a00:1703:b0:644:c365:50d5 with SMTP id h3-20020a056a00170300b00644c36550d5mr13541938pfc.6.1683640157107; Tue, 09 May 2023 06:49:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683640157; cv=none; d=google.com; s=arc-20160816; b=xJsriqejpRAQAFcfXVaOAlbZ/UV9qy5d+sgnUxltRuKC9MX41YIZM1LbEveZYgto8Z LDu89xLcocziKd3hvp8JpUMosIu+tPofYsY/r3dYLcfOuLykbG952d8HvViBTbsV9c/j /iL197ce3CiW3FW9Kw/UUmucYrrNq214ESpllk+elqIYzVoKcph/VacuzuzT2M6+6jYJ hFu8Rw7m8uWVPKte/5xrIQ/YScYyngrgF+YS84FiTm6Uj/tw1ZOyDwLJPGj+DrrawjZx fC/rrCoovP+WtsowxLjH56fwJ3V5hTgRQPvo+rrWdLAOGFg3pWL+sE9p+InvFnwkhAF2 oNHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=YuQ2FBeCRoqgngylaRdOh7aqiqlvdZtnW5rbAbkcgXI=; b=NvPWGApZmPHPFUyd7xusWh4l0aw6JXNBbm//TJjv9rLfFH8rboDeH+mVttvF4ycs6I p34JX1BgvYLLjpMGXWhvy6UJ1gqY73qrF9n5Ok8f6gTCD/OPWbeKYJxi8Bpnr2Y1R60b J996JnTAEKzZY0n8J2RkVmXNOpYXapWtgvWnQwK9KMNVjgeJnx0NA5FGG9STQNHIaPEL rdTsGTEC0BvqHHg3bVlHBKbv7xcTBLCuaYTu4O3LzCSqM8/ivaJmyjUBQiCbeUhI2B2L wsP7Jrbm7osqVtXfOU9syDRSiVK6LyKciMTVpnZLaGonRIvXj5MC3yz5c1PNh6YoZ3Ws X0Ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AH1IzWoK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y3-20020aa793c3000000b0063b8685bab4si2428482pff.113.2023.05.09.06.49.02; Tue, 09 May 2023 06:49:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=AH1IzWoK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230060AbjEIN1o (ORCPT + 99 others); Tue, 9 May 2023 09:27:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjEIN1m (ORCPT ); Tue, 9 May 2023 09:27:42 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AD7A30CB for ; Tue, 9 May 2023 06:27:39 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3063b5f32aaso3794393f8f.2 for ; Tue, 09 May 2023 06:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683638858; x=1686230858; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YuQ2FBeCRoqgngylaRdOh7aqiqlvdZtnW5rbAbkcgXI=; b=AH1IzWoKD1GbxcF9ng7uQsTL872w02GkxK1Q77af/6B74iG8+N4tcxgxkyb7OF7cca Un3CHwFvJCOe9jANPaUvgVp3z6qPeSkMv78Q31nEc+DzNcFSqduVfxqpERiiTgbIxEiL uYMUNm2pcXy7AVAl7+aOS38etpxSM74rgG1X9Vn2TIAwXNuN0nU4CXYcCbL+WmYruQEi apXr7BQg6zkxzn3spKQUkefPlrDVExBq5LPRdpsYJdRwqgi+PMhrS6V0tRCETTl07OO5 LrlqLsPxnoVZa2FKaXipGlrepsiGlXi0YGBODqPF6rQGfvwQW0ALnAAUm7XW8EftFs0Y qQhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683638858; x=1686230858; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YuQ2FBeCRoqgngylaRdOh7aqiqlvdZtnW5rbAbkcgXI=; b=Kl5L9eEju5D03i648e+Esg6XRLwPrfr+7YDGWgqELHgpAwvB2utpXfjtV2V6sc681n axEQIM1VN3qDEh2Jh9Yd92y24/ixEAKzSEiGqlcty7SWFJ7DbQVzSqP1Q+MmGyNRzXgR 6JEY/rYVklEcJPqSJ68lgqjn6SOVZYBMi0uwIwuxcBApvZMyel10WsizBAxhIr8zVmTt vwprbULzAwlM8H63EnjHxEJ8qhwy97M3P+YKyJesPADxYvnOdysei9IIsM9QGNJWJqjN ZRq7PkYbu8uy0qQJq6T1t24qViqdgh/9IuU1nXmayHHZWjDq00XQfekyW7Y0s2xuLU59 OwsA== X-Gm-Message-State: AC+VfDwXcWre48fdFHOjBkNqkDkbJYWdJGdxrhCm9ce8I89UfaUPU8Zi r5mtLn+fKQ6vezBdaYa4G2OdIQ== X-Received: by 2002:adf:f491:0:b0:306:31b7:abe4 with SMTP id l17-20020adff491000000b0030631b7abe4mr11390420wro.14.1683638857874; Tue, 09 May 2023 06:27:37 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id d6-20020a056000114600b00306344eaebfsm14415375wrx.28.2023.05.09.06.27.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 06:27:37 -0700 (PDT) Date: Tue, 9 May 2023 14:27:35 +0100 From: Daniel Thompson To: Maximilian Weigand Cc: Lee Jones , Jingoo Han , Helge Deller , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Maximilian Weigand Subject: Re: [PATCH v1] backlight: lm3630a: turn off both led strings when display is blank Message-ID: <20230509132735.GA31274@aspen.lan> References: <20230505185752.969476-1-mweigand2017@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230505185752.969476-1-mweigand2017@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2023 at 08:57:52PM +0200, Maximilian Weigand wrote: > From: Maximilian Weigand > > Use display_is_blank() to determine if the led strings should be turned Shouldn't this be backlight_is_blank()? > off in the update_status() functions of both strings. Once the description is fixed this is: Reviewed-by: Daniel Thompson Daniel.