To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Greg KH <greg@kroah.com>, linux-pci@atrey.karlin.mff.cuni.cz,
       linux-kernel@vger.kernel.org
Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg()
References: <87abr0oyj4.fsf@shaolin.home.digitalvampire.org>
	<m1ir5ocaxr.fsf@ebiederm.dsl.xmission.com>
From: Roland Dreier <roland@digitalvampire.org>
Date: Wed, 03 Oct 2007 12:13:41 -0700
In-Reply-To: <m1ir5ocaxr.fsf@ebiederm.dsl.xmission.com> (Eric W. Biederman's message of "Wed, 03 Oct 2007 12:25:36 -0600")
Message-ID: <874ph8ovtm.fsf@shaolin.home.digitalvampire.org>
User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.20 (linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 820
Lines: 20

 > > While reading the MSI code trying to find a reason why MSI wouldn't
 > > work for devices that have a 32-bit MSI address capability, I noticed
 > > that read_msi_msg() seems to read the message data from the wrong
 > > offset in this case.
 > 
 > Doh!  Sorry about that.

Doesn't matter, it wasn't the bug hitting me anyway :) the IRQ never
got affinity changed so read_msi_msg() never even got called.

I'm starting to think that Intel 945GM graphics just has a busted MSI
implementation, although there may be a bug hiding in the Linux code
that I'm not seeing.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/