Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 16:43:11 +0300
From:   Leon Romanovsky <leon@kernel.org>
To:     Yunsheng Lin <linyunsheng@huawei.com>
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/2] net: introduce and use
 skb_frag_fill_page_desc()
Message-ID: <20230509134311.GN38143@unreal>
References: <20230509114337.21005-1-linyunsheng@huawei.com>
 <20230509114337.21005-2-linyunsheng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230509114337.21005-2-linyunsheng@huawei.com>
Precedence: bulk

On Tue, May 09, 2023 at 07:43:36PM +0800, Yunsheng Lin wrote:
> Most users use __skb_frag_set_page()/skb_frag_off_set()/
> skb_frag_size_set() to fill the page desc for a skb frag.
> 
> Introduce skb_frag_fill_page_desc() to do that.
> 
> net/bpf/test_run.c does not call skb_frag_off_set() to
> set the offset, "copy_from_user(page_address(page), ...)"
> suggest that it is assuming offset to be initialized as
> zero, so call skb_frag_fill_page_desc() with offset being
> zero for this case.
> 
> Also, skb_frag_set_page() is not used anymore, so remove
> it.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> ---
>  .../net/ethernet/aquantia/atlantic/aq_ring.c  |  6 ++--
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  5 ++-
>  drivers/net/ethernet/chelsio/cxgb3/sge.c      |  5 ++-
>  drivers/net/ethernet/emulex/benet/be_main.c   | 32 ++++++++++---------
>  drivers/net/ethernet/freescale/enetc/enetc.c  |  5 ++-
>  .../net/ethernet/fungible/funeth/funeth_rx.c  |  5 ++-
>  drivers/net/ethernet/marvell/mvneta.c         |  5 ++-
>  .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  4 +--
>  drivers/net/ethernet/sun/cassini.c            |  8 ++---
>  drivers/net/virtio_net.c                      |  4 +--
>  drivers/net/vmxnet3/vmxnet3_drv.c             |  4 +--
>  drivers/net/xen-netback/netback.c             |  4 +--
>  include/linux/skbuff.h                        | 27 ++++++----------
>  net/bpf/test_run.c                            |  3 +-
>  net/core/gro.c                                |  4 +--
>  net/core/pktgen.c                             | 13 +++++---
>  net/core/skbuff.c                             |  7 ++--
>  net/tls/tls_device.c                          | 10 +++---
>  net/xfrm/xfrm_ipcomp.c                        |  5 +--
>  19 files changed, 64 insertions(+), 92 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>