Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 23:12:46 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc:     Ravulapati Vishnu Vardhan Rao <quic_visr@quicinc.com>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "moderated list:QCOM AUDIO (ASoC) DRIVERS" 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC:codecs: lpass: Fix for KASAN use_after_free out of
 bounds
Message-ID: <ZFpU3iIhoWA4oIhf@finisterre.sirena.org.uk>
References: <20230509103232.20953-1-quic_visr@quicinc.com>
 <bb67f4b0-e96a-3718-f855-80e1d21e9d38@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7MjTQKZ/juz56Sws"
Content-Disposition: inline
In-Reply-To: <bb67f4b0-e96a-3718-f855-80e1d21e9d38@linaro.org>
Precedence: bulk


--7MjTQKZ/juz56Sws
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 09, 2023 at 01:26:32PM +0100, Srinivas Kandagatla wrote:
> On 09/05/2023 11:32, Ravulapati Vishnu Vardhan Rao wrote:

> >   	val = ucontrol->value.enumerated.item[0];
> > +	if (val < 0 && val > 15)
> > +		return -EINVAL;

> how about

> if (val >= e->items)
> 	return -EINVAL;

The enum value is passed as an int so is signed unfortunately.

> We could get these checks if CONFIG_SND_CTL_INTPUT_VALIDATION  was enabled.

You can't rely on that being set.

--7MjTQKZ/juz56Sws
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRaVNsACgkQJNaLcl1U
h9A0Uwf/UvIT8fZeRNOkWNIfq84pL8mhWAPjeWjO0KZMX5qY6ryVzPuDQY3cuv5S
cH0vyKy12IWKEFhMwN+kM1h70iiX+Ai7STIp+6tJWJnXTGlZmpi1qwGy9yDc2Zxz
30c8CyfvhFYm3y6cJGOq/D79DABrDT1xeG1HG4/CAhFagIQBruQ9/2gnHJIhfcfx
UVGfLUmU8srAmBE/o8DyrME67anVAn5jEttqIdetnCyISSF0Svu9xyx7pM9k0WQs
nOcCE+PfRL6owkajRu+pnBpimZXX4zXmUBwcQl+KDIxexpp2eAR35OgK9KXn0kE/
lRZcSZ1/feq8gjoO/Fh6AcJghyasxA==
=qvvD
-----END PGP SIGNATURE-----

--7MjTQKZ/juz56Sws--