Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 23:36:56 +0900
From:   Mark Brown <broonie@kernel.org>
To:     Ravulapati Vishnu Vardhan Rao <quic_visr@quicinc.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        "moderated list:QCOM AUDIO (ASoC) DRIVERS" 
        <alsa-devel@alsa-project.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC:codecs: lpass: Fix for KASAN use_after_free out of
 bounds
Message-ID: <ZFpaiBs19P2m2i/q@finisterre.sirena.org.uk>
References: <20230509103232.20953-1-quic_visr@quicinc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rp6eN0jACiHvaET+"
Content-Disposition: inline
In-Reply-To: <20230509103232.20953-1-quic_visr@quicinc.com>
Precedence: bulk


--rp6eN0jACiHvaET+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 09, 2023 at 04:02:31PM +0530, Ravulapati Vishnu Vardhan Rao wrote:

>  	val = ucontrol->value.enumerated.item[0];
> +	if (val < 0 && val > 15)
> +		return -EINVAL;

Srini is right that it'd be better to read the upper bound from the
control, that way it can't geto out of sync.

--rp6eN0jACiHvaET+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmRaWocACgkQJNaLcl1U
h9DFwwf+OGbDrdaAcrzv8y4tkJVfYVW0CN+Vi2I9TmTYkFz4yMuHLYz4/+Lqrqvb
VwxCESut40IbIG923f8kXLHI1ZLyMYZYfijCjhozfmIMwq+4IDclDAVN7X1nsSl9
U/AlK2kQ1E4hS2TLLqUgno9doE3EFXgJuKCfwT6AAWIK+T169fN3dXTlFT7SeTcP
OO+qkTftBiuYGKMW7hMZCvcOnw7lhgso2MP6iFVSZGHr67rB84cNOvgJ4og6J90U
+2wOn5Xdw4KepnGGOFl7uD8B5XbTeva3ooOEkkRDa+oEZ/L6VmvsnQm30N+iC935
xuGsCPLEIwrsj9V571lsqHei093EBw==
=QfcG
-----END PGP SIGNATURE-----

--rp6eN0jACiHvaET+--