Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp5997784rwr; Tue, 9 May 2023 08:55:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ccH1nG7XRvb+U+09iXmTXkLtw0yL2tEmuEMSxz807kIagZBVTilqP4d0Qm4zMwHQNzrcN X-Received: by 2002:a05:6a20:9389:b0:ff:e397:cb7e with SMTP id x9-20020a056a20938900b000ffe397cb7emr13689329pzh.33.1683647716701; Tue, 09 May 2023 08:55:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683647716; cv=none; d=google.com; s=arc-20160816; b=Dp6WVqo9qwI8NrfFEMqjpMujGpDAViCTZplyQ2jJTdHj/JoHxHmyDm/VAG5H4WEtDn L+Lq6HhSzf0k+dHkv52T+BfzTnSwTJaX2f1czhrvsOhMisE+8i0njqjnWwZnkyz5Exd2 Exx8OtHJJGyVC2a849aVju+jnwGmDQAsR2KEYdAKP8M1tEZRWcPpBtP+sLYUjDGGaVJg masLWm5j/hWJ+UbjbNIGi2nGBkHWI6gXzI3nnpX4FYpT6Nuy5gxvujtnv8tL8nYtm9vC MrstvAG/CMP+GUvQGMl0IQgvOl6Dm/fQWPCc7Kg4EUvqiI+2+QrY0OD31ZQTq88IeUw1 1UGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=znDwmoweGIbazinqZk+RMiWAEky714GctekUC5TPRSI=; b=ty4c+jskYbdaowQCzO7Ca3v8wwdk2Sj6RDU3ccC3du2l/+eIjDFhW3cqqNVDQ7yu9e mk2nvTmzlNk+hr571o0B6SIy1z/hUUyKTEOM//bX4CaCdXJQU9a0M2vS53152QfZeRN0 efjWs0F1bO1mAKTa+kcGI8LLgUwd/0o5bu4SrCemqY04IcH8TA0uRz0BnXuEtR7i0jv7 1+iEMUQO++MjzuF2BAuY4JBjyHfhXGJsf8rU1OMUx5n/z068W6gkV3/Hf3e/+ilkp1wl op+RlGxZA0SE/hrqhFrMwTHeLpuY0cXQcMi714BNfvKbWGULe6FXgDPPKC095P8vDAhx YNhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KKOZZnf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e5-20020a63aa05000000b00528595a1390si1836682pgf.588.2023.05.09.08.55.03; Tue, 09 May 2023 08:55:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=KKOZZnf9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235836AbjEIPiD (ORCPT + 99 others); Tue, 9 May 2023 11:38:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234828AbjEIPiB (ORCPT ); Tue, 9 May 2023 11:38:01 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 272B646B2 for ; Tue, 9 May 2023 08:37:59 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1aad5245571so41549125ad.1 for ; Tue, 09 May 2023 08:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683646678; x=1686238678; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=znDwmoweGIbazinqZk+RMiWAEky714GctekUC5TPRSI=; b=KKOZZnf9GqB+bW2sq2bGj2OI4Eksv6MexBLK85NQVZrQbRXviqwAWY5u3yzTIeTtW6 YtVYXZiCtfv1Ymn8pVeuL9rZZYJFYH8ay+4vC1dPp7IJNo5eWO31dxpkxT62JzvWBgMh I/T+6AmVV4FoUE04NVug7mYJmZb0vUH6TciApC35IgdiGsCSqrRkYP1PnQTutASx/0NG lsOq3BnDP6SBV4BZ19RYWCVYPNaCAW6+PtB7nTeU6nCcfx7rCmbomBZkuhhLLBkpSmP3 uTBJufpBY0KQijq+q5j3XyfvziuhLI2WRViYJwl0lP1FecYYL3b8Hw7PkofkfkjYcpZf JDqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683646678; x=1686238678; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=znDwmoweGIbazinqZk+RMiWAEky714GctekUC5TPRSI=; b=aqLvEVN5Qlbma03dJ1qx+kmHDzK6EXC8bJjEjDXCZhQI+MOh/ILTpegFgxdoHm8mHs FnxZ5LEPBce2NxZeo6mifmgX2xESmY+pPVGWm7o/XBnSYEcWc8/S6WoxFU/XhYB4tbu4 OLqn2a671INAgtpFqULkQVahKLju3heXtbH/cNO6p2Hn5ywGwbbnW20ACEte6CsSFey9 egiPeSwFaVt1QBo2sVCq/0T7Op8EHIZncQglOZmalcMxqRE1F2J3paKQIkf0n2sert+9 3Mc05GRUKQAZSnAkKrFa6OQXCse4sjbDP+p5VjNbAhGaCHIea/gZEsTlIOEBklAqBUjf ShHg== X-Gm-Message-State: AC+VfDzKsv3JxO0K2xkxTBALq6ymLQQO8aikIdfg39Rk39ldZye0rnKi wWhGs66Vc5P5PgZQvle8jH8exskN8NM= X-Received: by 2002:a17:902:d2cb:b0:1ac:7ea7:6ccd with SMTP id n11-20020a170902d2cb00b001ac7ea76ccdmr8190149plc.34.1683646678123; Tue, 09 May 2023 08:37:58 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-a7fa-157f-969a-4cde.res6.spectrum.com. [2603:800c:1a02:1bae:a7fa:157f:969a:4cde]) by smtp.gmail.com with ESMTPSA id i1-20020a1709026ac100b001a64011899asm1753977plt.25.2023.05.09.08.37.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 08:37:57 -0700 (PDT) Sender: Tejun Heo Date: Tue, 9 May 2023 05:37:56 -1000 From: Tejun Heo To: "Paul E. McKenney" Cc: jiangshanlai@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH workqueues] Further upgrade queue_work_on() comment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2023 at 04:47:07PM -0700, Paul E. McKenney wrote: > The current queue_work_on() docbook comment says that the caller must > ensure that the specified CPU can't go away, and further says that the > penalty for failing to nail down the specified CPU is that the workqueue > handler might find itself executing on some other CPU. This is true > as far as it goes, but fails to note what happens if the specified CPU > never was online. Therefore, further expand this comment to say that > specifying a CPU that was never online will result in a splat. > > Signed-off-by: Paul E. McKenney > Cc: Lai Jiangshan > Cc: Tejun Heo Applied to wq/for-6.5. Thanks. -- tejun