Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHwB_NLBLEUiu__fE9F=j0KFssq7Lxfz8WUnbR0C6yi=zsboJw@mail.gmail.com>
 <20230509025153.1321446-1-yangcong5@huaqin.corp-partner.google.com>
In-Reply-To: <20230509025153.1321446-1-yangcong5@huaqin.corp-partner.google.com>
From:   Doug Anderson <dianders@google.com>
Date:   Tue, 9 May 2023 08:42:30 -0700
Message-ID: <CAD=FV=Xp_OoxJH38skQswjK_AWwJ5P2OmgjnXLog9bAht0CL6A@mail.gmail.com>
Subject: Re: [v2] drm/panel: Modify innolux hj110iz panel inital code
To:     Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Cc:     thierry.reding@gmail.com, airlied@linux.ie, hsinyi@google.com,
        sam@ravnborg.org, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, May 8, 2023 at 7:52=E2=80=AFPM Cong Yang
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> There is a problem of screen shake on the old panel. So increase the
> panel GOP component pull-down circuit size in hardware, and update the
> initialization code at the same time. The new initialization code mainly
> modifles the following.
>
> a)adjusted for GOP timing. When Display sleep in, raise all GOP signals
> to VGHO and then drop to GND.
> b)Increased the Vertical back Porch and Vertical pulse width, so need to
> update vsync_end and vtotal and CLK in drm_display_mode.
>
> Signed-off-by: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
> ---
> v2: Modify commit message
>
>  .../gpu/drm/panel/panel-boe-tv101wum-nl6.c    | 397 +++++++++++-------
>  1 file changed, 235 insertions(+), 162 deletions(-)

Every time I see the opaque changes to the pile of "DCS_CMD" arrays I
feel obliged to grumble a bit, but as I've said before I guess it's
OK-ish...

Thus, this patch seems fine to me:

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Just to make sure there are no objections, I'll give this ~1 week and
then I'll land it to drm-misc-next.

-Doug