Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <afeb0ced-e4e9-6039-893e-b50268c1c148@oracle.com>
Date:   Tue, 9 May 2023 09:13:08 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.10.1
Subject: Re: [PATCH V4 2/2] blktrace: allow access trace file in lockdown mode
Content-Language: en-US
To:     Paul Moore <paul@paul-moore.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-kernel@vger.kernel.org,
        linux-security-module@vger.kernel.org, linux-block@vger.kernel.org,
        nathanl@linux.ibm.com, jmorris@namei.org, serge@hallyn.com,
        konrad.wilk@oracle.com, joe.jin@oracle.com
References: <20230420215331.88326-1-junxiao.bi@oracle.com>
 <20230420215331.88326-2-junxiao.bi@oracle.com>
 <05b3eebd-7a3f-13d5-1fe9-8f4ab3080521@oracle.com>
 <30ab7555-8f36-cfb7-9101-0ebb92af3c2f@kernel.dk>
 <6300a33a-9d3d-42a2-d332-81e02d52d310@oracle.com>
 <CAHC9VhT2uCc5ePi+ung+rLaDiLCCCF=fjq8G+D3FJf0i4E8_hQ@mail.gmail.com>
 <f016d747-c01a-c46e-59a7-13d0d6306827@oracle.com>
 <CAHC9VhSCjuJZ122EqdDxzJTU1tGq5nU_3+11WGKZ-WHjzU2FBw@mail.gmail.com>
From:   Junxiao Bi <junxiao.bi@oracle.com>
In-Reply-To: <CAHC9VhSCjuJZ122EqdDxzJTU1tGq5nU_3+11WGKZ-WHjzU2FBw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVBFWnNVM3hsQXFWNmRmMmdLU2NRckhjRTJvVU9ZWVZjSTZIQmtTL3lrbmJS?=
 =?utf-8?B?Y3RyUFRIZDdYblVHa3V3QU1yU3cvRWNmR0pub1VvcFhKdjFQVnZ0K2UrbzE3?=
 =?utf-8?B?T2lJQ1BsVU81SkFwOGhyclQ0ZUxMM3gxRmViR0d0c1ZnekFQWUJkaWxzc0s1?=
 =?utf-8?B?eHRKNU43Q0N6aEFjQS92SVNZdjNoS3UzYVVJU1dQaGdwdERPYnI1QUlyMTVD?=
 =?utf-8?B?V1VCcTVOWmYxOG5pSWlTUnJjTlVnZzVpV05DWXJyelVDZnh2aFN6eUdzdmgr?=
 =?utf-8?B?SG9hTTVwbDlPUW1IQ3Y4VGhVTGhKN3ZDOE1MYnVhbXJTdmxEa250UXlTRnQ5?=
 =?utf-8?B?ZXozMFN1a056WnpEZHNPN044cmRlcXl5dEpIaHhzOWJ5UGFrYlZYR3N3VjIx?=
 =?utf-8?B?TVRkK1llSkN0Qno1WHhxWHN1V3FMeEY3NXlBOFRaNHJKWmRmaEJsYmdaWjB1?=
 =?utf-8?B?MDZaR3RVSGFNWklvdHBWS1hYT2R5NjNtb3A4YzlsTzU0RFEwU3EzOForWmF2?=
 =?utf-8?B?dHA4K3ZEZnJlY2V1R0hWMldmRDBWa3puOFpsMEdtYmo5elRBcEFjWjFlcWdn?=
 =?utf-8?B?aWJLVVYrRzZ4Rmk5MW1UeDJhbzFzdWtmOHNpVGkyam5rUENRVm9tbHNmMnQw?=
 =?utf-8?B?K09NVnBwckNROXdWaFZnc0k1MVFMSWxkcFIremlJNVpEaGlCcUxpYjZWTXZi?=
 =?utf-8?B?cC9XTnI3bkVTK0YyL1dxOHAzLzMwTVpjU3JOTld4YTdOVlpLZ1p3WkE2NExC?=
 =?utf-8?B?ZkcyL1dkcVdIaGRxeGx5Q2NzeDlVaWMzMEJlaXE1dFNkRmFxb2pVdWNnR3RD?=
 =?utf-8?B?dWRXL2NqRjhvU3hoSk5rNDRUWnpNQnQ0TkpLaWJHeHpHWHV1bDAzajQxV2Ns?=
 =?utf-8?B?b1lYYlFTSnBEajRUSEFDOFpsY0pLcFMza0MxSElsTDBCRCtsL0dsRSt6by9l?=
 =?utf-8?B?T1Z6bFBUTm9SV2c0alh4cVd4eWdJdlRIYkRyd1VhdUFuTXRTZzhsYnpCaElE?=
 =?utf-8?B?MXFWODgyYVJJYjlRdEQrd2lWeFZ1V09ZTkxnNE45VGl1RUZ6YlNYWU9SNHZW?=
 =?utf-8?B?aTh1akJQc0VrVGRBZVFwY1MxZ09kMllwZG0yY0RDcDk1QlRGWmdxRGhRSnBh?=
 =?utf-8?B?ZmxDZFpyeVpiTmV3VU1rMFhBYmczMWFEbGZEb1R6REhwZlJZTHBHeThuUXUz?=
 =?utf-8?B?WmV6TzFqbkplV0ZER0V6SU8xcStZa1lrUDVhNDJjSEJ5Tk1wM1o3czFncG0w?=
 =?utf-8?B?YkU4S0RmeWQ5WklmU0VnYTNVU0hGMHhLRTQwMUQxdlJ2Q08wbzkvM2YvSTBa?=
 =?utf-8?B?UjRxcG83NC9jSEoxTjg1b21sT05iM251YlZJNTg3cTZaZk9JN28wWGt1b0Mw?=
 =?utf-8?B?WW1SRmYxQnZubnd2Wklzc0xpbWlPajExOE1tb2hxcUVBQXZiV0JoTTF0UWo2?=
 =?utf-8?B?OWU5Mm5XRENYWWN6OTE5TjJiV2h3Szl0enFCdWJUZG41dDlPemJHVC9QV3U1?=
 =?utf-8?B?dlBHN1NIQnhzQW9XdGtRY1k3dTJwaHZJb015ZmdaTi9GaEhCb2xUcnd4ZERa?=
 =?utf-8?B?U3JqU0RyaWNRNm8vUzBEVHVSN0pFMXJjaENDbXVNOXBRMWRuNTExMmt4eFln?=
 =?utf-8?B?ZFBqQm0zOTU0OUZrTmxlRmpBQ3VZbmhNaGNvanVOemQ5VGFnakFkRncva1No?=
 =?utf-8?B?K29DdEc2UnJxQnpVRXVrU1N0Q0U2YkkrcTF2NGgxTFdJZzZwRG1tbklsVTVH?=
 =?utf-8?B?bWJtdkJvWHQ1NC9ja2lXK1VjR1RIVTd6NzNIRmVwZEh0bHdQWFBmc3VYYnIv?=
 =?utf-8?B?RzQxcHlsYXRFS1BQRzhOS1FHSjRXRnlsQnJKNkVLNXVtd2F1WjdsYkc2SU1w?=
 =?utf-8?B?TnZzQVBvZTNHVjNrajRvSGF6b25ZTlVzODFDb2lwcFg0bVpkdWliYkxrVzBm?=
 =?utf-8?B?NlNwTlIrL2lqSnBKQThobXh4dHhNWk9zaW0yYzQ0aHNiVW9GbnNEeWkvRXRk?=
 =?utf-8?B?VERQck0wVWtobmpBVXhsMXVJV0ZVaU5vRS9zMWl2eEsvMjdHYjV4T091Nm1u?=
 =?utf-8?B?K2ZIN3Brc1diMXJ5Y0Y5ZTY2S3lQeFB1eDhUSnV0andpcy9sVDhORmRCbE5D?=
 =?utf-8?Q?o+l4qo8FkTqnbpSXDbjPQA5OY?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: oNsoO0S6Gx2/dYNTKYGMTpOxivdza5AnRwSiTRSo1B0nUUctOh/234tPqCuCKiDwaORF+JMnPq1ZdKWiXeR4qJ140j4Af0RVQf6jizxz0t52jIqDThfQwrBTeC6jt7bzDTj3R+62mhnD2HVaQUF9Y2RkaiFywA/KttuFb2RzBFQv9a5ZozZG6pC0r4PveC7xLjDda4V7J3SLS6KEgrnWGYOLWG+V0ccSpB9yK8GxjQK6ahWdO6oUhBPfBtIyNb535sI+cfF2OaWavMiG7aH/rtmVv7AzGwdTmCJekR1mNUQcaoL2NhJRSedxsoUfDKDNfgfvBbIGevHKsQKVshcXJfXRPLzxQMHC+RxJ3LxaFJHmkOs4FzP05Y24BUo0E8+IWjWH2rnGGZGYJXNp/wm6J3rTqQdsR5zxLwSyynF9/psprrJftpDKBdNFrKvYMFWjEwpgncoiPJ/r+qPNQ9vUodd3zL5YsO+ZXFQDKf1W/OfTtZzT/VlDRiXoyZakZvtGSYHEbrTO1XOE/Zs5k4gpexSDC2EeabVMx8Hv1l7LMAllqu19M6gsdVmSHBvWjYwRvPvBNrr0waL8JyKvscUiHK+Qgmf67dfICasGPWMJlrf+9ftFSJa+adpNG4mBPmGrU6pxnbTGw43N8ELT+zkY8qr3nkGgA/pWAcuRErj6j1FQ0sDPjAFNIWcPWgVuHGoFIY/Z24fA4rDpTe4903xuvLjBWSlTyftGL66TO1fLzBa4i1CY4LrfQeDgoFnTJiKFaL8YKGKWYIff6OuHzEfzhLOKSVLBFnycs2G7wSgTIWRbLb/NB2Qhg2r937QIOJS//ch1RPT09l6SdJ8caHdZ1fWwcPFL1yKuEFAxuabE8oKyp3d8+6EKW+LNf0GkE4nSSGZg7jvSgrcOXCZtrwrMa+2zzJFZtnf4aXeuIWlvZjw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: caf1ce2c-a93c-4670-f64b-08db50a84907
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4752.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 16:13:11.5826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jJ54mFdloj68lhlJOC6juYzHQAAVV1Vd6ahD+14qGJqjaC4cGH4J3s18R1V3w4odHSfXOJY6vTZeN6OgxReS6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7633
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-05-09_09,2023-05-05_01,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 mlxscore=0
 bulkscore=0 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000
 definitions=main-2305090133
X-Proofpoint-ORIG-GUID: gFLoN9bxhhDsvAagHVMmebeHxOzMfK-6
X-Proofpoint-GUID: gFLoN9bxhhDsvAagHVMmebeHxOzMfK-6
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/30/23 2:46 PM, Paul Moore wrote:

> On Fri, Apr 28, 2023 at 6:41 PM Junxiao Bi <junxiao.bi@oracle.com> wrote:
>> On 4/28/23 2:26 PM, Paul Moore wrote:
>>> On Wed, Apr 26, 2023 at 12:33 PM Junxiao Bi <junxiao.bi@oracle.com> wrote:
>>>> Paul,  do you have any other concerns regarding blktrace? As Jens
>>>> mentioned, blktrace just exported IO metadata to Userspace, those were
>>>> not security sensitive information.
>>> I think this version of the patchset is much better, thanks for your
>>> patience.  I don't have any further concerns, and since the lockdown
>>> LSM doesn't have a dedicated maintainer I think you should be all set
>>> from my perspective.
>> Thanks a lot for the review.
>>
>>> Since there are no changes under security/, I'm assuming this will go
>>> in via the tracing tree?
>> Should I notify some specific maintainer or mail list for merging?
> When in doubt, the scripts/get_maintainer.pl tool in the kernel
> sources can be helpful.
>
> The results for the debugfs and relay files are fairly generic, but if
> you look at the results for the blktrace.c file you get a more
> reasonable list of maintainers and mailing lists.  I believe Jens has
> already commented on your patches at least once, I don't recall if the
> others have or not.  I see you've already CC'd the block mailing list,
> so that might be enough.
>
> Keep in mind that we are in the middle of a merge window so it is very
> possible this patch might not be merged in a working/next/etc. branch
> until after the merge window closes (every maintainer is a little bit
> different in this regard).

I didn't see the patches in the trace tree yet, maybe better to merge it 
through block tree since it's a blktrace fix.

Jens, can you help merge these two patches to your tree?

Thanks,

Junxiao.

>