Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 09:16:23 -0700
From:   Bjorn Andersson <quic_bjorande@quicinc.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
CC:     Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Andy Gross <agross@kernel.org>, <linux-mmc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp: Add SDC2 and enable on
 CRD
Message-ID: <20230509161623.GA1765076@hu-bjorande-lv.qualcomm.com>
References: <20230509030136.1524860-1-quic_bjorande@quicinc.com>
 <20230509030136.1524860-2-quic_bjorande@quicinc.com>
 <20230509063205.GB4823@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230509063205.GB4823@thinkpad>
Precedence: bulk

On Tue, May 09, 2023 at 12:02:05PM +0530, Manivannan Sadhasivam wrote:
> On Mon, May 08, 2023 at 08:01:36PM -0700, Bjorn Andersson wrote:
> > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
[..]
> > +	sdc2_default_state: sdc2-default-state {
[..]
> > +		card-detect-pins {
> > +			pins = "gpio131";
> > +			function = "gpio";
> > +			drive-strength = <2>;
> > +			bias-disable;
> 
> Since the card detect is active low, shouldn't the pin be pulled high to avoid
> floating? Or is there an external pull up available on the board?
> 

There's an external pull up resistor to vreg_s10b, so there shouldn't be
any reason to pull it internally as well.

Regards,
Bjorn