Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758686AbXJCUfd (ORCPT ); Wed, 3 Oct 2007 16:35:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755141AbXJCUfV (ORCPT ); Wed, 3 Oct 2007 16:35:21 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:46168 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755840AbXJCUfT (ORCPT ); Wed, 3 Oct 2007 16:35:19 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Roland Dreier Cc: Roland Dreier , Greg KH , linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: Re: MSI: Use correct data offset for 32-bit MSI in read_msi_msg() References: <87abr0oyj4.fsf@shaolin.home.digitalvampire.org> <874ph8ovtm.fsf@shaolin.home.digitalvampire.org> Date: Wed, 03 Oct 2007 14:34:58 -0600 In-Reply-To: (Roland Dreier's message of "Wed, 03 Oct 2007 13:03:44 -0700") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 21 Roland Dreier writes: > > Well it is a bug worth fixing. Who knows it may have something > > to do with the disable_irq problems the forcedeth driver was seeing. > > I agree completely, the fix looks obvious and there's no point in > leaving the bug there. I just don't have a test case that I can point > to as being fixed by this, since I don't have a working 32-bit MSI > device... > > Do you know whether the forcedeth devices have a 32-bit MSI address? Sorry I don't. The ones I have don't have an MSI capability. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/