Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0764089b-c256-8b96-6604-b9a472f2430a@amd.com>
Date:   Tue, 9 May 2023 13:20:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [RFC PATCH 03/40] drm/amd/display: introduce Steam Deck color
 features to AMD display driver
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>
Cc:     amd-gfx@lists.freedesktop.org,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        sunpeng.li@amd.com, Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Joshua Ashton <joshua@froggi.es>,
        Sebastian Wick <sebastian.wick@redhat.com>,
        Xaver Hugl <xaver.hugl@gmail.com>,
        Shashank Sharma <Shashank.Sharma@amd.com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        sungjoon.kim@amd.com, Alex Hung <alex.hung@amd.com>,
        linux-kernel@vger.kernel.org
References: <20230423141051.702990-1-mwen@igalia.com>
 <20230423141051.702990-4-mwen@igalia.com>
 <613b2431-7d05-fb44-25d7-dba59e5eca3c@amd.com>
 <20230509162353.7hak3fda43fim3ho@mail.igalia.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20230509162353.7hak3fda43fim3ho@mail.igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bE5QQVhPeGxmekRESTMvOWdWVXpKb001OThwWFZXZnNaN2ZVOHh3RVB0QXhL?=
 =?utf-8?B?WThCREZIMUlXUXRYeXQwNVRyOE01Yi9PbE1haXNKdW1NRXBja3pEUVA0cGN1?=
 =?utf-8?B?QlphcUJhSVBmWnpVYzdBTDNMVkM5UXBYdzNTWDl2R2JRVHN3Q2J2RWo0alZD?=
 =?utf-8?B?VTNuYUE2b1BhU3Rsa0piRTFVVTdubmxZOXQ1VlNDNzlRTCs0dEZMU09OcjBJ?=
 =?utf-8?B?Z1NXQmNoRjhxUmhsSXluWmdvR2R1YmJZN1RVSUpwdW1VQnRsN1Boa0hNZGxB?=
 =?utf-8?B?ZDV1M0laUEFLeGErdU5oek1jUTJ2aHNPL1RTY2NybmVOMnpMOUZkM3NYSFRB?=
 =?utf-8?B?dC9lcjR5WHZ2WmpNK0padFNUaVFLQWpVVEFwN3dvVTc2OXJIeUcrZEIzYS81?=
 =?utf-8?B?NGRtbEZyZmVFN25ZYWdvaEZFbTZnWVVrSUU4VGYrbThBUmxZM3BJU0M4UGVP?=
 =?utf-8?B?d0t6bFlaMzNya1hwekxISHY2OWZjeFZCaEpSWjhmM0Uxd05HeFhZdW1ld0R2?=
 =?utf-8?B?UlBZaEExMnpwVGRNVGtlNXhsZm84by8wdmR5TGpIRUxhQUR2ZzUrZWZEb3Mv?=
 =?utf-8?B?cy84RUVmSG1wRytwMEZTSUJneE5xTWEwcjBXdHovVGNVSHhDL1pMbm5kSHpi?=
 =?utf-8?B?b3RNSDQwaTl5V0lnUWZtQnM0TFNMOU5hL2haTmJyNEh6aXVyVlNCbUVqRTBh?=
 =?utf-8?B?bm44bVVaVEZ4Qk03UnRBK3hKRi9ZTzdVRDNFUi9SelNXSHZQRkx1NFdDR0xw?=
 =?utf-8?B?NUowQXl4aGVRTEd4NDJpcVVDbno1a09mQmhGS01iUE5vWTNWS2lzN0xkMzho?=
 =?utf-8?B?Nk5jZTNPSlhPZWVnMEgvaytOK3c4N0dqZHVLU2ZKTzc2bHN2RW5MYUk4dXBN?=
 =?utf-8?B?bTlId0d6aWswNTdYbnRFajVCc1JqdjR1eVc5ZEdPSGRhMTNjdktqRFhnb2ZB?=
 =?utf-8?B?YUFHa1JrQzBzTDRwWDdPVWRETFVicnBaYkplUUwxb09jSWJ5QlE2NWVPZGx2?=
 =?utf-8?B?QzROd3c4QkU5emVvKy9zK0cwdmh6M3NQMG52VEs2UjA0cDhkNlUzSUk1dG16?=
 =?utf-8?B?ZzlCc0lHcStiNEtZWEY5NnNhUHNhUjdmQmNsemdYL0czdUlrOVBtd0VWM3Vt?=
 =?utf-8?B?TlU5eHZOK0MveU9YWFZhQlMyVmhZSm02RFlXekt6MHhxaW9jcjZEZnRQSHhv?=
 =?utf-8?B?Z0wzaDM1eTQ1N2p0ek50SWhUZC9BekJFUDZ3OUhsSE5rdnV1VDNFcGU5NVlF?=
 =?utf-8?B?ZFJlclI0dUxhZnBhMWcxeHhtVEt1aVZGUTdkSU9BckhEeG1vY0pZNFAwV2ZH?=
 =?utf-8?B?aVRTUVVCUGY5cTUrWWtzaHJzdmRzQVNLdHVMMnMvc2x6UjgvbG9YbExxZXpQ?=
 =?utf-8?B?ZXZJL0NaU3NaQkY1TERldFdOdzBLdWE0M2RxUm40NWd1TWZLRXRZdit1ZTRh?=
 =?utf-8?B?WVVlMXJ4WmZZaFFFM1E3a3VhbUQ1dm9ZU0FZQlhKZmhJcEF0RUZreVNoVjVV?=
 =?utf-8?B?b3R6cC9USHNZaHhNVFIxVWs5WWRianhaMmF2TnNLQVU5Si91ZWJpR0laTlN2?=
 =?utf-8?B?Z0JHUWo1NTlzYWNsc3ZCclFId1BPbzZRd3BEMVloeHhMTWhwWGV0S3grMDJu?=
 =?utf-8?B?VXQzOWtpMHJ1TzQreVdkTk1CTTFGTjFmQ29VNWErSHFvcnJjTHVjalhBaTZZ?=
 =?utf-8?B?byticXV5V3FPM1prMXMvY0pjNmxVbHhkMDZLVU14TnltR2FISGNXcUlPMzU1?=
 =?utf-8?B?TVZZYTVNbTRPU2hHWTg0cm5xWkh3VTNJSTh6R1ZmaHZOeUFkdU1NVG5JdGZU?=
 =?utf-8?B?UjJsYXN3dldBei9PYlZqcEFVVkswa1FudE56L3UwYjl0d0J1UVNVT3IxK2Rm?=
 =?utf-8?B?QnFYa1JMQjUwNGJoUlBUTkc5Z2xuV3lCdSs1ZUhJTTM1Sk5tRENPUTcwdWlV?=
 =?utf-8?B?alo5aXNuWS9hdmk3ai9tMVk2THFBQVBMUGwrZFhvZTA4anJwVHB4T3c5VTRp?=
 =?utf-8?B?REcwK0ZXYlhHSE0wSU9RNUdGUSswYVVlM3NIZ0cvUnR2eHkrWXdEUlhldnFK?=
 =?utf-8?B?UC9zTXI0SDVjY29XdEZZcTQ0aXU0K1FLcnNqaXBuaEtRR2FGeHhIbEp0TTZz?=
 =?utf-8?Q?ERA7w89gUB0qthNDXUBbrGeAB?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41a62dcf-5a95-4f4e-5a60-08db50b1bf4f
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 17:20:55.3750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9mqnVjr6YXf5PYUka1hSDcXAtsnjn0GEXTHqvZT8biPiN92NPlwnVifhSBsSqG98jeQ8pa+7h+S8K8X16tLB6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7327
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/9/23 12:23, Melissa Wen wrote:
> On 05/08, Harry Wentland wrote:
>> On 4/23/23 10:10, Melissa Wen wrote:
>>> We are enabling a large set of color calibration features to enhance KMS
>>> color mgmt but these properties are specific of AMD display HW, and
>>> cannot be provided by other vendors. Therefore, set a config option to
>>> enable AMD driver-private properties used on Steam Deck color mgmt
>>> pipeline.
>>>
>>> Co-developed-by: Joshua Ashton <joshua@froggi.es>
>>> Signed-off-by: Joshua Ashton <joshua@froggi.es>
>>> Signed-off-by: Melissa Wen <mwen@igalia.com>
>>> ---
>>>  drivers/gpu/drm/amd/display/Kconfig | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
>>> index 06b438217c61..c45a8deb1098 100644
>>> --- a/drivers/gpu/drm/amd/display/Kconfig
>>> +++ b/drivers/gpu/drm/amd/display/Kconfig
>>> @@ -53,5 +53,11 @@ config DRM_AMD_SECURE_DISPLAY
>>>              of crc of specific region via debugfs.
>>>              Cooperate with specific DMCU FW.
>>>  
>>> +config STEAM_DECK
>>> +	bool "Enable color calibration features for Steam Deck"
>>> +	depends on DRM_AMD_DC
>>> +	help
>>> +	  Choose this option if you want to use AMDGPU features for broader
>>> +	  color management support on Steam Deck.
>>>  
>>
>> If we can drop this (i.e. don't offer a CONFIG_ option to allow enablement of
>> the uAPI, but build with -DCONFIG_STEAM_DECK) it would go a long way to keep
>> us from requiring to support this forever.
> 
> I see, I'll follow this path. Still on that, I've changed
> CONFIG_STEAM_DECK (too generic) to CONFIG_DRM_AMD_COLOR_STEAMDECK.

I'm not sure I like the steamdeck name in there. There's nothing
inherently in this API that's only for the steamdeck.

Harry

> Does it sound better?
> 
> Thanks,
> 
> Melissa
> 
>>
>> Harry
>>
>>>  endmenu
>>
>>