Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97061716-59a9-44e6-06e8-a2e92c0a35cd@amd.com>
Date:   Tue, 9 May 2023 13:19:58 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [RFC PATCH 03/40] drm/amd/display: introduce Steam Deck color
 features to AMD display driver
Content-Language: en-US
To:     Joshua Ashton <joshua@froggi.es>, Melissa Wen <mwen@igalia.com>
Cc:     amd-gfx@lists.freedesktop.org,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        sunpeng.li@amd.com, Alex Deucher <alexander.deucher@amd.com>,
        dri-devel@lists.freedesktop.org, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        Sebastian Wick <sebastian.wick@redhat.com>,
        Xaver Hugl <xaver.hugl@gmail.com>,
        Shashank Sharma <Shashank.Sharma@amd.com>,
        Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>,
        sungjoon.kim@amd.com, Alex Hung <alex.hung@amd.com>,
        linux-kernel@vger.kernel.org
References: <20230423141051.702990-1-mwen@igalia.com>
 <20230423141051.702990-4-mwen@igalia.com>
 <613b2431-7d05-fb44-25d7-dba59e5eca3c@amd.com>
 <20230509162353.7hak3fda43fim3ho@mail.igalia.com>
 <CAEZNXZARW1uxYz1G2gGt-U2VDCaXBZNNAK-UsXuMeHVufU5YLA@mail.gmail.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <CAEZNXZARW1uxYz1G2gGt-U2VDCaXBZNNAK-UsXuMeHVufU5YLA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MStoQ0dhZUdpRkU2ODNPWWpUV0pERlVpeHhIV0lnVUk3SHVOWUZERk8yNDBm?=
 =?utf-8?B?cm1xWnU4MTk1TStFbmxYVmgyWlZTaGlvMXQyMXhJcDIza2NEejEzZ1ZCdnk2?=
 =?utf-8?B?WUlTQk1Xc1NrSmtPZEV5OFBCTmsvTWhHd2hzVUw4Y2tERGxDcWdwYXFjaDdI?=
 =?utf-8?B?RUlseExEblRlUll6SGNteVJRUWMzNHVqSE81L1BGdmV5QWZ1S09DemFyMlhL?=
 =?utf-8?B?TWlleFluSGxXdEErMHJubm9YOEt4L1lqZS8vSS81U3Q4OExzdE0wR214SExE?=
 =?utf-8?B?ell4SThqQ0d6alVrZEkzbmREOTV6Z01FMnFoUEt4NGtLQnU1a1duNnF5NW1a?=
 =?utf-8?B?TEU5UXJraWhza3VZTUlXRzZkdU50YkNnbXF4N3pZWHAzWVM2aCs3TG02dXdu?=
 =?utf-8?B?TmUzS1NvdzNIKzBsNFArNUlNakxBMUtPY0RKOUJBTmRkcEQzNWZJSzdrcXZ0?=
 =?utf-8?B?K3BydXFSRmJ1Tnh1YlNscGc4LzlSSVlGUC9nL09Rb2Q4WkJMc3gva21VNkF4?=
 =?utf-8?B?S0I2TlNmWXVJRkpvZDVsK01Ud2JOaHJ2NzdRa2RUQjJzN1d4aDJ6MXkxRnVn?=
 =?utf-8?B?MENXaFFYZEQ5V1pzLzl3NDJqRHZqQVEwWUVzeG51WnlSbGZVNDRYVFVIQXdD?=
 =?utf-8?B?dFc1eXFTTzhyQURTZXE0U0VCT0FTY25OeFQ4K0cxQmd1Rlo2cEVjOWg1SkFi?=
 =?utf-8?B?dTFjUHB2SFZpcHdLLzNObzdJSzVuNGw5YnNvUithRDVIenFFN2tLQ1NvdGx0?=
 =?utf-8?B?b2lsa3VlVGhabUN2ZHVTellWbDY0Y3UvTzU5ZDJxUEVmZndUcFdISHJyQ3p1?=
 =?utf-8?B?bWlMenBJeUhBODB6Ujk2aEhpUEZGTVhLcFI1bS9UZmZCMWVRajdTb2EvSGUv?=
 =?utf-8?B?Y2N4ZEcvdmdWN09YZldVcmNPcmFlMlErUENyZTNCZFVkMlI1dHBkQjVhV2dX?=
 =?utf-8?B?RGRzN3NNV3N2VWxuQ3YrWWxMRlBDUzJaT2JkdkdxN25wdy9VWE93UHl6MFRX?=
 =?utf-8?B?YWdWL3JmWlRXV0tUZkdCTlJaQXo2cjkzeUxyYnBmYXNoT2QyRUlJTEVoZW90?=
 =?utf-8?B?enZJMGIwZlIyQkZrbjZOOGpsQUVqaGRmQTB2R3VBSDFXbWJneEkvZFJDRFpY?=
 =?utf-8?B?SWNNd09adkdxbVNNeEpveWhjWDM0R1VoR1NLV2NCdVpXTnN2UUVUMzQ4UFZM?=
 =?utf-8?B?aHQyK3czMk9wWlg0RGx3UlN4K09YaWJBZnpBWmFQMkhYZkZLVVFaVmdPZ0wz?=
 =?utf-8?B?eER2TGNSSUxKZFNTTmorcnl4a0xYT0NUQkxqQzNGR3dvWnkvZmFoejk4VUx1?=
 =?utf-8?B?WnJKYzNjWXExVXkvNVYvazhoYVJxbkFuNjY2MnloYmd1UGNmTlBxV25nVklB?=
 =?utf-8?B?dG5DVk9qV1ZRUkIvcXdaM01laFdydXplV2JjVFJBVzViZ0dmQlNXckkwczcx?=
 =?utf-8?B?R3FPWnMwMWpOWWw0RUNSdkZWVmZpekM2REZYcWtTUkdRZWtPb2EwUkoyYzcw?=
 =?utf-8?B?VEllQUVZSXA4a1JBT3Z5RHk5UUxzbDdPTExQRysvaElTejU3UkFXajBmOWpo?=
 =?utf-8?B?d0FWQytQUnBuM2lmR2M4QTkxUG5KRElKSW5rWnRmTU9BMlNYVWVHYmdRUjhJ?=
 =?utf-8?B?aklJN0w4ZlVYcUFnS3psUVFMQmgwSTQxUkhQS1hXUXR5bXB0TEsvVjczN3Ns?=
 =?utf-8?B?aDVzbENWSVdpa1NJbGc4WjY0RmQrelBUT0xwVTQ2U3NvZEhxNkZSZUNiMzda?=
 =?utf-8?B?M2ZYYy8xdGRoU3puaGpzcVZsaXNlNUp2VitTcStvK0V4T0o5RC9Xaldod2Fj?=
 =?utf-8?B?OGdQYmxjbzlmYnNaZ0lKQ0QwSER3N3VUYlpEcVFnV2tjYmNFalRCcmNQVytu?=
 =?utf-8?B?ejlnZG5HcXN2UmNtcHE5M0FrWStUSXZSRjRRL1NtVWoyREFDU3RsdmVhR0s2?=
 =?utf-8?B?cCtOTStONWxtck1xMjZCZjBONjFXNEJuQ25yUVVjckhkTGZUbTYvRFBpMHF0?=
 =?utf-8?B?N0U5VEtKeThqTzJ6MzNrZkQ1ejBnR21KaUYwaU5XT2xPWXBpUnU1ZnFDWlJO?=
 =?utf-8?B?OWhPMTJETm1zQitaNWJmYlNjWURBZGVTemJsNkxSd3hsZWlvRHh4Q3RCMXVL?=
 =?utf-8?Q?0CfzDa5F4a4OE8x8wAMuHo58+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ff2a0d0-4f6b-4868-2f73-08db50b1a052
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 17:20:03.4586
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4csTK1wcR03wA0xNkuSGX+kDxJsSSnSh46P81pczZIdXgnhXYZkh4yqYOb4V3oq3fgjjHK4ZhPD+HqlZDwrETQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6308
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/9/23 12:52, Joshua Ashton wrote:
> I think the idea is that we wouldn't have a config option so it
> doesn't inherently become linux kernel uAPI?
> 
> Then we can just build our SteamOS kernels with that definiton set.
> 

That's the idea. Would that work for you?

Harry

> On Tue, 9 May 2023 at 16:26, Melissa Wen <mwen@igalia.com> wrote:
>>
>> On 05/08, Harry Wentland wrote:
>>> On 4/23/23 10:10, Melissa Wen wrote:
>>>> We are enabling a large set of color calibration features to enhance KMS
>>>> color mgmt but these properties are specific of AMD display HW, and
>>>> cannot be provided by other vendors. Therefore, set a config option to
>>>> enable AMD driver-private properties used on Steam Deck color mgmt
>>>> pipeline.
>>>>
>>>> Co-developed-by: Joshua Ashton <joshua@froggi.es>
>>>> Signed-off-by: Joshua Ashton <joshua@froggi.es>
>>>> Signed-off-by: Melissa Wen <mwen@igalia.com>
>>>> ---
>>>>  drivers/gpu/drm/amd/display/Kconfig | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
>>>> index 06b438217c61..c45a8deb1098 100644
>>>> --- a/drivers/gpu/drm/amd/display/Kconfig
>>>> +++ b/drivers/gpu/drm/amd/display/Kconfig
>>>> @@ -53,5 +53,11 @@ config DRM_AMD_SECURE_DISPLAY
>>>>              of crc of specific region via debugfs.
>>>>              Cooperate with specific DMCU FW.
>>>>
>>>> +config STEAM_DECK
>>>> +   bool "Enable color calibration features for Steam Deck"
>>>> +   depends on DRM_AMD_DC
>>>> +   help
>>>> +     Choose this option if you want to use AMDGPU features for broader
>>>> +     color management support on Steam Deck.
>>>>
>>>
>>> If we can drop this (i.e. don't offer a CONFIG_ option to allow enablement of
>>> the uAPI, but build with -DCONFIG_STEAM_DECK) it would go a long way to keep
>>> us from requiring to support this forever.
>>
>> I see, I'll follow this path. Still on that, I've changed
>> CONFIG_STEAM_DECK (too generic) to CONFIG_DRM_AMD_COLOR_STEAMDECK.
>> Does it sound better?
>>
>> Thanks,
>>
>> Melissa
>>
>>>
>>> Harry
>>>
>>>>  endmenu
>>>
>>>