Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230509131847.835974-1-tmricht@linux.ibm.com>
In-Reply-To: <20230509131847.835974-1-tmricht@linux.ibm.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 9 May 2023 10:34:44 -0700
Message-ID: <CAP-5=fVC1bAMk5gOGSXi0sHdetdLHGT2tqW43dxTTyJ3jRz8QA@mail.gmail.com>
Subject: Re: [PATCH] perf/test: reduce run time of perf test Test java symbol
To:     Thomas Richter <tmricht@linux.ibm.com>, jolsa@kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        acme@kernel.org, leo.yan@linaro.org, svens@linux.ibm.com,
        gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 9, 2023 at 6:19=E2=80=AFAM Thomas Richter <tmricht@linux.ibm.co=
m> wrote:
>
> Test case Test java symbol might run a long time. On Fedora 38 the
> run time is very, very long:
>
>  Output before:
>  # time ./perf test 108
>  108: Test java symbol                  : Ok
>  real   22m15.775s
>  user   3m42.584s
>  sys    4m30.685s
>  #
>
> The reason is a lookup for the server for debug symbols as shown in
>  # cat /etc/debuginfod/elfutils.urls
>  https://debuginfod.fedoraproject.org/
>  #
> This lookup is done for every symbol/sample, so about 3500 lookups
> will take place.
> To omit this lookup, which is not needed, unset environment variable
> DEBUGINFOD_URLS=3D''.
>
>  Output after:
>  # time ./perf test 108
>  108: Test java symbol                  : Ok
>
>  real   0m6.242s
>  user   0m4.982s
>  sys    0m3.243s
>  #
>
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> Cc: leo.yan@linaro.org
> Cc: irogers@google.com
> ---
>  tools/perf/tests/shell/test_java_symbol.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/test_java_symbol.sh b/tools/perf/test=
s/shell/test_java_symbol.sh
> index 90cea8811926..499539d1c479 100755
> --- a/tools/perf/tests/shell/test_java_symbol.sh
> +++ b/tools/perf/tests/shell/test_java_symbol.sh
> @@ -56,7 +56,7 @@ if [ $? -ne 0 ]; then
>         exit 1
>  fi
>
> -if ! perf inject -i $PERF_DATA -o $PERF_INJ_DATA -j; then
> +if ! DEBUGINFOD_URLS=3D'' perf inject -i $PERF_DATA -o $PERF_INJ_DATA -j=
; then

Jiri, is this the best way to workaround a debuginfod slowness?

Thanks,
Ian

>         echo "Fail to inject samples"
>         exit 1
>  fi
> --
> 2.40.0
>