Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Piyush Malgujar <pmalgujar@marvell.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "xueshuai@linux.alibaba.com" <xueshuai@linux.alibaba.com>,
        "benjamin.cheatham@amd.com" <benjamin.cheatham@amd.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "jannadurai@marvell.com" <jannadurai@marvell.com>,
        "cchavva@marvell.com" <cchavva@marvell.com>
Subject: RE: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Topic: [PATCH v2] ACPI: APEI: EINJ: EINJV2 support added
Thread-Index: AQHZfoz/HoY7ASH3bUeV4msZv1/xf69KTa1QgABJGICAB3OngIAALJJA
Date:   Tue, 9 May 2023 18:35:44 +0000
Message-ID: <SJ1PR11MB60831FCB30F2A642B95C9D9FFC769@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230504133224.2669-1-pmalgujar@marvell.com>
 <SJ1PR11MB6083A266C4A869FC9AAA5A9AFC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <SJ1PR11MB608326A6AC3FFE42699DDB40FC6D9@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20230509143721.GA10616@Dell2s-9>
In-Reply-To: <20230509143721.GA10616@Dell2s-9>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J4JvQBekau29he7MLDxjaMqhT5ic8KxrOAadKm1S03F3sapGo7aYtL+UbEJm?=
 =?us-ascii?Q?dfBolg1SsHAzrQPD5d5BfMNYKqX2XCe+gGbMonBbkSQATTB26FrxYg/4oOn2?=
 =?us-ascii?Q?jwFu2b3xZOdjwXGWEeI3W74ac07icSn84BC5/88Pa55Pb/enaW0kCqlk8DDs?=
 =?us-ascii?Q?Y8RSYQvK31hu4lqsj70O3mJBh1RYDGLSTdO7Wir5mf0IEK6sAwlX6I6buPYm?=
 =?us-ascii?Q?iRX1w9Yz95IKE7jMxhnh8+sF0VKjcg8DaS4+IflCI+MceN/bD0/BvEJasbHA?=
 =?us-ascii?Q?Vo6hC3cka+b0FTNpaCQ2P4IMy1ZnCmAIkd24wFM6NWGS+fnL6lglErjVXvkX?=
 =?us-ascii?Q?nCaPBIL8ElGzIEGsru8qs3lIPoaFgfRnh88qGYaa+dTTOUFLYpy4Zd8uZlsM?=
 =?us-ascii?Q?o1aXzuGiwTNHFVYMruVB0kzu0RH6ZeVmUYvQk0g97TtUyDgokNtKUDD+RFVY?=
 =?us-ascii?Q?6aQnm0wko3/L6qaOzZA3Yy5Qq3P/WWRRg6UuPr9mWzfvBTjwqszaCP0M+WdX?=
 =?us-ascii?Q?vM2Hg54FQLnYLH4cA+GueBZXAcYcaWjtX9EtY16UsdAMD2tDUH1ldFh/spOz?=
 =?us-ascii?Q?PglKUmbRhEBG5V0EEgncXev1HWmvZIcYOz7MWfZ+1Hmr3sb6xZhIkaCdlwWc?=
 =?us-ascii?Q?kuATIEVZSaeiciP/TtgJl0hMVH7ymvhn669hL4YnThKl/O42z4VcZVn+WLkU?=
 =?us-ascii?Q?z9ZzjyUMvIPRFYCsec98Hcdk9zC6Z3XWwG1fSjr+ziHs1JhIO85aaik0QHEu?=
 =?us-ascii?Q?UEI0vkgBMbTObECSZrQ7KZPEWAhOsELl5g/yb2XXoPzf9nS/8bvNR45b1bvt?=
 =?us-ascii?Q?qjl688tSpciSbWa0+XU0y71oImDH4UrfiNN6ThZVkH4ALUDqUdk00H+ZaKxh?=
 =?us-ascii?Q?5td8o3CP8a9oPTkFOLWW3Ssg9LaAgJC7MPIUs0XYzORekX08lP0yP2K6D0Qq?=
 =?us-ascii?Q?dm3teglFSH6tLujYYPRbaolvI+TLzVBwM8XpzCUYOUqshD32mmTu54ibNG12?=
 =?us-ascii?Q?/AhyCT0cmoWtZpajLxge3/aXA4ueJDDQm5B3MGqV9hh5YzSWGPeP2SS9ysQJ?=
 =?us-ascii?Q?F2SdFOGaKHyOBlVTwPy9qlkBJG15iR9cDmqWuxF2WrtyGNsCpCiKNRZTVQGl?=
 =?us-ascii?Q?osildlRWF8ZCpljlPutAGO6UT+RWezw8aiSR5R9JpVxQ/u7103lpnDvIuAnI?=
 =?us-ascii?Q?M9hXcWnP4PG4GbFqxGA6mvRijyujxthMGGYoDAgSnjdKiacP9ughP6A0fXkL?=
 =?us-ascii?Q?C1QrP44dg8bm1PMHImuEXjiHNKZywIkYrnipK1s3VlOoxcowkioQp2T2liU2?=
 =?us-ascii?Q?MCgfl9Ratb9gGPH7UiHDWugHiyby+X12LXLz9AT3ZZFINp35UOcF5QKlhakJ?=
 =?us-ascii?Q?7ZAjsKg9mmb2dPPH+0WVjVArnlIUfPcNnpVh+oOaXHBoJhQ5/B0NHK4KaNhP?=
 =?us-ascii?Q?m/uWq4nJUSQCiwHI2o2WbJMLFvBpUbIefGxKnVXWQTzuVIzhtvaIMpbawKS8?=
 =?us-ascii?Q?g0ZpfG4XrZCvBSgOo331iqezLcSQOBATkc3n1odPAvOXmS/2Xw4hR8couvqH?=
 =?us-ascii?Q?btXBhbfJaTovU8M+rl0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f7b0edf-aab5-4c23-e50e-08db50bc332b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2023 18:35:44.5036
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AelWWMpVA/MrspC2vYJ9bX/3JM8TacaqrynEMr0ulsxDs6WwCzXJaRkJ0XQwycuVDBbAIl394/ZNxO68IpY7kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4820
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> If a platform supports einj v2, then the einj directory wont be needed, a=
s per spec,
> if a non-zero Error Type value is set by EINJV2_SET_ERROR_TYPE, then any =
Error Type
> value set by (einj case) SET_ERROR_TYPE_WITH_ADDRESS and/or SET_ERROR_TYP=
E will be
> ignored. So based on einjv2 is supported or not, we can have either einjv=
2 or einj=20
> directory with the related params files in it respectively.=20
> Kindly let us know your thoughts.

Piyush,

There are a lot of validation tests built on top of the EINJ v1 Linux inter=
face and interest
in keeping them working rather than forcing a giant "change everything" whe=
n the first
EINJ V2 system arrives.

BIOS team here thinks that the EINJ V2 spec change is (or can be) increment=
al.
Platform firmware can choose to continue supporting EINJ V1 while also prov=
iding
EINJ V2 actions.

So Linux should be prepared to handle:

1) Legacy systems with just the V1 interface.

2) Incremental systems that have both V1 and V2 interfaces.

3) Future looking systems that only have the V2 interface.

-Tony