Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <860b9da6-5b0e-2bd1-1848-0ddde0257b25@amd.com>
Date:   Tue, 9 May 2023 13:54:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags
Content-Language: en-US
To:     Reinette Chatre <reinette.chatre@intel.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>
Cc:     "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "eranian@google.com" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <168177435378.1758847.8317743523931859131.stgit@bmoger-ubuntu>
 <168177445556.1758847.5029687867896978170.stgit@bmoger-ubuntu>
 <4275aa91-5834-2c03-f455-f1d3d666fec7@intel.com>
 <MW3PR12MB4553E65A5D5DE6E27045766595729@MW3PR12MB4553.namprd12.prod.outlook.com>
 <efd45c71-2241-e0b8-e1c0-6fcc1e95b321@intel.com>
 <MW3PR12MB4553C5EF3818F6C54B8BF5B695729@MW3PR12MB4553.namprd12.prod.outlook.com>
 <8acebeed-8c0e-98ac-b7a3-5dd1680fafa3@intel.com>
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <8acebeed-8c0e-98ac-b7a3-5dd1680fafa3@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dko5clFtQ2xLV3JZVmlUdS9iOHh4di9BT2JaQWR0eXQxMXMwRzFNVi9peVEx?=
 =?utf-8?B?c1I2dVhrbllpV0I5TmhDL01yT2l4SkpCTEFmS2FEV3F5Wllsd1UzVTkwclJ4?=
 =?utf-8?B?LzFHUjFXZDR1djM0VnlGOHoxeW1RSWhSclBJd3ptcEpURVhVejFqVlR6TzhS?=
 =?utf-8?B?RjFNL2VZWko3ckdJaE1NYjFSN1ZXcDZNRkJZbldKUTVMMlJhVUVvK3UyU0pt?=
 =?utf-8?B?aHFTVENVdzlxM3krZGVyYjNyM0piQnlrS0hrSlRpNTlqdXB4R1Y0aUs0bytB?=
 =?utf-8?B?b1d6QUdQYUZXM2JWeEpPaVhsLy9Id25TQmJOVUpUajhxUVAycVR3cllsL2Nz?=
 =?utf-8?B?Z2lmN2JIdnpmT1Rqakg3ZEpHTU12MFJRQzBaSFFESHBxc3ZlVWlMWkRVUlNq?=
 =?utf-8?B?a24rYTd1Y2dJUXE5amYray9ZcUhzSXlOYW1yOS9RY3BRS2xNcGViOGJmbVhK?=
 =?utf-8?B?MndtejJ2YmcxbUxmYXhCbVhFcE5RNFZGRnRxRGEwT1BYLy9lZWNXVURsYlBB?=
 =?utf-8?B?ek11VGZMTjFEQmZISmtOZ2R5ampZd3hjNVBObUMybTRGdDNCTDRnaDVGRXJm?=
 =?utf-8?B?Tnh3N3FLenN5SXJXZGJ2MjRvanBXdis3L3R2NDFycFJiSFRGZnlWaXpiWm4v?=
 =?utf-8?B?dWkxZk9tMzNhNTVKZ2FOM2hQdGZMTU5iT0JhUnMwdTc5SCtRSGxtbWxTZXBI?=
 =?utf-8?B?bWRMVDNhN3pNeWRWcFUxZzkzTnhFNmxFekpRY3FpaG9EZEZpWWloWW5RczM3?=
 =?utf-8?B?MHFHU2hIaEoxTFhPcDRNWW1nTmdJcGlsM2tpdzR5VFFwUXpnRWoyRmZXcllz?=
 =?utf-8?B?QnliQ3J2Y3N5UnFQUkJzYUlXbnp2QnJ0UExXcDFJL0tRT2xETHlocmJGMitT?=
 =?utf-8?B?aHp3cVRiU0xVeXg0aDY0a01MK3RNMXNtU2lMOXZ0SEdMdm5FOE9WQ2U0MmQ1?=
 =?utf-8?B?T3FBeG03VnBJNFFVcFBKa2VZS3JrYXBFWkJQRittbG44YUNnMTB5NkgxSE13?=
 =?utf-8?B?THplOFZCN3luSlBnSzZDUWYrZkp1YlZWL3V1L2FKOXlmME1sVTRqUVhvaFRE?=
 =?utf-8?B?VGRqWHN2dzdaUU5pamcweHpLZnZwUFoyTlZMQWt4Qlk1Q2ZtV3huVFgrYUFn?=
 =?utf-8?B?cVJvcUNtdUgxTmRwYTdlZXlDakJROUFLQ241NWFxM2JPVzEwYVRjcHFmM3cx?=
 =?utf-8?B?dUhRU0VFNHRLdFFGZ2VsQ1JtWUdPd2wzZmd1NHlHS2xTQS9XcERFQW0yZmdj?=
 =?utf-8?B?SHdVdENVODhyK3Foa2x4NU1WMFQxK05aZHJuWDZqM1ZrenAvKzlXUTBKczJB?=
 =?utf-8?B?R0YySXdHMldPVU1qTVNkWk4vcld3UmlQTCtSckl1TG1oQU1GbUlOK1hod2N0?=
 =?utf-8?B?Y2NjWXdrOGRvRzlQL1hKY0RzM08va0pTM1M2OWczQ0Fvc0Q1WFB5bEpkc1B5?=
 =?utf-8?B?amJmb1NrQ0t0ME9PbHNxTlUwWjZ4Vk9OUmZGVHVHOHdlVDVvcDZuSSt2UWQ5?=
 =?utf-8?B?djh5ekMrcXZBVElHb2s3UWcza0lrR2ZnMHp1LzRUU0c0K21YSTEvdGFNdCtz?=
 =?utf-8?B?YmlVSzB5NmlKd1o2WlZIZmwrYTV4QWQ1cldicVpqSGU1YWEzenhBYU5iNGcv?=
 =?utf-8?B?TEpNR0NCWWN3a05qVkh4Z1FKT3RsSnlvRlptWFhWSEFFN3A1cWk3OE1VWS9T?=
 =?utf-8?B?YnI3N0gzSGJ6c2lRQklOaDZnT3JWNUNzNUJUeUlreXZkY0dIY2lYOUlDZ2tt?=
 =?utf-8?B?WmhwVzBENW9abFpjSlhtZmNoaldmNjVqTkdUaEd2L0NpYzgvejdIazdlNXd3?=
 =?utf-8?B?L3pVSGtxQUdSQUFYSU11ZzhTYjNKVUtUUGFqTnVoT01qU2NPbUxIckI0eEM4?=
 =?utf-8?B?TndHcEIzRXFRTDl1ZmpKcjdadWZKdnc4YmVDKzRvcVVwV3d5VXFiejVya0tN?=
 =?utf-8?B?Yy9qZEcvQmRnV3o4YzYzUFI0b3NGOXY2cC81UDVCMm9ISnNLWnZZTjRrOGtD?=
 =?utf-8?B?VStMdWtYVDdCblJpQzA0NFZML3NRTDNITmlYRkJYVzNPcko2ZVBQRytOMklX?=
 =?utf-8?B?OUIvZkpWRnR6YUUrZnphRG5tWkVDeW54RlVyTXdnSW03UFByZXVTRm9LaGFz?=
 =?utf-8?Q?xac4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6392fa70-cd47-4215-65bf-08db50bed7f9
X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB4557.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 18:54:40.2604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xJ2m3tZUliAGQgNzNswblzt6FjX+2cWT3+clkuX/AgvgqYLQye93jA8ITIz+E8V4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5967
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Reinette,

On 5/5/23 16:28, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/5/2023 12:04 PM, Moger, Babu wrote:
>> [AMD Official Use Only - General]
>>
>> Hi Reinette,
>>
>>> -----Original Message-----
>>> From: Reinette Chatre <reinette.chatre@intel.com>
>>> Sent: Friday, May 5, 2023 1:54 PM
>>> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
>>> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
>>> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
>>> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
>>> quic_neeraju@quicinc.com; rdunlap@infradead.org;
>>> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
>>> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
>>> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
>>> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
>>> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
>>> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
>>> bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu;
>>> jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com;
>>> peternewman@google.com
>>> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags
> 
> (is it possible to trim the headers in your replies?)
> 
You mean Company Header..  Sure.. Will do.

> ...
> 
>>>>> On 4/17/2023 4:34 PM, Babu Moger wrote:
>>>>>> Remove unnecessary rftype flags to avoid multiple indirection.
>>>>>
>>>>> Could you please elaborate what makes these flags unnecessary?
>>>>
>>>> Yea. Probably should not say unnecessary.
>>>> How about this ?
>>>> "rftype flags have two prefixes, RFTYPE_ and RF_. Remove the flag names
>>> with suffix RF_ and avoid indirection."
>>>
>>> I do not think that having a different prefix is a motivation for a flag to be
>>> removed. Having a different prefix could rather be a motivation for a flag to be
>>> renamed to a consistent name.
>>>
>>> Could you please describe the problem being solved?
>>
>> Motivation for these changes.
>> 1. Remove the naming inconsistency
>> 2. Remove the indirection
>> 3. Make it easier for adding new flags
>>
> 
> Could you please create a coherent changelog that follows the guidance
> of the maintainer doc? Some details about why the indirection needs to be
> removed and how this makes it easier to add new flags?

Sure. Will try to address it next revision.
-- 
Thanks
Babu Moger