Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6278982rwr; Tue, 9 May 2023 12:53:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6kFTKjBUKKED7dlH+WTDQZLBVotV+epog/fWoHhcX1RIJkn1PTPLOc801Yyn7Stmrl87GG X-Received: by 2002:a17:90a:4a0a:b0:250:6730:a364 with SMTP id e10-20020a17090a4a0a00b002506730a364mr10114402pjh.3.1683661989390; Tue, 09 May 2023 12:53:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683661989; cv=none; d=google.com; s=arc-20160816; b=eGR1FQ78gu0dPD/DrpUJBZcvD4jzRd+pNx54wqqREaofliiev5vTJXqXlwnap9YwfD 9NXOidlxhPneb31plArYZqIBrTeyzgg3me62+qXw0k1j4yBzCewqwQGMDbYqbrVfQxS5 2l5rX1nemGopCr2EePeM7Uu4S8a22oKPxBXwDZncEJS3H2Ku/BWKGR/4YpXBw+vRexBv f5LGPDEbXdCVVEwRHdV/1IuYQjpzz9nbXlGy1pfusgGwVEiCR1LpIoocjdT9o8gHrT0U VV9W1htby2bSwmhQKr+BZfva5oS6mWtJ9DKOLwy29tPrslPkltTP5HxX4JLd3VMUb9eP qy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AdywwhjxGaN6Y3/mPqh/c2MgjoXsXtnSQ+Kliw53l+c=; b=h4L8D/qnEpZpCwIgeJeP5tb09mwzKn+4qvnVHtepCAZgxjZC6QoEWyi4DUEkq53yao 1/dJm7pvRZtUZxi1khLqwKcY1dMflZu1hTjBi/zrZx9gcsgv/ICF6K/TPPRXgIKXRSbZ 5SVouZQtdltqUm1WlPqaxORqE/I4PiS3p29HPLjehUaGQ+xjsJ0+ihxEFMtS53YzGslV mFmX8O1Q1WDD4MUDb1azRTnukKfxfQ/tSMcZhdzCuVZpWV8vh8jw5fvTd2VrILr1fC9p z5t54TUkG7NxD5nrxG6tokfnjpTxcCEkoG9WhK96SDWXt0TjGKTtEfNlCkL7Rs5rTJgQ 6lcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=c2W8uSum; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e15-20020a17090a118f00b00250b49a7f17si1828545pja.163.2023.05.09.12.52.56; Tue, 09 May 2023 12:53:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=c2W8uSum; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229595AbjEITb7 (ORCPT + 99 others); Tue, 9 May 2023 15:31:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233625AbjEITb6 (ORCPT ); Tue, 9 May 2023 15:31:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63BC6E71; Tue, 9 May 2023 12:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AdywwhjxGaN6Y3/mPqh/c2MgjoXsXtnSQ+Kliw53l+c=; b=c2W8uSumZRfddTrbKo2ykCgH54 +188v8gGxJC+y2pNBcq5OTBhzwJbjENdEsXKTGm/pqr5iWlNxUEm/Cx/rHIeM39FkpQuCIMESBwB8 dUB3A23nwrwZpkZVIfVj54PWZbxgTteGErtwYkVVree8SgEyRtq1E0CZY6Wojoftyeh9g2d8ZcRuL 7VqPvD+ErYEBEHftquqIlQvfAEhM848aIO8fNomchCorgWHd4AC8Nvel5XYkAI4qDuI+dTng/fg0A sXM8OeB54k+DZX3hMs4uNmwnaXAnYxG31UZsyts8TFPwydNpH2NaQ5lK+m6OQ4727cUkGXcEIbrGg WgcN5lew==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pwT3r-00FY08-U2; Tue, 09 May 2023 19:31:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 87142300786; Tue, 9 May 2023 21:31:47 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7866221F9F5C4; Tue, 9 May 2023 21:31:47 +0200 (CEST) Date: Tue, 9 May 2023 21:31:47 +0200 From: Peter Zijlstra To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng Subject: Re: [PATCH 03/32] locking/lockdep: lockdep_set_no_check_recursion() Message-ID: <20230509193147.GC2148518@hirez.programming.kicks-ass.net> References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-4-kent.overstreet@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230509165657.1735798-4-kent.overstreet@linux.dev> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 09, 2023 at 12:56:28PM -0400, Kent Overstreet wrote: > This adds a method to tell lockdep not to check lock ordering within a > lock class - but to still check lock ordering w.r.t. other lock types. > > This is for bcachefs, where for btree node locks we have our own > deadlock avoidance strategy w.r.t. other btree node locks (cycle > detection), but we still want lockdep to check lock ordering w.r.t. > other lock types. > ISTR you had a much nicer version of this where you gave a custom order function -- what happend to that?