Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6443708rwr; Tue, 9 May 2023 15:37:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7JcU+lYF8zgPjjTpYSSEEQAxe96CKDoT5GhelcaeirhBg/V2ja8gCJCqYT2y+mtHRCFYtd X-Received: by 2002:a17:90b:4b4a:b0:24e:3316:bb99 with SMTP id mi10-20020a17090b4b4a00b0024e3316bb99mr15216981pjb.5.1683671842318; Tue, 09 May 2023 15:37:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683671842; cv=none; d=google.com; s=arc-20160816; b=ObYXKzJnsrNJL8LhUE8u5sx1OrIcmdJTWpGRpOdRVzgGtn6PnkFOtEtfjgtRDr9FKd 2JQzTBurzjumISvsLs8qDKgSkHIPhVwKQp71PSs+pD3rnNofO7iE6Q4gT4nJyEPOpgSl PAHzWUtOs3SYmOKHmqkDeAbmYgantYH4RnujClVM99qcq3+bGzuLj0KhcRwGtT3lyQzx IqQbSSmSAeeYN0IjbaGV+iSCi1aNbmtxIe/p/Zf5/D3TGHPF3lUdKR6vTLxOsYf/h/6E X0A6HzE4WoC4QiQs7080xuefWa4PMMtYMVuqcAoUL4qG+Y9bKNdSuYBI5wzNXTP+6MFS N1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nm/iB1zX0wTmh39nnUNXbCnFgHABdZ3zLA40vJ95ofk=; b=I9K0RRZwPklP2/82GiykZB7ml5epbQKaTuk/Tsd7GbWhWUh8EOB24+KUpsbzPAwTws fjwFOyNgRUSO+ISY4ScUSpMXk+vjNwZ+WRQzTEhksKk/Xl2VTEtpSHDNikBu6h0gHkBW KcNlrn2cEUCoTTJ+Xin+0I5Fasel8nbfWD/J65CZfWwzB2PV+AAW32EHX5FfpeTr2rxU brEKGNZQxSA4b2qg6zrNCDlSbCvfJWvH2z5X5ETc9Jo4BOQjE8K+am8fNVRxNDsjk8pP n1K6WUhPLEFVuJUsJ7zPdFYYmSKfN9Q3nJISjoXroTfa1iQ8zSUDFR0kkKxjUyVRfNJz Aw9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=hyYJdXFW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q17-20020a638c51000000b0052d7238ad5asi2453815pgn.721.2023.05.09.15.37.07; Tue, 09 May 2023 15:37:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=hyYJdXFW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbjEIWex (ORCPT + 99 others); Tue, 9 May 2023 18:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233120AbjEIWek (ORCPT ); Tue, 9 May 2023 18:34:40 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F9B49CD; Tue, 9 May 2023 15:34:33 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-64388cf3263so4642426b3a.3; Tue, 09 May 2023 15:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683671672; x=1686263672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nm/iB1zX0wTmh39nnUNXbCnFgHABdZ3zLA40vJ95ofk=; b=hyYJdXFW4QC3b9HxVlK89KHgNVcYjlbqzLZtwZpwWs2ktV0Rk9oq7wGAwBxCEMbnHz TPqEG6gc7hzUF59xTJo6X6yVHaPWM0y1BIvUOKGqd1RBwlMSBz+KZew0pAodu0D1myfg HiAS3ERNZtfgnKDrmATnVnYgVihDlIgkSzcNxw4EJf+mSPAU/ekbaGY+ZwzGGD0VsBuz b8uiVL3I16RC3A0409Sb19B6RDXZ0zEX3/91wnrbINgtkE+oCqcyKelnaLfXe3XrnqZr x5Asf9j2VKtHNawj5SnCfoMe3AklD7kHfaiS4pgEjG6i0lhp6TpUFVFYkqUqC5/e0LuG f3bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683671672; x=1686263672; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nm/iB1zX0wTmh39nnUNXbCnFgHABdZ3zLA40vJ95ofk=; b=bnTlYebS+uMFBXC7g0+NL2yMgEp9EH4PQ0+UD7ItPxyiY41u6Je3HjpSH+ctNVb7oG RWIfXH7LP/hHlNC5VEK3RgT3QSicwa0ZZoKif05EtwMw/NXF74IVC802HG/Vcj7FPaOk oYO0ZO4BCrzMNg/9x3+bmpomkA20BWNig6M779v753sVAbs6BpTGGqZIh7nxLd5+WhML wULpfWJ50niVgsUWKsqzLDDzfX6LLByUMsLSX7o0HtAGZLkWOIcHCFAk5z7EzPe2K4vu b6OYuo906qqhPtziD9/MsCCfnT7ijGeKkDPr+JGyrl8rUJRzBd9U10D0tRjdNkoIMavD eorg== X-Gm-Message-State: AC+VfDxd202MbLCWF71c+5MJkMy+q3HJsG9zim6u9R2K+4eZO4DIeG2s 0XIxqN587B/fa3wpiehXUkr7NEJROIU= X-Received: by 2002:a05:6a00:2da8:b0:647:776c:d19c with SMTP id fb40-20020a056a002da800b00647776cd19cmr3112845pfb.13.1683671671813; Tue, 09 May 2023 15:34:31 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id p5-20020aa78605000000b006438898ce82sm2317274pfn.140.2023.05.09.15.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 15:34:31 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: Florian Fainelli , Doug Berger , Broadcom internal kernel review list , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King , =?UTF-8?q?Marek=20Beh=C3=BAn?= , Peter Geis , Frank , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next v2 0/3] Support for Wake-on-LAN for Broadcom Date: Tue, 9 May 2023 15:34:00 -0700 Message-Id: <20230509223403.1852603-1-f.fainelli@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch series adds support for Wake-on-LAN to the Broadcom PHY driver. Specifically the BCM54210E/B50212E are capable of supporting Wake-on-LAN using an external pin typically wired up to a system's GPIO. These PHY operate a programmable Ethernet MAC destination address comparator which will fire up an interrupt whenever a match is received. Because of that, it was necessary to introduce patch #1 which allows the PHY driver's ->suspend() routine to be called unconditionally. This is necessary in our case because we need a hook point into the device suspend/resume flow to enable the wake-up interrupt as late as possible. Patch #2 adds support for the Broadcom PHY library and driver for Wake-on-LAN proper with the WAKE_UCAST, WAKE_MCAST, WAKE_BCAST, WAKE_MAGIC and WAKE_MAGICSECURE. Note that WAKE_FILTER is supportable, however this will require further discussions and be submitted as a RFC series later on. Patch #3 updates the GENET driver to defer to the PHY for Wake-on-LAN if the PHY supports it, thus allowing the MAC to be powered down to conserve power. Changes in v2: - introduce PHY_ALWAYS_CALL_SUSPEND and only have the Broadcom PHY driver set this flag to minimize changes to the suspend flow to only drivers that need it - corrected possibly uninitialized variable in bcm54xx_set_wakeup_irq (Simon) Florian Fainelli (3): net: phy: Allow drivers to always call into ->suspend() net: phy: broadcom: Add support for Wake-on-LAN net: bcmgenet: Add support for PHY-based Wake-on-LAN .../ethernet/broadcom/genet/bcmgenet_wol.c | 14 ++ drivers/net/phy/bcm-phy-lib.c | 212 ++++++++++++++++++ drivers/net/phy/bcm-phy-lib.h | 5 + drivers/net/phy/broadcom.c | 126 ++++++++++- drivers/net/phy/phy_device.c | 5 +- include/linux/brcmphy.h | 55 +++++ include/linux/phy.h | 4 + 7 files changed, 416 insertions(+), 5 deletions(-) -- 2.34.1