Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2345b39d-366d-cd37-1026-2663679b4bed@intel.com>
Date:   Tue, 9 May 2023 16:49:46 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.10.1
Subject: Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()
Content-Language: en-US
To:     Yunsheng Lin <linyunsheng@huawei.com>, <davem@davemloft.net>,
        <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Simon Horman <simon.horman@corigine.com>
References: <20230509114634.21079-1-linyunsheng@huawei.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230509114634.21079-1-linyunsheng@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlhNRnlhdmdqYVlHVXR5OHFkcjIwYnBQSHJpRHNid1VZL1kxbVExelQ1Szhu?=
 =?utf-8?B?UUtSU1U3NjE4dXNVbElGZlFNUFZCNDhFVm5Pa1hPSytLQi9IdHpiQlA2L2Fj?=
 =?utf-8?B?TGFYeUNDSDl4cDNVMXgzaC9DZmo4SEdUWVRGQXh6ZEhNVzJYQnJyZ05iVVNX?=
 =?utf-8?B?cFZUL2lia0xNaWF1Z3daQUVLbHI5YnVLVnk5RU1kNDJpcXBKS0NrZVdZdzBU?=
 =?utf-8?B?YTZjbmJCeFdmN0hsTThXWGdMT0FoMnM5WVI0MFNobVhDTzUxRHYwa2FDWUti?=
 =?utf-8?B?OEM0dHBmRTJHRnNJSlE5MndoQWFlRzcwVDdPc0RsclFMQ2lKSXA0aGE2UVdF?=
 =?utf-8?B?em5Rb244WDRyS3RRbk9HclVVZDhzVWYzdUNuWEJUc2RhK2FaSEhDQmxaNk9L?=
 =?utf-8?B?Z3pUZVIvNXRLcFpxZS9neXBZdFpGa2lZTjMvRFdad1FxeG9qeUUxRlRVSnRt?=
 =?utf-8?B?eUw1MXExN0Q0SzRiUmJFalRoV0lKVXRxeE1ubGhuR0xVMURIUmV3M3lWRWFp?=
 =?utf-8?B?R3ZlNndTQ2cwZWZJMzJ5UWw4bWR2aG1tNkFkOEl2TDJaR1U5eGhhVUhFenpw?=
 =?utf-8?B?dGlaRURHZnNOVUxZZ2picFlQbzlPbzhodzFnN2tEeTJscHpOaklETXdrdjBz?=
 =?utf-8?B?dmFLa2F2NXRWbG5oSldtNS9UMVlEc2dKV1NqY0ZhMFRTbXZHa2V3Zlk5djcy?=
 =?utf-8?B?alR5RXhIcWVLc0hPYVM4WTFtZkJCNkFFTnFQYll0MEowMUZJRjI2b1hjRzRo?=
 =?utf-8?B?ckNtcDlMWmI1N2lYTGd0eXNoQ1FVTmx2dnVIT2UxZU5XWSszWmcveG9KaEFG?=
 =?utf-8?B?VW5ka0VrVW4rMzNmZGpxOXdlSEgyUEE5ZWFjeVdhYVpGMW5JbWt4NDl2ZVBB?=
 =?utf-8?B?RU1EZ2JmMjNlN2tHL1N0bHN1L09peUZ3TFRPS2dkcjg0VG1SbkNjNlI0MHNZ?=
 =?utf-8?B?blpNSkdmYlVTdUFhSzA4cGZDTFNCVmdjcGxlSzA4MlhRMFg0WUp0eEJLamZ0?=
 =?utf-8?B?NkZ5SUtHdTBBYVE1R0ErUDEzd3NVNHRYa3hndlB1UjFrcWtGMXU3SUpZWkdt?=
 =?utf-8?B?eHROeFFFdXA1eElPb0IrekQ2ZisraTIrSXlVTTVyTGVYcGhKOWNNaXR0blpP?=
 =?utf-8?B?cHA0UlkrRGI5NG11UVhXeUNNRUc3V2xPQklkdGR5YmgzZHpQZ05qZm1iNnNk?=
 =?utf-8?B?MW0wWklXS3JQK05WSlkzakVqK3cvY0ErN2dscHoyMy9PMXYya1Z0SVBzMjEr?=
 =?utf-8?B?NUMwV29uNVgwVTRLZytITlhySGdRSVhMNVJRNDVXVXNxSkh5ZWEvamFHcVRB?=
 =?utf-8?B?d3dJQWtJcVltWEc4MlplcjJWcDVzQTZ3bjVwK3lINTVNaWNtcU55OUNNUjRm?=
 =?utf-8?B?ZzVJU1JBR3QwaU9sK28zSHRpWlVDR0l6OEp1bjBGQzlhS24yVm5xM0RVbUVp?=
 =?utf-8?B?MkZqWERHeW1kMmRCZGYzN3haVVNDNnR4WThwYmJLNGlZdGdsRmV2NllFeWFY?=
 =?utf-8?B?RnloVTRrcXdEQmN3YmxiZWY0eHVUNnY0cENKb0J0TmFyOFN0MzNyQkNHSWtW?=
 =?utf-8?B?aEhpcFZJQ0w3WjVoYVlDc2R3QW84dFh6bDBUM2gydXhkKzl5OVl0eXc0UGhw?=
 =?utf-8?B?czJyNmI3TnZkRzV0SnBId1p1cUpqNEkydGtlQkRDZlpRTCtNck1kY1FwZzdU?=
 =?utf-8?B?WXloNzVQeWYxLzJHVVQ4aWtWWVYvdkhQN3M4bDVGQ0lKNzF1NFdDWmJOMW9T?=
 =?utf-8?B?RkpXeHo0RWo0eEVoWkt4WXVlVWtOYXF6ZFZZMU1ZVGkwVUJBODFMYnhjclpp?=
 =?utf-8?B?MU9WUC8xa0VRY1hLcVNNMHluc0Q3bmVHTXdFdk5MdlZ0SFBDNGptbGVIMUF5?=
 =?utf-8?B?NEJuOWhrcEF2NmE4RVFmWE0vYWtQQmdHZXhTVjI3U3VvQWhwK2xremEzeUQ0?=
 =?utf-8?B?QTdEb01IaWZ4U25zYk83ZFphbmVIOWhEcHZuaFFtdVZOcEFxL1lHVzBWbHox?=
 =?utf-8?B?aitpb2t2RFBkanRhQ2JRcHhLbWdSTEF2aHlFaVNHcjBFQjY4M3k3SW00VERm?=
 =?utf-8?B?U3FVek1TRTVWOENBN0luWnQxUENhNkEzaXYxanNrRXBPak0yRXR2cDNCWitt?=
 =?utf-8?B?K1E4cGZZN2NkY0w0V3lpWmpSSW5iRmd0TytVOGdvZ1JUNmhFMm9OcDBubE9w?=
 =?utf-8?B?NEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b02e4c65-2aad-478d-a8df-08db50e812d0
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2023 23:49:48.2755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BN450nzJ9DQtWExjmJjAM8KdRjPiA22o4ndtx5kKQTlj+SuZgF1VGMFLwVlQq1WURxefxnSbNFyklNeiitPp1fbkI+o4/HRYqwFvzVo8vkM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7515
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/9/2023 4:46 AM, Yunsheng Lin wrote:
> The remaining users calling __skb_frag_set_page() with
> page being NULL seems to be doing defensive programming,
> as shinfo->nr_frags is already decremented, so remove
> them.
> 
> Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> ---
> RFC: remove a local variable as pointed out by Simon.

Makes sense.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>

CC: Simon