Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Tejun Heo <htejun@gmail.com>
Date:   Tue, 9 May 2023 14:43:27 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Azeem Shaikh <azeemshaikh38@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        security@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: kernfs: Prefer strscpy over strlcpy calls
Message-ID: <ZFror6rRtvHFi9Tj@slm.duckdns.org>
References: <20230509223036.3007500-1-azeemshaikh38@gmail.com>
 <ZFrK9Vw9sbE6NSLi@slm.duckdns.org>
 <CADmuW3VAP3-oZSK5Hix5sk62+bbwiCoC3MFoFHmBd-OwXS-pHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADmuW3VAP3-oZSK5Hix5sk62+bbwiCoC3MFoFHmBd-OwXS-pHA@mail.gmail.com>
Precedence: bulk

On Tue, May 09, 2023 at 08:40:08PM -0400, Azeem Shaikh wrote:
> Thanks for the quick response Tejun! I forgot to include the relevant links
> in the commit log, sorry about that.
> https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
> mentions that strlcpy is deprecated and should be replaced with strscpy
> instead. https://github.com/KSPP/linux/issues/89 is the relevant security
> bug which aims to remove strlcpy from the kernel entirely.
> 
> Does that help justify this change? And if so, would you like me to resend
> this patch with the relevant links included in the commit log?

Yeah, I think so. Please explicitly state that this is a part of tree-wide
cleanup.

Thanks.

-- 
tejun