Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230405111559.110220-1-lma@semihalf.com>
In-Reply-To: <20230405111559.110220-1-lma@semihalf.com>
From:   Lukasz Majczak <lma@semihalf.com>
Date:   Wed, 10 May 2023 08:10:28 +0200
Message-ID: <CAFJ_xbqNu3=_jq0HADad9zj+F=TPa4zCoi_8y6Fp3FjymQLkrA@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] serial: core: fix broken console after suspend
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Guenter Roeck <linux@roeck-us.net>
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        upstream@semihalf.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

Is there anything more I should do regarding these changes ?

Best regards,
Lukasz
=C5=9Br., 5 kwi 2023 o 13:19 Lukasz Majczak <lma@semihalf.com> napisa=C5=82=
(a):
>
> This is v2 of a patch[1].
> v1->v2:
> * Fixed typos in commit message
> * Tested[2] patch "serial: core: preserve cflags, ispeed and ospeed" on a=
ll
>   current LTS kernels (4.14, 4.19, 5.4, 5.10, 5.15, 6.1) and on top of
>   6.3-rc5 with positive results - console was working after resume
> * During tests another issue was observed  on 6.1+ - FIFO not enabled aft=
er
>   resume - and an additional change was needed ("serial: core: enable
>   FIFO after resume")
> * Test procedure:
>   1) ensure the console output is ok
>   2) suspend device with "echo freeze > /sys/power/state"
>      (/sys/module/printk/parameters/console_suspend =3D=3D N)
>   3) resume device and check the console output
>   4) suspend device with "echo freeze > /sys/power/state"
>      (/sys/module/printk/parameters/console_suspend =3D=3D Y)
>   5) resume device and check the console output
>
> [1] https://lore.kernel.org/lkml/20230301075751.43839-1-lma@semihalf.com/
> [2] Test platforms: PC with i5-8400 + GB H370M D3H
>                     HP Elite c1030 Chromebook Enterprise i5-10310U
>
> Lukasz Majczak (2):
>   serial: core: preserve cflags, ispeed and ospeed
>   serial: core: enable FIFO after resume
>
>  drivers/tty/serial/serial_core.c | 57 +++++++++++++++-----------------
>  1 file changed, 27 insertions(+), 30 deletions(-)
>
> --
> 2.40.0.577.gac1e443424-goog
>