Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 08:13:58 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     zhangfei <zhang_fei_0403@163.com>
CC:     <ajones@ventanamicro.com>, <aou@eecs.berkeley.edu>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
        <palmer@dabbelt.com>, <paul.walmsley@sifive.com>,
        <zhangfei@nj.iscas.ac.cn>
Subject: Re: [PATCH 1/2] RISC-V: lib: Improve memset assembler formatting
Message-ID: <20230510-cricket-dwindling-a35d40f1da10@wendy>
References: <20230509-b0dc346928ddc8d2b5690f67@orel>
 <20230510035243.8586-1-zhang_fei_0403@163.com>
 <20230510035243.8586-2-zhang_fei_0403@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cBXCyWD8ANQTX0/G"
Content-Disposition: inline
In-Reply-To: <20230510035243.8586-2-zhang_fei_0403@163.com>
Precedence: bulk

--cBXCyWD8ANQTX0/G
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Zhangfei,

On Wed, May 10, 2023 at 11:52:41AM +0800, zhangfei wrote:
> From: Andrew Jones <ajones@ventanamicro.com>
>=20
> Aligning the first operand of each instructions with a tab is a
> typical style which improves readability. Apply it to memset.S.
> While there, we also make a small grammar change to a comment.
>=20
> No functional change intended.
>=20
> Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Three things for you here..
Firstly, since you sent Andrew's work, you need to add your own
Signed-off-by to the patch.
Secondly & thirdly, please version your patchsets & do not later
versions as an reply to the v1. In my mail client I see:

May 10 zhangfei        (  58)           =E2=94=8C=E2=94=80>[PATCH 2/2] risc=
v: Optimize memset
May 10 Andrew Jones    (  36)           =E2=94=82 =E2=94=8C=E2=94=80>
May 10 zhangfei        (  32)           =E2=94=9C=E2=94=80>Re: [PATCH] risc=
v: Optimize memset
May 10 zhangfei        ( 205)           =E2=94=9C=E2=94=80>[PATCH 1/2] RISC=
-V: lib: Improve memset assembler formatting
May 10 zhangfei        (  56)         =E2=94=8C=E2=94=80>[PATCH 0/2] riscv:=
 Optimize memset for data sizes less than 16 bytes
May 09 Andrew Jones    (  87)       =E2=94=8C=E2=94=80>Re: [PATCH] riscv: O=
ptimize memset
May 09 zhangfei        (  67)     =E2=94=8C=E2=94=80>Re: Re: [PATCH] riscv:=
 Optimize memset
May 09 Andrew Jones    ( 211)     =E2=94=9C=E2=94=80>Re: [PATCH 1/2] RISC-V=
: lib: Improve memset assembler formatting
May 09 zhangfei        (  57)     =E2=94=9C=E2=94=80>[PATCH 2/2] riscv: Opt=
imize memset
May 09 zhangfei        ( 204)   =E2=94=8C=E2=94=80>[PATCH 1/2] RISC-V: lib:=
 Improve memset assembler formatting
May 05 Andrew Jones    (  91) =E2=94=8C=E2=94=80>
May 05 =E5=BC=A0=E9=A3=9E            (  38) [PATCH] riscv: Optimize memset

How am I supposed to know what is what there?

Thanks,
Conor.

--cBXCyWD8ANQTX0/G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZFtENgAKCRB4tDGHoIJi
0hBMAP0d6q46/8kriiKrrTjdhs3AC87O5BVmNujgDAfo+Bj98AD/X80Lu5zP9oPj
C2xPcZjZNPJ2xwdBfBqAW1oPf4QJmAU=
=l3yW
-----END PGP SIGNATURE-----

--cBXCyWD8ANQTX0/G--