Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] ASoC: dt-bindings: Adjust #sound-dai-cells on TI's
 single-DAI codecs
From:   =?utf-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
In-Reply-To: <baf338a7-1e63-4842-32a1-8f63f850bd2d@linaro.org>
Date:   Wed, 10 May 2023 09:30:12 +0200
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
        Shi Fu <shifu0704@thundersoft.com>,
        Shenghao Ding <shenghao-ding@ti.com>, kevin-lu@ti.com,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, asahi@lists.linux.dev
Content-Transfer-Encoding: quoted-printable
Message-Id: <A8647EF5-566A-4B99-9020-772810CB2BF7@cutebit.org>
References: <20230509153412.62847-1-povik+lin@cutebit.org>
 <baf338a7-1e63-4842-32a1-8f63f850bd2d@linaro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Precedence: bulk


> On 10. 5. 2023, at 9:17, Krzysztof Kozlowski =
<krzysztof.kozlowski@linaro.org> wrote:
>=20
> On 09/05/2023 17:34, Martin Povi=C5=A1er wrote:
>> A bunch of TI's codecs have binding schemas which force =
#sound-dai-cells
>> to one despite those codecs only having a single DAI. Allow for =
bindings
>> with zero DAI cells and deprecate the former non-zero value.
>>=20
>> Signed-off-by: Martin Povi=C5=A1er <povik+lin@cutebit.org>
>> ---
>> Documentation/devicetree/bindings/sound/tas2562.yaml | 6 ++++--
>> Documentation/devicetree/bindings/sound/tas2770.yaml | 6 ++++--
>> Documentation/devicetree/bindings/sound/tas27xx.yaml | 6 ++++--
>> 3 files changed, 12 insertions(+), 6 deletions(-)
>>=20
>> diff --git a/Documentation/devicetree/bindings/sound/tas2562.yaml =
b/Documentation/devicetree/bindings/sound/tas2562.yaml
>> index a5bb561bfcfb..31a3024ea789 100644
>> --- a/Documentation/devicetree/bindings/sound/tas2562.yaml
>> +++ b/Documentation/devicetree/bindings/sound/tas2562.yaml
>> @@ -55,7 +55,9 @@ properties:
>>     description: TDM TX current sense time slot.
>>=20
>>   '#sound-dai-cells':
>> -    const: 1
>> +    # The codec has a single DAI, the #sound-dai-cells=3D<1>; case =
is left in for backward
>> +    # compatibility but is deprecated.
>> +    enum: [0, 1]
>=20
> Does it? I see playback and capture.

I think so. Playback and capture are not separate DAIs.

Martin

>=20
> Best regards,
> Krzysztof