Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 10:06:16 +0200
Message-ID: <87a5yc626f.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ivan Orlov <ivan.orlov0322@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, oswald.buddenhagen@gmx.de,
        axboe@kernel.dk, 42.hyeyoo@gmail.com, surenb@google.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c
In-Reply-To: <f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com>
References: <20230510072726.435247-1-ivan.orlov0322@gmail.com>
        <2023051052-recoil-headache-1594@gregkh>
        <f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 10 May 2023 09:55:18 +0200,
Ivan Orlov wrote:
> 
> On 5/10/23 11:48, Greg KH wrote:
> > - Your patch did many different things all at once, making it difficult
> >    to review.  All Linux kernel patches need to only do one thing at a
> >    time.  If you need to do multiple things (such as clean up all coding
> >    style issues in a file/driver), do it in a sequence of patches, each
> >    one doing only one thing.  This will make it easier to review the
> >    patches to ensure that they are correct, and to help alleviate any
> >    merge issues that larger patches can cause.
> > 
> > If you wish to discuss this problem further, or you have questions about
> > how to resolve this issue, please feel free to respond to this email and
> > Greg will reply once he has dug out from the pending patches received
> > from other developers.
> > 
> > thanks,
> > 
> > greg k-h's patch email bot
> 
> Greg's Bot is right, it will be better as a sequence of patches. Sorry
> for bothering!

Also, if it's only about white space fix or some indent level issues,
that could be rather more noise and disturbs the git change history,
e.g. it makes difficult to find out the real code changes via git
blame, especially it touches a huge amount of lines like this.

That said, I'm not going to take such "coding style cleanup" patch
blindly.  If it's associated with other real fix or enhancement, I'll
happily take it.  Otherwise, I'd rather leave it.


thanks,

Takashi