Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peng Fan <peng.fan@nxp.com>
To:     Greg KH <greg@kroah.com>, "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
CC:     "abelvesa@kernel.org" <abelvesa@kernel.org>,
        "mturquette@baylibre.com" <mturquette@baylibre.com>,
        "sboyd@kernel.org" <sboyd@kernel.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clk: imx: imx93: introduce clk_bypassed module parameter
Thread-Topic: [PATCH] clk: imx: imx93: introduce clk_bypassed module parameter
Thread-Index: AQHZfmVsUoWhON65f0ewGxlg24Oc/K9J088AgAlWulA=
Date:   Wed, 10 May 2023 07:49:20 +0000
Message-ID: <DU0PR04MB9417FE67ABF9A2B1EE4DEBA088779@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20230504085506.504474-1-peng.fan@oss.nxp.com>
 <2023050410-rejoin-vocation-8560@gregkh>
In-Reply-To: <2023050410-rejoin-vocation-8560@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C4FGobatGfJ8ms9fsvCLYb5dYfKJRG2aB+Oxd6LUvYpFVDz5UZSnL+av7kn4?=
 =?us-ascii?Q?rzthoMJlFfW55kH1mqMn1NIkOtLGQAzrTGiIe/Q7JXgydvChUDGLd0VWtMFt?=
 =?us-ascii?Q?ReIpMv1BmIBisq52yT0dHRXQACox/3dVY9Uw3Y/ndhAxr0RKMBP7zKDk1SIu?=
 =?us-ascii?Q?/ziV+PbQfOUJnJbV3n44ayIsiaPQeGGihqsSDPERvzbbwAPIY3jRzBocskWa?=
 =?us-ascii?Q?9H9KhA2QcTxiQvQfxekDklPcI2OYtsiEjCc7WahiAjux6ZzC0KOryBrnxaTI?=
 =?us-ascii?Q?hMTsgZxUyIW4TKgQUqhGgGgh+aYrsCijP6eTF6d8h89TwXxFx2KYDot4K+1d?=
 =?us-ascii?Q?vm4RRXLXlNjerGmvbXvYveKy3HaEoQtHEAdRdlVTRUQdA/SG9lyg5OaGdLzl?=
 =?us-ascii?Q?YZOdiJFezdU+dG2lk0vI6V1FS8Bk4PO0pFtY+BWsQe/KkSkR4M0ihLkY1hm4?=
 =?us-ascii?Q?OfyeEh8aGz+PXYyKhVJj8jg9Qz5cUkGBiUSRcAQgWlfsb1RigLi+yQpeg7B2?=
 =?us-ascii?Q?y0AjxxQW0U+K12pHWOrTCsFoP7M4//RftRUYgoGiQFznq0juqdFNHhfgRGE+?=
 =?us-ascii?Q?yKSNDNxDlWp8dWdbUQ3GQi2qiighMSAEqz5VJxW5ZakVuYD0hJ7oRuMFddRG?=
 =?us-ascii?Q?Y0rtZKmbBl5F8pI1FN1+oWXmz+DUL1qpDOpykdubGnn+yuemvZJTwK/6uxDD?=
 =?us-ascii?Q?H9HdqupBTLzJxF5UpYAJRRRLTOsY/hzdaFvBnVyk3BdNGq+5NbiI1r61EVjU?=
 =?us-ascii?Q?dXRjsrFauucQx2UmXqlK5crLTv0I5Dbnb2P9OvLYYaO1LsMV6NlU8iVCyHIU?=
 =?us-ascii?Q?nYHZUTAm2tLBha7ylXn8xT67Jq/dGt3DXtZOQ+jOYhqyCExoH8mRp+GLFoEd?=
 =?us-ascii?Q?je0rg/XibWGdHyVH7JWXmmgonvLST+MYx52qwg/cgczfJc0jshA6PKbyplvr?=
 =?us-ascii?Q?YH/a9Wl5YekiyeWOMBiSBLTCFc56gthrRJK+ig9mgb/OzCsu3hfYii5O0bia?=
 =?us-ascii?Q?MtTsCwZKnrGpa1xliL64+W1OcCfT+Q4bzkAR0/zSUmeHeQAM5dX6lalICCeE?=
 =?us-ascii?Q?lQndsAkGn4znwtdxvCztiq04hWCQaZaRxROnUPZ8oi/ijHcuvgXWy4DnCs9A?=
 =?us-ascii?Q?ga9CXGDGA58rEcp9LHL/qy9adsYDe5b4gJ5oKx0ikiGz4QqJA6CoUqV9/yDC?=
 =?us-ascii?Q?YtewoIL5zHHnj09hzDR5DqQQgiilEyVGKbyjfoyjZtippcNCyTSrAISsDZqv?=
 =?us-ascii?Q?ceaePEqy9g2zlkOIROR4jE1t0Oh8tHBr1GepP4ObRzqVRLyu6Jhx75ksmVDu?=
 =?us-ascii?Q?HggkkzU3J/w+p8jwtn/iMYSXMyKjrX3QheE2Zo69GMb3ABG5G0nhPG11lWNg?=
 =?us-ascii?Q?su9yMDNmMyis0c2JsV1SI75axrMWu8LhzXadCULzULqAC38TsDc8it+FSZFN?=
 =?us-ascii?Q?YWSmr4X8bJ/jORfRp3HtoqQW/BcdqLH88k2Ljul8WYg1auhPetMHRexKw0Uu?=
 =?us-ascii?Q?PPBV17Ktx+uxr9JmYasJkhp2dvoiTXWrYSCocj5nwYuxVBC2qj/zPOUUWF1i?=
 =?us-ascii?Q?VckGsrovmqZNBUjrgDI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0da4e355-95e2-4919-90a8-08db512b108c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 07:49:20.5669
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rrNUzqvheeXceHBtJ9RchUtSkZOuN7/Yn7LdCoaMBZgKXt61ufGVdibg1NYk+magYGVNxFE6a8+M7Z/5oowCMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR04MB10061
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Subject: Re: [PATCH] clk: imx: imx93: introduce clk_bypassed module
> parameter
>=20
> On Thu, May 04, 2023 at 04:55:06PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > With the clk names specified in clk_bypassed module parameter, give
> > user an option to bypass the clk from managing them by Linux kernel.
>=20
> As I said on another email, no, please do not add new module parameters
> for drivers, this is not the 1990s

After a search of the list,
https://lore.kernel.org/all/?q=3Dmodule_param

I still see many drivers are adding module_param.

Is this is strict ban that new platform driver should not add
module_param?

Thanks,
Peng.

>=20
> Also, another comment below:
>=20
> > @@ -310,6 +357,8 @@ static int imx93_clocks_probe(struct
> > platform_device *pdev)
> >
> >  	for (i =3D 0; i < ARRAY_SIZE(root_array); i++) {
> >  		root =3D &root_array[i];
> > +		if (unlikely(imx_clk_bypass_check(root->name)))
> > +			continue;
>=20
> Only ever use likely/unlikely if you can measure the difference.  Here on=
 a
> probe function, you can not, this is not needed at all, the compiler and =
CPU
> will do a better job over time than you can guess at this.
>=20
> But as this change isn't needed, this shouldn't be an issue either.
>=20
> thanks,
>=20
> greg k-h