Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 10:21:08 +0200
From:   Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Ivan Orlov <ivan.orlov0322@gmail.com>, perex@perex.cz,
        tiwai@suse.com, axboe@kernel.dk, 42.hyeyoo@gmail.com,
        surenb@google.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] ALSA: PCM: Fix codestyle issues in pcm_native.c
Message-ID: <ZFtT9J0DQI9uSd1x@ugly>
Mail-Followup-To: Takashi Iwai <tiwai@suse.de>,
        Ivan Orlov <ivan.orlov0322@gmail.com>, perex@perex.cz,
        tiwai@suse.com, axboe@kernel.dk, 42.hyeyoo@gmail.com,
        surenb@google.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
References: <20230510072726.435247-1-ivan.orlov0322@gmail.com>
 <2023051052-recoil-headache-1594@gregkh>
 <f1a912ea-884b-fdcd-1c05-87089f1e97b7@gmail.com>
 <87a5yc626f.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <87a5yc626f.wl-tiwai@suse.de>
Precedence: bulk

On Wed, May 10, 2023 at 10:06:16AM +0200, Takashi Iwai wrote:
>Also, if it's only about white space fix or some indent level issues,
>that could be rather more noise and disturbs the git change history,
>e.g. it makes difficult to find out the real code changes via git
>blame, especially it touches a huge amount of lines like this.
>
>That said, I'm not going to take such "coding style cleanup" patch
>blindly.  If it's associated with other real fix or enhancement, I'll
>happily take it.  Otherwise, I'd rather leave it.
>
a maybe less confusing way to put it would be "do whitespace cleanups 
only on the lines that contain "real" changes, and maybe in their 
immediate proximity for consistency". that means that whitespace-only 
patches are by definition not acceptable.

regards