Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yan Wang <rk.code@outlook.com>
To:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk
Cc:     Yan Wang <rk.code@outlook.com>
Subject: [PATCH v3] net: mdiobus: Add a function to deassert reset
Date:   Wed, 10 May 2023 16:15:22 +0800
Message-ID: <KL1PR01MB5448A33A549CDAD7D68945B9E6779@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: KL1PR01MB5448:EE_|TYZPR01MB5258:EE_
X-MS-Office365-Filtering-Correlation-Id: 970beb9a-7c95-44a8-80bd-08db512ec098
X-MS-Exchange-SLBlob-MailProps: Cq7lScuPrnoXjDUq8U81DgqU2Yh/IM/qLFwPWOVjsZzDA1JtHG0MQR0oGrKOkfjCZ/YnrJHRujVH4uo97XNvuxPV6CPGug14IZWzkuxTgJ36nIp5bWMPMUYR6MDB40+Td0WgPo6HrhcTmX1Q1qn3kRjE0qVvcFE24T5g/6Lih07VmPsXc1NZWxEm2U2gah82e/LZn6Yyb0PQhj6ZjyOvk1KtohzjFaeQDOH1n5+2l5oIq7xrjb7Ob/YJs2ecM4Z9LqbMFx5ySqFQ+JtYWtdq68WHYsLwg/WizctY+MbQNqkq49I7uwB+vlPgsnog7byGNMK4itXqbOuNbQLPNMocTXI+QytBKtmS4WzXm7ICyoP+T2b1CQh49k/Tqjz8LnAzy89e+/v7JXp1eGIIIZcVs8c4Uh7ahyEKhXU98og56+ioU6E4LBYDBz9OpIC1GNgCaJ6+c7/jbNHLbtkod5yedfMLclB7HIkqUNahUxW1Q87vO3kzDe+/M0NPUgizUyDAg3C9ZvRvG+7L0xLm24OUi7fmX/XJX7fd8yrjnvY75sf0N5mtG76sTAkjhe/8o8UUzJ6iukHy5UIcIq1zphEKKzfnwPdNRoYUXGvPwaQk7DGX24lVFZ4uK6vsuGxmpUCY4sH/W7Qu7x8jmk0eJy0sH0bQzjEEa9cah38IuqUFhKo1cO/AZcV6KzDXK0iI4hbqoAkEAXMQS3un5gcR8UyKeDgfJlzm3l60au6IGPKqxFnCqOEivQqDSacL6FliUSIhuo8vfJ0HuHE=
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: qAv4JR3El4+vbwyiitEq2u+NSzivilNfFRc7p81cyrhMHblvRxSa08TZKzk33L2lMLUdXqcaV2vuYdaB3a+m8v/8lnDpebdKwQ5WhilUyJ6g1/alQL4c+P0K6hGi+8vZ2aq/kNMyEJ2UQgqcqzFwvOwzRzxL5kgVjfFDtSZsnSk/6yMtjzCdJ/VIIQTbEjjf213BkwJJNEXR5alwcebmi9WjbVSRjAZANv6eU0TjjzVuhf9M5C11/3TKykvCHYOaLbFVx0dSOcV2RGlsOhA78Dt5KXLwwIcSXNou9CvzKtHU8LEioBv15GuvBQ10jAba4iIASmSE3UgTjAG6BIivklDzJhOho7H7tDEPD5WqfrmfIlsM0CjqmCCEmD+uaCvDOXHcMKPLi4brG1xdVj2C5IVZCW8pGsZt+GYZfDJZRQWPpXrYBZv31wQ5FWgh3vQ1Bsiz+fW1oqL5Ij/t2U8XMu5HqhrviAj+5g+lpUDcP3oMb1D1J3Dh96xudyC8QvWknc8qvy22YIJjdgGH5i1v8auvbGWIO/T9LQqfSM6uVQE8gN5nWLznMVBfaVI/IhgJMNz8rECvpbc3vPm+MDix/MMdTA0y2ve1+jIt5XZUE2Vbqg/UfekNrXrZ4V8d9Skt5nGQDBhaMXleaWayOQ9AgQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YCFHj1QmbVEtWk6tXsb9Z/inJTKeg77VRTzdbA1EFVsJgokNMeiV+qWccITI?=
 =?us-ascii?Q?0xo0xKGISfIuBBpA57fjwND6aX1KJ2oNZz4nuy5lkPQg2C0pOHumvG1a6p41?=
 =?us-ascii?Q?F3Gof10ZAl8e7u+CVnZdB9XDtAfINjFIlnQNeRQZVFIntbI7/2GZ7YUtRbYu?=
 =?us-ascii?Q?CcwNQRhNglrUQEaY70Sf0/uE41CO0KYs76EbBPuNbSUtbH/1NN1IcthJR5IE?=
 =?us-ascii?Q?XzSj64FuZWAo6EmpvTe8Osf3gLynliHZvl5JXXwRP9U6lb7rqWSL3zb8CSpT?=
 =?us-ascii?Q?eek4bAZkK3adtdcYUZWCueiMhsNKfgXD8k/dgdnNZqVm/xFvbjF6hgNvm1Ki?=
 =?us-ascii?Q?sASq4Ryb5EplCQiSk8mkN0IGu6UR9MWtxdZ8vQ3jhvd9A/2lCAW/7I20OHaY?=
 =?us-ascii?Q?LhRrz9T7x/lTEg1m03SJdVvpvZjgshRx8s870TYV0G/doNB6JS2vDHqD6Qi2?=
 =?us-ascii?Q?dnWMkpPNV5ScrJdUyb/lsUNfv6VLuNYZgMH1jS1qhqgQOOqL+3Qr9FglK5zE?=
 =?us-ascii?Q?2p+Cf00uTkbZcKP4G/WZjNcxJ/17QeandenzQcRRKQVrOf2OeDUQ8rMPK2iM?=
 =?us-ascii?Q?zVmdlKv+Q5zH6MCl56ccjeRT5XWrrTBcsS8QxQrbktNtsBblnW6qO/itIQfo?=
 =?us-ascii?Q?JaX9nG9122VbPpLCGeFsTydAylquWBwBWuB2wYl75THFrnFzPNQVTv9uJwSF?=
 =?us-ascii?Q?/0L4dYvOsvrWSb3Wx6WUs2EgXlHs8uSlyd45xMKl9qfARgJYbuU15YVaa8ch?=
 =?us-ascii?Q?lpm/t0sxp397eJSJbCRyrhR4xcy3MZCOZAF2tXLuqa/CPGFKkz/NCp8wEfIp?=
 =?us-ascii?Q?ELqg0WrKZPj3M8xkrgPCOvGZ+DyqpLZEvtFP6CBrvSSb84F89BstRwzj+/Sk?=
 =?us-ascii?Q?7/8uen+HKL4NksSz8TCU8B3sLXYJeksNnpWUjSp1U7FsX5MXFlKMSmqDmYGq?=
 =?us-ascii?Q?eGv3zPGBtRR1fIjGYqscrXBgYJZ3PH/N43LFLTDFVTvJytdkzaB15sxHreTs?=
 =?us-ascii?Q?Ne/LoMXSQOSTNFmcj3qFgyHhKBOvgKiovJKeOZcDSyRwIVT+fmv6WsDUBuWw?=
 =?us-ascii?Q?Cf/CHPXHmhSlEJ4cWx7CiMrBuxNVLDMVGvGYohKzJ+dBfOggtNLHmIhNZTMH?=
 =?us-ascii?Q?D3e0ADWontjjzBAKNqUetuvEwstJoplXNDT+oirpvocEx6bAa0MJN5PDRzI8?=
 =?us-ascii?Q?uj+B2Zk8n0EjcfOas4lueWKZwqd1SAh+27D0zQ=3D=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 970beb9a-7c95-44a8-80bd-08db512ec098
X-MS-Exchange-CrossTenant-AuthSource: KL1PR01MB5448.apcprd01.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 08:15:44.7647
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR01MB5258
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is possible to mount multiple sub-devices on the mido bus.
The hardware power-on does not necessarily reset these devices.
The device may be in an uncertain state, causing the device's ID
to not be scanned.

So, before adding a reset to the scan, make sure the device is in
normal working mode.

I found that the subsequent drive registers the reset pin into the
structure of the sub-device to prevent conflicts, so release the
reset pin.

Signed-off-by: Yan Wang <rk.code@outlook.com>
---
v3:
  - fixed commit message
v2: https://lore.kernel.org/all/KL1PR01MB54482416A8BE0D80EA27223CE6779@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/
  - fixed commit message
  - Using gpiod_ replace gpio_
v1: https://lore.kernel.org/all/KL1PR01MB5448631F2D6F71021602117FE6769@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/
  - Incorrect description of commit message.
  - The gpio-api too old
---
 drivers/net/mdio/fwnode_mdio.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
index 1183ef5e203e..6695848b8ef2 100644
--- a/drivers/net/mdio/fwnode_mdio.c
+++ b/drivers/net/mdio/fwnode_mdio.c
@@ -57,6 +57,20 @@ fwnode_find_mii_timestamper(struct fwnode_handle *fwnode)
 	return register_mii_timestamper(arg.np, arg.args[0]);
 }
 
+static void fwnode_mdiobus_pre_enable_phy(struct fwnode_handle *fwnode)
+{
+	struct gpio_desc *reset;
+
+	reset = fwnode_gpiod_get_index(fwnode, "reset", 0, GPIOD_OUT_HIGH, NULL);
+	if (IS_ERR(reset) && PTR_ERR(reset) != -EPROBE_DEFER)
+		return;
+
+	usleep_range(100, 200);
+	gpiod_set_value_cansleep(reset, 0);
+	/*Release the reset pin,it needs to be registered with the PHY.*/
+	gpiod_put(reset);
+}
+
 int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
 				       struct phy_device *phy,
 				       struct fwnode_handle *child, u32 addr)
@@ -119,6 +133,8 @@ int fwnode_mdiobus_register_phy(struct mii_bus *bus,
 	u32 phy_id;
 	int rc;
 
+	fwnode_mdiobus_pre_enable_phy(child);
+
 	psec = fwnode_find_pse_control(child);
 	if (IS_ERR(psec))
 		return PTR_ERR(psec);
-- 
2.17.1