Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 10:16:23 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc:     Yunsheng Lin <linyunsheng@huawei.com>, davem@davemloft.net,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 2/2] net: remove __skb_frag_set_page()
Message-ID: <ZFtS1zfi+zrI0KJu@corigine.com>
References: <20230509114634.21079-1-linyunsheng@huawei.com>
 <2345b39d-366d-cd37-1026-2663679b4bed@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2345b39d-366d-cd37-1026-2663679b4bed@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MfSqrxfudzIGmGzgI707EBNjuEh+5s40EsVFvFysvjJAg5m1vx2n0ZBiX8ho?=
 =?us-ascii?Q?NsMDfS3ooa2lshcphg5eHcy0jM16+mnOZvsYdlswcf8hI25wNKUtr9iJqM3w?=
 =?us-ascii?Q?XY3szAByRPN+QZ2ZVgb5foUPSRy5zmQSP99YxTdA8hIUFE4c8qOui96OCVXn?=
 =?us-ascii?Q?9gAW8xTgG5XseUx6qPx3sV+IAbkXqntlIp6pqNddi+ZhrovBad7rmofopDqP?=
 =?us-ascii?Q?0a7unAztGXgsAHK+7DeYqpRgCW4EPRaSyRgzd67orrms5tfzNIhkjNBjKrxo?=
 =?us-ascii?Q?x7G2x5+XGmWhRksgbOTgtb34FoXjszqwy3E+hnE0F0OneYqHOCtKsYtj9twQ?=
 =?us-ascii?Q?UPdEibOLDCpKsWUyN5weLTNNCFvvzHkG8Pb2iCGB4ogkYGQqXLYfbd3JeOZc?=
 =?us-ascii?Q?NrMYbpa/FvD+sqXmTZdQpO5DgC6l1j/i1ub2jQ6QVLPsXsIXz+n7pn5u7RCc?=
 =?us-ascii?Q?dVHlaFrGvc4wsosS2Bw/wvlM7jF59GWRoy9LxA36XuVozdv2qJBGBq+7flpt?=
 =?us-ascii?Q?dvndIZipRIWCe1FRGEPnYaUWtm1D2zP5Yj/7sBxSFx24D35zSuYPDKnwAsxp?=
 =?us-ascii?Q?HasSu4zhgOsk8mJHAn+MAy104mE0b77T5SLxtAwz+t9mprbZwqSV7VllzrYj?=
 =?us-ascii?Q?HIt843QpWi/fDBSt0dJwNSvt2HbSMt/FwRw2oop4YsCesjp7gFmXqf8voGjB?=
 =?us-ascii?Q?FQKsR3Gw81xeQ4uvlG9S2ssM+Z8WqonYTNrmGpUQwDaNabujvyy4YQDirgpr?=
 =?us-ascii?Q?xrWfKBgT2IVViAns4bms0a78oSBb97IMekZxY0AJZoOqNMpihsseROTbols5?=
 =?us-ascii?Q?HgpcU6XZZKDBO3flle/P2Zm2sBucpuqP8PqWukEgW/lliGoKY4Qm+6WKVk0l?=
 =?us-ascii?Q?ES58ImeEqY+wqEqS0vz+YKKREuDA39CW9iBZgbNPPr2owr2YvFsxJW++mo7H?=
 =?us-ascii?Q?Vd3QpPSsrPwIfnPc++kZ51d9s2g6anVVyqWaBSckOop8TjK5+mWvAZE8NB0w?=
 =?us-ascii?Q?npSLtj8RM8NwFr76xXSEzegaPRrtaPKegk6hs1t403DBiYe5PyuVyyz0aw9/?=
 =?us-ascii?Q?l2emVBTcM5hbHdu8SxQI56M5B0HecwHYMLVs0GH6p6Lye0uDSmne3VbILQGd?=
 =?us-ascii?Q?nVLC8tQE0he3whE+Fc8A1TafIbAJOLii9k41pI0EMxL7cuoZlKwgwN7AM9Xs?=
 =?us-ascii?Q?RRFHGJu01+uCU641okfGSPGh87KSc1TtH4SXiGi+uFRY5bIJKVPSdxUHfHu5?=
 =?us-ascii?Q?9DCtW4nnXt546OwtwBkmii5g14ZARj38xsnGRaQCfTmGG0q4xCSK7DZ1M9f1?=
 =?us-ascii?Q?6tRMJdBM2Lse+Jdx7gUoiizq5qUics/k8S/byOw0ft/inyzsLw9T2adzD+qK?=
 =?us-ascii?Q?KlqTblz9oBPq+FLeCzBlTJ7Ds7HmlijnJnjPgceFtZaKutRqbw0XFwahIEWx?=
 =?us-ascii?Q?zsiFMu2RpdoDevVF6rA/OUO6QprTbs0Ow/JbSUyxKYeCODgzYCHW34Tbg03s?=
 =?us-ascii?Q?h0mGAXRhObAZcUpdO9iBE3fp42oYUCUjXmcpLBc4DUL+HR3fTR6LZA2IfAdB?=
 =?us-ascii?Q?7SEpGc9tcjsYwfECx1gtwWzRV4i1T9r1Nu+llD7ZSyiSRkeB6Y3QXQoYN/oH?=
 =?us-ascii?Q?aqiwmeULXZcbLlunxpILLlusiVPG0IhotcsVV/QcCfscVK19hC1IGvdHztrY?=
 =?us-ascii?Q?Mw3Gag=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc394d39-fe3e-4ef5-aadd-08db512edb50
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 08:16:29.4597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SMj3gigSWn7Egd0NtYUOdOTxPi8J/D7q7ZQ9I+sJdtxl7KarBD7N0yPBVyj2hKPtsuHeoAIuZ7LcNZdTD55KrQcVtepktg+NVX7D/S0409k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3690
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2023 at 04:49:46PM -0700, Jesse Brandeburg wrote:
> On 5/9/2023 4:46 AM, Yunsheng Lin wrote:
> > The remaining users calling __skb_frag_set_page() with
> > page being NULL seems to be doing defensive programming,
> > as shinfo->nr_frags is already decremented, so remove
> > them.
> > 
> > Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
> > ---
> > RFC: remove a local variable as pointed out by Simon.
> 
> Makes sense.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 
> CC: Simon

Thanks Yunsheng and Jessee,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>