Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6965921rwr; Wed, 10 May 2023 01:45:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6ZuEHRyZjmtDW/hlNyTXDTjlz+x5E9F5dnndWk6GhW/V/dOeiOthOntNzF6cQnUgO5HoJY X-Received: by 2002:a05:6a00:9aa:b0:646:59e4:94eb with SMTP id u42-20020a056a0009aa00b0064659e494ebmr12530877pfg.15.1683708344172; Wed, 10 May 2023 01:45:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683708344; cv=none; d=google.com; s=arc-20160816; b=c0BUyCAlKblynnrXBnWwrUP6yD/v9cFiVoFljLVqtDH968FW3pfllYbttBXZvRbu5b PbyHkpmYb6h7fgd9oKcywYSnd+hXkbPOSkyqrkYKHnM7LYGuIDjyBlvfHvDyUwzzWI4H gQu9CxXwPpgPZ7pxmg5XJHtWNYtlg0vOGKmngduShnDZOAXbyZ4y69D7xGdsa6mSZrlx nLa5BAwYZdw+ubt1loXjuYf3iTJKE6SJsi312/RxynUb8qpu/DCD8HPgeQlv+YZA80Sw dVV5elvLOzVDiEEeJck3W0dQLTfmS7yYPVhinmDjMadB+t5jHBWrjdo9k7hgRd48FmP2 EAtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B+pxvGwx4qB2jHtPFwxz+r1x0GCU+Pru3QTkQf29r70=; b=ZEfHHloa3m/YE+I7Q7wVrFbFKghIjJNdMTzZChmXzHKzPyLxiqX+m05/Wu6irrMe7L XjUGZ8ARW40T6vjaspi90C9Gfj6H1NzP0xgpUAurezIa7WpdWZz7WzwmEe4cZKxE+1p7 PZVAcMFKi7rF/k0feMncX9Bbf5Vhq+k8fdRtJ2iEEa0JBURGBZx8VLOCdCpXnierH5Mu eXgAKeCWOEJmEUhSENQtu3RgbULAEGE8XwF52NZHtKObepvYC1LPxI8lxoz22GKJdYlI m7vdZViTzHfClY6HNyRphDYek10Z4dRfgk+DyXU8CxIomdxVDvlOe+AJJrPRkIIhFiU9 vMAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=XS4lXvC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s189-20020a625ec6000000b0063d30a836e1si4372297pfb.244.2023.05.10.01.45.30; Wed, 10 May 2023 01:45:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance.com header.s=google header.b=XS4lXvC8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236598AbjEJIg1 (ORCPT + 99 others); Wed, 10 May 2023 04:36:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236215AbjEJIgC (ORCPT ); Wed, 10 May 2023 04:36:02 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644167EDC for ; Wed, 10 May 2023 01:35:04 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-250252e4113so4442416a91.0 for ; Wed, 10 May 2023 01:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1683707701; x=1686299701; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B+pxvGwx4qB2jHtPFwxz+r1x0GCU+Pru3QTkQf29r70=; b=XS4lXvC8vT8nuNkAPeVfxGO6MExeVGMlRdfuS1WsmFBoO9YOIkIy3P47jFVVbltmFA XEQTbQ4Z2KX6LnkdjTiv52RO8aSkyYW60JN1sT9m/DVCIBXCRuiZVgIVEYsK16tkDh2a J1S8GxrQ/zGBGJEULn/ByH+kY2byciWSyADTPu6XvO3jUC96V9uGqKTO+fteZZE6Sgzm MrrhoUI9ngx0C7mrBDOP43CtCqn/2vtQg2JRBEt0CUWLefphHHjf8xyd/PbFgjsZeapB XvdxREPMKu+/9NNeM0phepmBcD5pQliENE0Fzy6ttrttM/qYvHC60kCYebUSUDitPbw7 4qMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683707701; x=1686299701; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B+pxvGwx4qB2jHtPFwxz+r1x0GCU+Pru3QTkQf29r70=; b=X9vYP0MMXDUxA2thQqRKtrQySZWOwMaXnQVK8bZ76u9x4TUNGYO3Nmcoh+SwA+IDUZ ZXqAnjvYxnduX3zTP7LnAgUfP0IuWFNDMilyChya6q4IQZN0iQ4l2Xlj8hA9l8xvqIv8 Xmm5yecRpMHflHtk27uhQG7IbRd7o8XMkEeewPFS1Gy8i7CbbZhE0G/M76detSut7syM UUaoGLGFSrZP1gZZtdURPDDIBQJWoiybRV5cjqIC2aM4QUgEZcHA/zfqugMYhep/JHN6 O7F+IVInl3Ax9D1xR8njNsFWzXartu0gowtawjnVM01cXfT6Eevgo/erBWdjyTbjP9Os 7aBA== X-Gm-Message-State: AC+VfDwfRQXCPQ29P0ysHupNoBz7c9pF9aaay8OA2M7egkhzPid4vhxI E6dla6p7tNeB06epiV5wrVbFoQ== X-Received: by 2002:a17:90b:148d:b0:23f:b609:e707 with SMTP id js13-20020a17090b148d00b0023fb609e707mr17649802pjb.2.1683707700896; Wed, 10 May 2023 01:35:00 -0700 (PDT) Received: from C02G87K0MD6R.bytedance.net ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id m2-20020a17090a668200b002504a1a5d1asm7588359pjj.29.2023.05.10.01.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 May 2023 01:35:00 -0700 (PDT) From: Hao Jia To: mingo@redhat.com, peterz@infradead.org, mingo@kernel.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mgorman@techsingularity.net Cc: linux-kernel@vger.kernel.org, Hao Jia Subject: [PATCH v2 0/2] Fix two warnings about rq clock Date: Wed, 10 May 2023 16:34:48 +0800 Message-Id: <20230510083450.62334-1-jiahao.os@bytedance.com> X-Mailer: git-send-email 2.37.0 (Apple Git-136) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These two patches fix two warnings about rq clock Patch1 fixes the warning of using the old rq clock caused by missing update rq clock. Patch2 fixes the warning that the rq clock was updated multiple times while holding the rq lock. v1->v2: - Vincent Guittot suggested using rq_clock_start_loop_update() to prevent multiple calls to update_rq_clock() in unthrottle_cfs_rq() instead of removing update_rq_clock() from unthrottle_cfs_rq() and updating the rq clock before unthrottle_cfs_rq() for patch2. [v1] https://lore.kernel.org/all/20230410081206.23441-1-jiahao.os@bytedance.com Hao Jia (2): sched/core: Fixed missing rq clock update before calling set_rq_offline() sched/core: Avoid double calling update_rq_clock() kernel/sched/core.c | 7 ++++--- kernel/sched/fair.c | 16 ++++++++++++++++ kernel/sched/sched.h | 21 +++++++++++++++++++++ kernel/sched/topology.c | 10 ++++++---- 4 files changed, 47 insertions(+), 7 deletions(-) -- 2.37.0