Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4378f2ba-f620-b4e8-f0b3-9d08dcb6e2f3@gmail.com>
Date:   Wed, 10 May 2023 10:52:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v1] backlight: lm3630a: turn off both led strings when
 display is blank
Content-Language: en-US
To:     Sam Ravnborg <sam@ravnborg.org>,
        Maximilian Weigand <mweigand2017@gmail.com>
Cc:     Lee Jones <lee@kernel.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        Helge Deller <deller@gmx.de>,
        Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org
References: <20230505185752.969476-1-mweigand2017@gmail.com>
 <20230509165232.GA1072872@ravnborg.org>
From:   Maximilian Weigand <mweigand2017@gmail.com>
In-Reply-To: <20230509165232.GA1072872@ravnborg.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


>> +	if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))
> You could replace bl->props.brightness with backlight_get_brightness(bl)
> to avoid direct access to the properties.

Thanks. Changed in v2.

>> +		/* turn the string off  */
>>  		ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);
>>  	else
>>  		ret |= lm3630a_update(pchip, REG_CTRL,
>> @@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
>>  	usleep_range(1000, 2000);
>>  	/* minimum brightness is 0x04 */
>>  	ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);
>> -	if (bl->props.brightness < 0x4)
>> +
>> +	if (backlight_is_blank(bl) || (bl->props.brightness < 0x4))

Thanks. Changed in v2.