Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230510084713.3528908-1-rick.wertenbroek@gmail.com>
In-Reply-To: <20230510084713.3528908-1-rick.wertenbroek@gmail.com>
From:   Rick Wertenbroek <rick.wertenbroek@gmail.com>
Date:   Wed, 10 May 2023 11:02:40 +0200
Message-ID: <CAAEEuhoTeOe34w2DfrJNT3Zdq5Ej++KtavKfwwgqWyXqk0m_4g@mail.gmail.com>
Subject: Re: [PATCH] mm: memory_hotplug: Fix format string in __add_pages warning
To:     rick.wertenbroek@heig-vd.ch
Cc:     David Hildenbrand <david@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 10:47=E2=80=AFAM Rick Wertenbroek
<rick.wertenbroek@gmail.com> wrote:
>
> The format string has a typo and prints e.g.,
> "Misaligned __add_pages start: 0xfc605 end: #fc609" instead
> of "Misaligned __add_pages start: 0xfc605 end: 0xfc609"
> Fix "#%lx" =3D> "%#lx"
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>

The issue appears in the __remove_pages format string as well,
sorry didn't notice that right away. I'll send a new patch.

Rick
> ---
>  mm/memory_hotplug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 8e0fa209d533..446abb088b51 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -325,7 +325,7 @@ int __ref __add_pages(int nid, unsigned long pfn, uns=
igned long nr_pages,
>         }
>
>         if (check_pfn_span(pfn, nr_pages)) {
> -               WARN(1, "Misaligned %s start: %#lx end: #%lx\n", __func__=
, pfn, pfn + nr_pages - 1);
> +               WARN(1, "Misaligned %s start: %#lx end: %#lx\n", __func__=
, pfn, pfn + nr_pages - 1);
>                 return -EINVAL;
>         }
>
> --
> 2.25.1
>