Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7011247rwr; Wed, 10 May 2023 02:32:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ635PLvF7j0/kss5tUECWMaPdgURir5HWek2EGRt/5UZsUmqCqEQ/cmu5owu1nGisEiDxR8 X-Received: by 2002:a05:6a20:938f:b0:102:a593:a17c with SMTP id x15-20020a056a20938f00b00102a593a17cmr1741848pzh.0.1683711145777; Wed, 10 May 2023 02:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683711145; cv=none; d=google.com; s=arc-20160816; b=MmwyDlbc/PDn+JOZ6ST/EEGgdtiyE1IsSk/XrzOxReAL8r1RhWNIAx7rTxinr4Om6w sYUaA9J/gPQSvxRuokEnFDyFx4l4xLjMVKk0bv58j0A+RxCghGDwOYR0HeWWGicsOddm 1LUxRBQ9RH0tPcxNjMfzGuSmdkeQSRA1BN/el0/lX3Kt3w1jLU2y5qGlWNsjf13ZBf0W SsAaBpK4ptEUe9GDbOMKtRIEjYy53UVNjjUovYWsiqX7t0ggEjKiKpgRs8GVGUChRvwf w5PRO174lsMEuRqCUJRc5qb1Wal9MClTD7jjnP7aTSFKP2yU/rDxLzikaHBx/EVvevhu hNCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Sa2pMLZS86n9O3EA5nbeZV1SzabxblnSiSLxM+zq2SM=; b=RWGL3huiaSXg48R2C/HkQ7QabbXNoTY2qSGWSBw1kECM1C+BATP/1uFW8znB8+VYQr Z+jkXo/mN6ljo6+ErzfKvHpPAa5lU3L9gTkG4F1IIALfAmD4MQD360F4hiGRyLjbfWz7 gBJN2VAL/6ZPPUE67eedFK0i+JKb5jGBq8VU+91x1urXCBTAwqpJG4Le6erJNNHReRQu OxPk5bBdZ1DCQRmvWAtpbemRrkXNbcwYkQE6p76OSOnPywXLH3rD+Oguom26kl2teR0j 3naeKdiULfFsudOHIToXTqwG6ANCiRabLsMsViY55RKQ6J/fqfmQMV9wXY2XBnxRpXqq TqdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YlY4NYDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a63b141000000b00502f4fd0c16si3725794pgp.653.2023.05.10.02.32.12; Wed, 10 May 2023 02:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YlY4NYDr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236733AbjEJJY2 (ORCPT + 99 others); Wed, 10 May 2023 05:24:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236902AbjEJJXz (ORCPT ); Wed, 10 May 2023 05:23:55 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF53D76A6; Wed, 10 May 2023 02:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683710616; x=1715246616; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Sa2pMLZS86n9O3EA5nbeZV1SzabxblnSiSLxM+zq2SM=; b=YlY4NYDrMt3RJIQi6WU2bZufxufU7lz8DiUWj/dDaGK+KMsLSW8kw0yu 9fd3ZyT2SfcfcbGYRZAHYBYk243fgqWM7J/+4H2E4V2FSl84K9CTr3AC2 yvlQezcp4yDwByi9EyNhjmYZMNlPyYms9dHbSwOZ6R9bkPVZrLl/EZwoO wkMNP4fvn6OoCsSF3dBnO3z9/IpxU701UQhBrW1jIPn77uB/yf+C/KlYO qyI4jfyrR/ORjQnLngHb8PfQXWSq0mZFD7RcG8tgVbgmPCvy8skA/CtLi RlNFjECef6fTrDR54MIsaF4cqluLQWMFFE/rXt7tS1DC2Z1Tt7Mk7Y/uq A==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="330534280" X-IronPort-AV: E=Sophos;i="5.99,264,1677571200"; d="scan'208";a="330534280" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2023 02:23:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="823487961" X-IronPort-AV: E=Sophos;i="5.99,264,1677571200"; d="scan'208";a="823487961" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga004.jf.intel.com with ESMTP; 10 May 2023 02:23:34 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 57ACB23E; Wed, 10 May 2023 12:23:44 +0300 (EEST) Date: Wed, 10 May 2023 12:23:44 +0300 From: Mika Westerberg To: wangyouwan Cc: jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com, jsd@semihalf.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] i2c: fix crash with msgs is NULL points Message-ID: <20230510092344.GP66750@black.fi.intel.com> References: <20230510084057.17313-1-wangyouwan@126.com> <20230510090241.GO66750@black.fi.intel.com> <1943ca04.6ce1.18804f327f0.Coremail.wangyouwan@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1943ca04.6ce1.18804f327f0.Coremail.wangyouwan@126.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2023 at 05:17:04PM +0800, wangyouwan wrote: > After waking up from sleep, 100% of the time it occurred. I suspected > that there was a firmware issue with the machine I was debugging, but > other machines did not notice it. Therefore, I attempted to make a > modification here to avoid it Okay then I suggest to investigate what causes the ->msgs to be NULL and fix that. When the transfer function is called we expect there to be something to be sent out so this should not happen.