Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 11:42:15 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Colin Foster <colin.foster@in-advantage.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        UNGLinuxDriver@microchip.com,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>
Subject: Re: [PATCH net v1] net: mscc: ocelot: fix stat counter register
 values
Message-ID: <ZFtm91360rfOtBR1@corigine.com>
References: <20230510044851.2015263-1-colin.foster@in-advantage.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230510044851.2015263-1-colin.foster@in-advantage.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HL+YpOn7gmY4IGtd7onk+MyiGwnrh0Oe9SnSVp0DQyts/vwXoU2M5f3Mv/Lu?=
 =?us-ascii?Q?p6WXJpMKTUVl01+il13dUfeNJAMFHoNNUdOSlYqu6CPJvzZzH7YyGbNTyWwz?=
 =?us-ascii?Q?6JHKYRwfa2T8KdC+s1PiiYzdVTiJ5KHf7yGp+9HIQY2J7h3363sTQ1zBDOF2?=
 =?us-ascii?Q?XJGPqloHNa6aWZJwB667lf8UxFJYJls6THgq/j24Z4lNm5TrUbQH7onl7IVj?=
 =?us-ascii?Q?9t6z8nXvjIl55FTQV7P2YtIeJz+/d7oszQKkPJfkIk17TJ0ofFjI8FpUUiPP?=
 =?us-ascii?Q?ndv1QdcaKwsMMkpvPar2ZmtH7DGYqN3DWt0HnGLXpw4oLfWY89y/xs8gR0sv?=
 =?us-ascii?Q?8mVP9mpv55VMPEk6YM+ir9Qn9abWdUAWoBmLe6bWJ9tRsgFV1anAzUV1jQHt?=
 =?us-ascii?Q?2ZeOv/HiRfzl3W8DlK5fhQj6tU+feB9V1rZLiNSSDmFY5gAloqnvOmNPfXAD?=
 =?us-ascii?Q?gBssmFqg02vuUh7Wh7EEoMuefbvWqNF0cf8fTSaeS6Fob5BWBBo9/z54muH4?=
 =?us-ascii?Q?z/epALpLW+1zYFXOtcJ3TSiOzbSdMjrDmESOxltZjVzU7O1Mn29tZLkqRYEL?=
 =?us-ascii?Q?Os+pDdZTlXN+eTRuWBULP8aZBNrpbXvSxH9DI4zdK7pCGZO40o3gM0BWcnEg?=
 =?us-ascii?Q?gZLLkr5I3p55QFO9WOjoyeCeCBy9KmmIiUsLPjdq5USqIomzoSltHNl16KcR?=
 =?us-ascii?Q?OQ2dAnkbf6sHt8I7bMXcxojCxPx+6u0AF5d1tEZFV1aIeCX1HzmtJG07o3tE?=
 =?us-ascii?Q?JxO6lf32yxGAh1r1MnDOLspwhz0p6QSlYw3kZIjzaj2IAetVv4qHob+ZzUY5?=
 =?us-ascii?Q?NSO3bpqcnURtT0+e+XO3OoNF88cOydFkr1o9ejI8CrZHuVb3QU4CXXrt3Z99?=
 =?us-ascii?Q?pLX8Z2Sn3EXj9YcU7HJqL5lgF0qZQzcYupYK4dg99UCdu05jriQBvZH4k+Vs?=
 =?us-ascii?Q?CNzEZPS1he2ErD8EUy/VyopADkJVD9Qmu5ba9wtj7ePABca0t/LuM+wexmZ8?=
 =?us-ascii?Q?XPosTkCqZTlPy4k/t0H+egxJlSFhzlcZ3x/gqI4uEf0oBjlVzHeb7p5pyTv3?=
 =?us-ascii?Q?fvlBgb+nUuSqQR93LroqMoSk0FGXitxtMTTavDHMpKSPmNH2O2V13PRqzqzT?=
 =?us-ascii?Q?pCGSoKwougfsTXS5mDcLIqOx7+lY3gXWI1dMnNPSWyliAqWjtI1ZnMzaG5Xc?=
 =?us-ascii?Q?VETEEtuX6jPQ460+J07LY29eb2xbjEcBlS+k2JKr+iS0IwqxXGFBZCstxuB2?=
 =?us-ascii?Q?P7B9tLrDt1XD78r0nDT6/LVcHGnXz5DEePm5ki9QjLbQ3tzMvr69PbzOLf0s?=
 =?us-ascii?Q?rJH5k1diI+4w4Db/Bmjo3g7WipdJMSBTtug6ZJtSqgQsJD5U5fkkQL5E+zAi?=
 =?us-ascii?Q?CNFXPVn842x9BzUwnG1zQbsAHB02sZ86YUAwRbpN/G5Qmx9ne+o6W5ivaheB?=
 =?us-ascii?Q?8OS2ua+ZVnI0xLcAbEWSg6xfGafbhxJlFpQRHnvUcBg+tiGOqZ3rTR9snjON?=
 =?us-ascii?Q?9LHd+oFDRDUanSK2W6fKO1ecFPXiKC2RQSgZ0Kyi3lq1AP47k5e8NceoRMyi?=
 =?us-ascii?Q?lq1IGVa7HivQsxGOlMWPbXuRLalvnJ2fn2RREakuJ/4lwF81TPFt3BoQBb2y?=
 =?us-ascii?Q?5zmsw9v+qDyv8H1Se5tqVhtiJ71OyMc2noouEd2mV4NcklEzj20DhyKNPu7W?=
 =?us-ascii?Q?fng5nA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b11e4abf-c1e5-49f9-453b-08db513adb8e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 09:42:23.8544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4oqCmsbP+g19yLcNOlJ8k7jiMEOf/Bh10wHhYFHU0u0hDuTaSoR/zfZdNLPAujMrWqOoiUBI+TGhF1k5WUZIZyIiNuZpn9liY0SL1c7Elos=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5417
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2023 at 09:48:51PM -0700, Colin Foster wrote:
> Commit d4c367650704 ("net: mscc: ocelot: keep ocelot_stat_layout by reg
> address, not offset") organized the stats counters for Ocelot chips, namely
> the VSC7512 and VSC7514. A few of the counter offsets were incorrect, and
> were caught by this warning:
> 
> WARNING: CPU: 0 PID: 24 at drivers/net/ethernet/mscc/ocelot_stats.c:909
> ocelot_stats_init+0x1fc/0x2d8
> reg 0x5000078 had address 0x220 but reg 0x5000079 has address 0x214,
> bulking broken!
> 
> Fix these register offsets.
> 
> Fixes: d4c367650704 ("net: mscc: ocelot: keep ocelot_stat_layout by reg address, not offset")
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>