Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 12:22:11 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Yan Wang <rk.code@outlook.com>
Cc:     andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux@armlinux.org.uk
Subject: Re: [PATCH v3] net: mdiobus: Add a function to deassert reset
Message-ID: <ZFtwU1svXhZ/xrnJ@corigine.com>
References: <KL1PR01MB5448A33A549CDAD7D68945B9E6779@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <KL1PR01MB5448A33A549CDAD7D68945B9E6779@KL1PR01MB5448.apcprd01.prod.exchangelabs.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4tuqAH0T5gM6LK09fgbqsOShmobuq7TdvC3WwhiWnB+aeqHMODd0xWTg2r7v?=
 =?us-ascii?Q?7fWqnZTNjcGwFR1VHZwfe0u/MQOvS/08RXyyML4OzH1v6vgvGk/SutFC5H7u?=
 =?us-ascii?Q?sXuWcoDet9nerZ5vByh8hq3fOT51onMrpBA0VbC2xJXmnQp0BvjINcrzzWQs?=
 =?us-ascii?Q?s6yU2ovDA5yl6fEB7FJIIVqpU96B/pyEvmetcUzZsTmsImsu2rWjFiquGcAj?=
 =?us-ascii?Q?Olhtsw9yEgkBraGFVhoBBzeb4Iy5G3rKWD6cBaL7qAD1tyEyNumxUYFLDVp2?=
 =?us-ascii?Q?8JwMrUv+XesPfylgSakkmzmS1EeAQ/GA2ZQMRTtKXq/4cXNPAFwACQIx66ty?=
 =?us-ascii?Q?s5xGyYE5Jce2iQAELVbbBbXZfmVCCwNg9o9GNoCJB8jrR5Ka6AXvHK6pgYUS?=
 =?us-ascii?Q?E06Fi/LnHe7j6SX/RgqXDRCUTZ+FZPoWDZEgzAA6ToLk/NkgaLFAyQ0k+aP/?=
 =?us-ascii?Q?/hhVLz7ErGkugNjg2OzjVY4u9PafAO1DOR7N1GqKAWO/WKNK5S7hoJj8hnDd?=
 =?us-ascii?Q?QAzEk0kojPYEkx/BQIj8CC7+Jbi58qnmEq50BBd4egE86daCDIzioCZOEnux?=
 =?us-ascii?Q?0KSkniJWR+vBd1ZhaefC59gipSUIY+c92HZvbasSI2LpKFOO5jqhar+Cik8E?=
 =?us-ascii?Q?0Hcfv42EVdTUNj+4H7AJ0Jm4BCHdoMw+4PruPpY6sF6APGZRIzujrjiT211v?=
 =?us-ascii?Q?pLG/q7/S/TeQco6EdJe27r1guCdF7DYzD0PpwIW9qpxPZJx8suLsFeuD7699?=
 =?us-ascii?Q?RbvdYmvzsOP1tZphiZpTIxT0bwgB991ndZfJk2RcS+CzOR/10xrOyXknKKvk?=
 =?us-ascii?Q?CVRTTAGL7l+4vfD//buMFqbhKZ6Jphj8854G7w6rfzonmL5LsgmDeqwztobd?=
 =?us-ascii?Q?4xT9vBy2lQFBhC32s44bHWlmapWtFf8ibRqu8n3Wak9Oi7SUOCnm8aW29zrN?=
 =?us-ascii?Q?jo/0H+fJ7/8i36J04gEEq3FWgLx0tgkRwHKQZduXXThPzswaWdPkoOTpd/GE?=
 =?us-ascii?Q?1EJ09KESW3Q0Dxt0gPn9+5i/gdcdMViP14F0xvYOljSeBUCXrNW2jE3OWWBU?=
 =?us-ascii?Q?TZSizNIK8GlE6RvPi4zvqSP1znCfj2DYZjY5UOBXXGtYDyr1QSyoad4jTujn?=
 =?us-ascii?Q?JzIb+OlWe3XppPVZp6d85Y0N8xnsPrmUx8DesSQ9C70vuCxheZxxJGVD+3lI?=
 =?us-ascii?Q?mNsG9Uz+fwGwyMW16iQcSOQhSUNuqhfdrmAdGWX3teKK0QhRH+7IZu/MnLTG?=
 =?us-ascii?Q?1wIkKSV3IwIAg4t+gIqpZt98H5SO5gWvrwkKlAaZk0LitRz+d47rQg9Fso4h?=
 =?us-ascii?Q?Q3e50qVR+tME2dLP+joRMWp9oT67xLt0mZiBujiaDm7uLkSNLs1n5lMoc0qB?=
 =?us-ascii?Q?RcfLcuPAIkeffxU99DiLxx8Zd0vxUw6f2Sz7oUBeA0s8IenG/sD2gqbRgJ+q?=
 =?us-ascii?Q?drlxuAWC573nwfCNJQgo/BEOBloulNOcn3GdQuHom8Ir6Y8jtzXol1IxRdcW?=
 =?us-ascii?Q?w7GGyk6SaYDY0jOtQJJ3ig0ytOdU5O59/eMYlTrtmWAu35Gs0jiyg+LzKPGr?=
 =?us-ascii?Q?DACF/wa6S8gmFqldexrlJHl7VEpWeOj2e0aX3zd5KvkumHsAt97vlJ9DmKIL?=
 =?us-ascii?Q?afvKeiX2BXZ2XVPg6rlK5TPUgF8SUfuYBslV7xvQGsj8YeEuk0XYuUD6Q2un?=
 =?us-ascii?Q?Zk2WuA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 095af2d9-b877-48f2-0901-08db51406e83
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 10:22:17.8556
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: chM+Okh51OpzWy8goEwzsmRKzHP3DobXociyzwBExV+Nj7xWwE4/Pb1pP7QAtAYJPkvOlUPAEpZlDgsu9wvC8IJ9VUjI/bDHN2ifmBymM1I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR13MB5629
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 10, 2023 at 04:15:22PM +0800, Yan Wang wrote:
> It is possible to mount multiple sub-devices on the mido bus.
> The hardware power-on does not necessarily reset these devices.
> The device may be in an uncertain state, causing the device's ID
> to not be scanned.
> 
> So, before adding a reset to the scan, make sure the device is in
> normal working mode.
> 
> I found that the subsequent drive registers the reset pin into the
> structure of the sub-device to prevent conflicts, so release the
> reset pin.
> 
> Signed-off-by: Yan Wang <rk.code@outlook.com>
> ---
> v3:
>   - fixed commit message
> v2: https://lore.kernel.org/all/KL1PR01MB54482416A8BE0D80EA27223CE6779@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/
>   - fixed commit message
>   - Using gpiod_ replace gpio_
> v1: https://lore.kernel.org/all/KL1PR01MB5448631F2D6F71021602117FE6769@KL1PR01MB5448.apcprd01.prod.exchangelabs.com/
>   - Incorrect description of commit message.
>   - The gpio-api too old
> ---
>  drivers/net/mdio/fwnode_mdio.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
> index 1183ef5e203e..6695848b8ef2 100644
> --- a/drivers/net/mdio/fwnode_mdio.c
> +++ b/drivers/net/mdio/fwnode_mdio.c
> @@ -57,6 +57,20 @@ fwnode_find_mii_timestamper(struct fwnode_handle *fwnode)
>  	return register_mii_timestamper(arg.np, arg.args[0]);
>  }
>  
> +static void fwnode_mdiobus_pre_enable_phy(struct fwnode_handle *fwnode)
> +{
> +	struct gpio_desc *reset;
> +
> +	reset = fwnode_gpiod_get_index(fwnode, "reset", 0, GPIOD_OUT_HIGH, NULL);

Hi Yan,

As this calls fwnode_gpiod_get_index()
do you need to include linux/gpio/consumer.h ?

> +	if (IS_ERR(reset) && PTR_ERR(reset) != -EPROBE_DEFER)
> +		return;
> +
> +	usleep_range(100, 200);
> +	gpiod_set_value_cansleep(reset, 0);
> +	/*Release the reset pin,it needs to be registered with the PHY.*/
> +	gpiod_put(reset);
> +}
> +

...