Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 12:29:43 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Subbaraya Sundeep <sbhatta@marvell.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, saeedm@nvidia.com, tariqt@nvidia.com,
        roid@nvidia.com, leon@kernel.org, maxtram95@gmail.com,
        kliteyn@nvidia.com, irusskikh@marvell.com, liorna@nvidia.com,
        ehakim@nvidia.com, dbogdanov@marvell.com, sd@queasysnail.net,
        sgoutham@marvell.com, gakula@marvell.com, naveenm@marvell.com,
        hkelam@marvell.com, lcherian@marvell.com
Subject: Re: [net-next PATCH] macsec: Use helper macsec_netdev_priv for
 offload drivers
Message-ID: <ZFtyF3SqLCQleCZy@corigine.com>
References: <1683707289-2854-1-git-send-email-sbhatta@marvell.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1683707289-2854-1-git-send-email-sbhatta@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N84QaWg8nLlYcFrZ5yLYZNDZX6tZjzEkPkiCgdHbtVncd/z/hqK4IyxfjwsI?=
 =?us-ascii?Q?E+bs3EEseM9ODy35iQG13c3nWwxq/to1sS1wQzilX1QHkDG6GCVp2g/I7yUy?=
 =?us-ascii?Q?uTg+59unFF9XD3X8ut2PGxd6mBdlnkI8LAZPtK8z3Rb33cmYNLtSUtlLnych?=
 =?us-ascii?Q?DGCluXzfP9/E8z1bgZRCl7xj0lDXmHjoYttavrPYjjRMB+lyysC6ZXdkUuaj?=
 =?us-ascii?Q?mSeqwtLTyAmEiYT7JeQZwzlAnOd1r9w0Ux8hCQWc0jpZABRUqQjRzSOKZtRt?=
 =?us-ascii?Q?iX9IsRZycHpxabOSOi98pWhmC2OaG3LWGZisUqTcXPWwifGPLmjcwJeNCx/B?=
 =?us-ascii?Q?LNIm5IymTkS8Aedm5zg5yBZK5vDtPUC/2tglQ44VOn61AiEsjXAb8m/QYzvW?=
 =?us-ascii?Q?GxihhLTvtMUrRI9EKeraAKEmInMa/rJyJFy2qTfPFBty5uAVn8yiJUVZk3mf?=
 =?us-ascii?Q?TrFWcb6NP/LryKpoWvhVCP9BJk2NJMlpo/91eV/AA3qmdLU1eCP1qCfZiF4A?=
 =?us-ascii?Q?s/EBmf2cVx9brPbRqxNvPnys8KMEIoXVX4FlfKIVWwC108JRbsUs1PAtlhML?=
 =?us-ascii?Q?bBGUuJHA3dNPlduBx5xsy3SVgjzIh5jvUCBAhpIogpVQwo79N+NlIIbNMgoK?=
 =?us-ascii?Q?LpsWAT6aD81EB4SLrC+wSy8O6/LfxQdjGWsEdbyRlq62P2YXYtnvjJsm/7jJ?=
 =?us-ascii?Q?4GhU12yWoi/dr03dZeJBAU62zcMcwnkiagRpa7wkyQm0wGdmBAcBq8/BZ//s?=
 =?us-ascii?Q?6wDUAwULgNnw2zS+XDGko9LNus1nMJJcWd5KeSRA2qHWtcrVdqhzAGJq59og?=
 =?us-ascii?Q?DTIq6XFFRXTC6piB/y2ivjRCKkawrqMhoIhseGy6kByre1U9PdI1WJCqGYM1?=
 =?us-ascii?Q?fKj9g6tozFrYpeHIpfNkvhG4tiSZiL3c008aa650ut3/Vx4x/HV1pTg+Mnfm?=
 =?us-ascii?Q?pJLsHSmlu9Ep1Fvq+R+9e5RZd1TUzimX8lgLBsCfBrdxJUWDugmO2tzJxbgs?=
 =?us-ascii?Q?19ht2HY4n1nnOIO6XGeB97rqIb3HVcRXBSVRWQpIPZSfuX01QKjs/tKsLLNv?=
 =?us-ascii?Q?94GTlO3KKU3pJKAlY+KQ3soL0aDwF+lhAhiWPpc72/v6EjN2K2rOUDiwf/B9?=
 =?us-ascii?Q?4G5AI3jpKGVXsXcUp0exnca+NcyPyHzgqddB49D0YACTJzTDRh10XQXgPSEM?=
 =?us-ascii?Q?/rOk9J08K3mhgAC9MaHO0vdcXhDL8uBr8s6GiYesBPZLy//sTULlmmOHC6q5?=
 =?us-ascii?Q?r3DzQP0n/3pkqydcJHpegAP7OgeWS2EmCsndXiLz65NCOyS72M8oXodK0D1T?=
 =?us-ascii?Q?g+Tl2y4EqF+qMecVTgUJV/V6JTXZEhzqCmRhc6zbZDSwkyMyZltTD32AiXq9?=
 =?us-ascii?Q?v7Bsv8TrIUKY4fuYDl3R/2RkckDzmapdTYXfPVR0aGPR3UW/PBOwphvMhEnW?=
 =?us-ascii?Q?OoU/g5kTr+KnsXLJ9XOWMfno/ZxVsqvPXhMUdVP9UheKjTyv8DDWoliBbA+4?=
 =?us-ascii?Q?GyYHjzuWPs+AsM1oKMW+VD/aKpQYBYdBq09PINxTumXMUraZY6+WO2jFChbO?=
 =?us-ascii?Q?KujCS1pg0dIh0flejHL8nIaMu/QRV2kBvtZgxcf/YEuXcaMw0UwiOt5dtA9w?=
 =?us-ascii?Q?4+7Sal9c7nx+hRqhNCLW3L8JHuJneFyh8ZnF7Wof6gJKzWeliffWNhOWJVmp?=
 =?us-ascii?Q?DhpcHg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46106809-d2d1-4eea-9bcc-08db51417d18
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 10:29:51.8571
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zBU0Fkaayqo/gB6NKQN4M9iGId/h0ZNRMG8Wzv9ykNpGsm89J7qCV/tVPrzIgWipTtS3+NiWCRmy9MsDDXyIotLWZog7xgqErTWSUF8ViZo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5550
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 10, 2023 at 01:58:09PM +0530, Subbaraya Sundeep wrote:
> Now macsec on top of vlan can be offloaded to macsec offloading
> devices so that VLAN tag is sent in clear text on wire i.e,
> packet structure is DMAC|SMAC|VLAN|SECTAG. Offloading devices can
> simply enable NETIF_F_HW_MACSEC feature in netdev->vlan_features for
> this to work. But the logic in offloading drivers to retrieve the
> private structure from netdev needs to be changed to check whether
> the netdev received is real device or a vlan device and get private
> structure accordingly. This patch changes the offloading drivers to
> use helper macsec_netdev_priv instead of netdev_priv.
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>