Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4cb758c7-f4f5-820c-c7e7-5b900ccc2534@kernel.org>
Date:   Wed, 10 May 2023 13:00:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Content-Language: en-US
To:     Masahiro Yamada <masahiroy@kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Cc:     andreas.noever@gmail.com, michael.jamet@intel.com,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        YehezkelShB@gmail.com, USB list <linux-usb@vger.kernel.org>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
From:   Jiri Slaby <jirislaby@kernel.org>
Subject: make localmodconfig doesn't work for thunderbolt
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

if I use localmodconfig for example like this:
mkdir /tmp/tb/
echo thunderbolt >/tmp/tb/lsmod
make O=/tmp/tb LSMOD=/tmp/tb/lsmod localmodconfig

I get:
using config: '.config'
thunderbolt config not found!!

$ grep 'USB4\>' /tmp/tb/.config
# CONFIG_USB4 is not set

I believe it's due to:
   obj-${CONFIG_USB4} := thunderbolt.o
in drivers/thunderbolt/Makefile. I.e. ${} used instead of more common $().

But even if I change the parser:

--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -317,7 +317,7 @@ foreach my $makefile (@makefiles) {
         $_ = convert_vars($_, %make_vars);

         # collect objects after obj-$(CONFIG_FOO_BAR)
-       if (/obj-\$\((CONFIG_[^\)]*)\)\s*[+:]?=\s*(.*)/) {
+       if (/obj-\$[({](CONFIG_[^})]*)[)}]\s*[+:]?=\s*(.*)/) {
             $var = $1;
             $objs = $2;


I see:
module thunderbolt did not have configs CONFIG_USB4

and:
$ grep 'USB4\>' /tmp/tb/.config
# CONFIG_USB4 is not set

So two questions:
1) is ${} supported and should be the above change sent as a patch? Or 
should be drivers/thunderbolt/Makefile fixed to use $(). (And maybe 
other Makefiles too.)

2) how to fix that 'thunderbolt did not have configs'?

thanks,
-- 
js
suse labs