Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7211941rwr; Wed, 10 May 2023 05:34:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6FHvjmPYDhygdQ1joKnmzDvvj90ESDW7dMG59AHXFhcql2HQ00ykEDIwe7d+82D90Fzw7o X-Received: by 2002:a17:903:187:b0:1a9:433e:41d5 with SMTP id z7-20020a170903018700b001a9433e41d5mr22004412plg.56.1683722093459; Wed, 10 May 2023 05:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683722093; cv=none; d=google.com; s=arc-20160816; b=PRFhUDIpfLNrD7Zcu0vMMO9xcC5RmsqeGue7au/xEsGdNCynQvWbi22RvFpgCmsPKz X8/B9DWbU+lJdrTkho9x2h/6Ujg1YpHc/51vL1KScnLKFsGO4yOWMyAd7D0ZJskojgbz 0XhkmDZtIfde/mrbO5DAkLLvDJBecDqw5KJbUGsoXD1b7Hunz8Z/po0RJzfO4wChDwaH DGtwiiz7w6Lp2iDHwa5+8ou4sozyJdyNrzXh/sSrJ0bEgWmOC/zIkFW0qkKnyaZtkX7L Fv136SEA/gi3DyR7rq8vCLi2qqDl7Zc0Qh1nYBj9+0oNWTQuPXvDNkGmlptzKCvzbcHo GUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=G3T57yHsK+Ldw+osZ3of3JF0Uc5zm+fdQ05Fc4Z+g+Q=; b=bhsL/FPNqt3ZYDYySIoAa8CH9/+twBcAon8mwtKKGSfs5d2IkFOeY+Y4etFkpE+0G4 OF0RrJaUeKmLBOu1OlJwrGme+Yah2Qy/fVzhBos/o4blhNuFFv7TmNmHadAlkOrCaFJf jI1lRu0nGqq4lr2jEP/Q1KnB9r0KN0ct01aBJMtwgUxbF27gK6l66aULMo6FdJwB/qur n0FdexEkU9oDzPQXuWHxabN1ci4UGPYY4FlcMfxBs6TIgkamhde3fGbmDxy1QwGVY1GC 5O1Nzoc1bGbB7znyOJcWambUDS9AtmDkLlprTiTvkYncDPUHLmBl7hudKYvIKTcdGF/v LIAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ElzJiAnf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x4-20020a170902b40400b001a6ade4c8c2si3759450plr.142.2023.05.10.05.34.38; Wed, 10 May 2023 05:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=ElzJiAnf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236926AbjEJMQM (ORCPT + 99 others); Wed, 10 May 2023 08:16:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236366AbjEJMQL (ORCPT ); Wed, 10 May 2023 08:16:11 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A37DF7D85; Wed, 10 May 2023 05:16:08 -0700 (PDT) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34ABWnju020035; Wed, 10 May 2023 12:16:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=G3T57yHsK+Ldw+osZ3of3JF0Uc5zm+fdQ05Fc4Z+g+Q=; b=ElzJiAnfCnESM/Wh8jz91+bjp+dn0QOYkAaEcNcF+0F/GG01Xv/mzdzjvqgAnn36//HO 4NoNeNloX+65F7Rccd+P3n89alH5cKRy/u8L13vZ5TlAo/w+tWeKvMbi4DaY5kaFr8p0 ReJXrvBVLb03jt29Gl79I6OYblhLL20BeEsGcf0UYh+/v3xRIE12tUr0JIRZtTvPyMVz jf6CqlAhcKwrqlwu3sGUrjpI4eexuq4Ig/E/kO3tenv8CsSCRGHhvTiJpqxEH3bIDgye Vi21Dny7jxSUv1X66H+M6JsHYOHIGLLeQOefgt5S/KU4gc3zh81L68t9xl4OxWN5XgjU JQ== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3qfruta2w2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 May 2023 12:16:03 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 34ACG24b018967 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 May 2023 12:16:02 GMT Received: from [10.214.66.58] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.42; Wed, 10 May 2023 05:15:57 -0700 Message-ID: Date: Wed, 10 May 2023 17:45:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v6 0/4] Add pinctrl support for SDX75 Content-Language: en-US To: , , , , , , , , , Mukesh Ojha CC: , , , , References: <1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com> From: Rohit Agarwal In-Reply-To: <1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: QiqRx-tcUuWKf8IOEz2yko6MXCbzTtmy X-Proofpoint-ORIG-GUID: QiqRx-tcUuWKf8IOEz2yko6MXCbzTtmy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-10_04,2023-05-05_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=966 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305100096 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/10/2023 5:08 PM, Rohit Agarwal wrote: > Hi, > > Changes in v6: > - Refactoring as per suggestions from Andy to remove msm_function and > reusing the pinfunction and pingroup struct with macros as well. Patch 2/4 didnt go through in the mailing list linux-arm-msm because of char length. BOUNCE linux-arm-msm@vger.kernel.org: Message too long (>100000 chars) Here is the link for it. https://lore.kernel.org/all/1683718725-14869-3-git-send-email-quic_rohiagar@quicinc.com/ Please suggest if this patch needs to be broken down. Thanks, Rohit. > Changes in v5: > - Refactor the pinctrl target files based on the new macro and > structure defined as suggested by Andy. > > Changes in v4: > - Fixed the bindings check and rebased on linux-next. > > Changes in v3: > - Rebased the bindings on linux-next as suggested by Krzysztof. > > Changes in v2: > - Updated the bindings to clear the bindings check. > > This patch series adds pinctrl bindings and tlmm support for SDX75. > > Thanks, > Rohit. > > Rohit Agarwal (4): > dt-bindings: pinctrl: qcom: Add SDX75 pinctrl devicetree compatible > pinctrl: qcom: Remove the msm_function struct > pinctrl: qcom: Refactor generic qcom pinctrl driver > pinctrl: qcom: Add SDX75 pincontrol driver > > .../bindings/pinctrl/qcom,sdx75-tlmm.yaml | 169 +++ > drivers/pinctrl/qcom/Kconfig | 30 +- > drivers/pinctrl/qcom/Makefile | 3 +- > drivers/pinctrl/qcom/pinctrl-apq8064.c | 104 +- > drivers/pinctrl/qcom/pinctrl-apq8084.c | 264 ++-- > drivers/pinctrl/qcom/pinctrl-ipq4019.c | 104 +- > drivers/pinctrl/qcom/pinctrl-ipq5332.c | 206 ++- > drivers/pinctrl/qcom/pinctrl-ipq6018.c | 260 ++-- > drivers/pinctrl/qcom/pinctrl-ipq8064.c | 114 +- > drivers/pinctrl/qcom/pinctrl-ipq8074.c | 240 ++- > drivers/pinctrl/qcom/pinctrl-mdm9607.c | 276 ++-- > drivers/pinctrl/qcom/pinctrl-mdm9615.c | 90 +- > drivers/pinctrl/qcom/pinctrl-msm.c | 13 +- > drivers/pinctrl/qcom/pinctrl-msm.h | 42 +- > drivers/pinctrl/qcom/pinctrl-msm8226.c | 156 +- > drivers/pinctrl/qcom/pinctrl-msm8660.c | 252 ++- > drivers/pinctrl/qcom/pinctrl-msm8909.c | 268 ++-- > drivers/pinctrl/qcom/pinctrl-msm8916.c | 556 ++++--- > drivers/pinctrl/qcom/pinctrl-msm8953.c | 424 +++--- > drivers/pinctrl/qcom/pinctrl-msm8960.c | 464 +++--- > drivers/pinctrl/qcom/pinctrl-msm8976.c | 212 ++- > drivers/pinctrl/qcom/pinctrl-msm8994.c | 564 ++++--- > drivers/pinctrl/qcom/pinctrl-msm8996.c | 508 +++---- > drivers/pinctrl/qcom/pinctrl-msm8998.c | 380 +++-- > drivers/pinctrl/qcom/pinctrl-msm8x74.c | 474 +++--- > drivers/pinctrl/qcom/pinctrl-qcm2290.c | 230 ++- > drivers/pinctrl/qcom/pinctrl-qcs404.c | 388 +++-- > drivers/pinctrl/qcom/pinctrl-qdf2xxx.c | 6 +- > drivers/pinctrl/qcom/pinctrl-qdu1000.c | 249 ++- > drivers/pinctrl/qcom/pinctrl-sa8775p.c | 308 ++-- > drivers/pinctrl/qcom/pinctrl-sc7180.c | 254 ++-- > drivers/pinctrl/qcom/pinctrl-sc7280.c | 322 ++-- > drivers/pinctrl/qcom/pinctrl-sc8180x.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sc8280xp.c | 358 +++-- > drivers/pinctrl/qcom/pinctrl-sdm660.c | 387 +++-- > drivers/pinctrl/qcom/pinctrl-sdm670.c | 284 ++-- > drivers/pinctrl/qcom/pinctrl-sdm845.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sdx55.c | 190 ++- > drivers/pinctrl/qcom/pinctrl-sdx65.c | 194 ++- > drivers/pinctrl/qcom/pinctrl-sdx75.c | 1601 ++++++++++++++++++++ > drivers/pinctrl/qcom/pinctrl-sm6115.c | 162 +- > drivers/pinctrl/qcom/pinctrl-sm6125.c | 282 ++-- > drivers/pinctrl/qcom/pinctrl-sm6350.c | 296 ++-- > drivers/pinctrl/qcom/pinctrl-sm6375.c | 358 +++-- > drivers/pinctrl/qcom/pinctrl-sm8150.c | 286 ++-- > drivers/pinctrl/qcom/pinctrl-sm8250.c | 258 ++-- > drivers/pinctrl/qcom/pinctrl-sm8350.c | 298 ++-- > drivers/pinctrl/qcom/pinctrl-sm8450.c | 300 ++-- > drivers/pinctrl/qcom/pinctrl-sm8550.c | 320 ++-- > 49 files changed, 7763 insertions(+), 6313 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,sdx75-tlmm.yaml > create mode 100644 drivers/pinctrl/qcom/pinctrl-sdx75.c >