Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 14:16:07 +0200
From:   Michal Kubiak <michal.kubiak@intel.com>
To:     Ding Hui <dinghui@sangfor.com.cn>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
        <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
        <keescook@chromium.org>, <grzegorzx.szczurek@intel.com>,
        <mateusz.palczewski@intel.com>, <mitch.a.williams@intel.com>,
        <gregory.v.rose@intel.com>, <jeffrey.t.kirsher@intel.com>,
        <simon.horman@corigine.com>, <madhu.chittim@intel.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-hardening@vger.kernel.org>, <pengdonglin@sangfor.com.cn>,
        <huangcun@sangfor.com.cn>
Subject: Re: [PATCH net v5 0/2] iavf: Fix issues when setting channels
 concurrency with removing
Message-ID: <ZFuLB7QwaWMzfY6F@localhost.localdomain>
References: <20230509111148.4608-1-dinghui@sangfor.com.cn>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230509111148.4608-1-dinghui@sangfor.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VBb3AocJhbX48XUMk2x2/oCrSzWAIf5k8lkTXpeewWyYm4IS0Os5GZVTHhFu?=
 =?us-ascii?Q?V0sg6Fss2Gv1MPc3ejyJkKNwkT5jSeTDkahm68npGfHccmH9Valtr6iu1BZD?=
 =?us-ascii?Q?Nwrh4XIHRQD/52UBsTFUfInS/8eOHcYPCJa4cekAeAI6sjCCpT0683/wCjwv?=
 =?us-ascii?Q?ubc0GrR0KDkprUcCk/l1PohjECnDTbSuQjM5ktqR1Id39zVLcR6C0K4g6jpd?=
 =?us-ascii?Q?j6gtD6m+65dOCq11WX5IXQwqll4UxHeEDicwEpWFCPRjC3St1GNkgXm3JH2S?=
 =?us-ascii?Q?RL+wF3FBnRnZIBUhZdMFEJWI2hpOSsF5QygIBhK0IjYGDJ7yxZgVNv6hTz8b?=
 =?us-ascii?Q?fqCSE3/movaVXBMjLBC1dr+wmC/KOKmtgtR2a8ydSCNigfAD+CJIfWU5UBEY?=
 =?us-ascii?Q?LltrDxO5T7if7RfoTBOoMfkA3/aZjJCG44MHnmyoku2WZqbo7ona16j0T7cW?=
 =?us-ascii?Q?zs90RIvpukDJVNKVNEhx0JJBwZt76V5KKf5QsZ4EWFdCve5CZa5ZGdzkma0Z?=
 =?us-ascii?Q?w1vZKCEtbdEWwf8gou/46fUeCXLH3oxO5eMzJ3a3rW8NANb9lcMVS44/VGCC?=
 =?us-ascii?Q?exxNTmC5Kf2npi7u1JEzdWQBpH59eBCVnpfAMmaf8WbtaKMPlowS4XgEwCjN?=
 =?us-ascii?Q?QVqN5Zq8HGW5cVRvSnAu9gVol8wU4QoUbMCArDSYDzOTjNaCBfTFVNb9/wRT?=
 =?us-ascii?Q?F61oE9MKUA2XIyYXrfaVdRlwoxnK0xMlVzYDPi2rcq46bC6NEexIl2m5iRTq?=
 =?us-ascii?Q?5IaPF3i4glNHQ/HmZigVFd2gpkCLW4p81BOzpiYGhaoLYgvOZ0wrzmUpLQsH?=
 =?us-ascii?Q?Fhdgo8rOONMmDxEUAO/MIee6Hm/lJRDzVhLZ5KVAl57YzLNdMaYwtZ5HE+xD?=
 =?us-ascii?Q?BX3kXxeiyPoyX7LeeU/dAnsXGdFJc6NbzwB8/njd17AiBtpfWbFjn5aP2oz0?=
 =?us-ascii?Q?mNKY0VG8wVN00FzDLK/syZv8jW0AgZa+nDVDB8wbzyZhQNTf1/TOKR5wOhgx?=
 =?us-ascii?Q?0J0MviETNvSs2pd6V712sRfzRCg/4TpkzgqEBhc8os3/RBlsdncB4YXDRlwO?=
 =?us-ascii?Q?IaGE0yGuCjHbUx4ESiIZyA/r4zrcOaakz8aa/j+eqBJHj/jAledAYetxMPxM?=
 =?us-ascii?Q?6yxugZEq+XOk2G7efVAQGnqhha0j/rSWgxH8d9FNT3UcsZQ+abu3En4LhKOl?=
 =?us-ascii?Q?E4tUK79+tB37yfqqR5GXYtEr4bEkB9y821SWgw54PawiVul0rm9ptDDCjsoJ?=
 =?us-ascii?Q?3ZTuDuG8swemQr7RGO1nrIPumKzu5FFKgSIr2ptf31gg6ROhxXeolil0rfh4?=
 =?us-ascii?Q?AwXsotFIn+KW0j/1E7OldNU7LFVyGIf5oDVQxiVKEFAjUXAJNVPZsfbTNJ1G?=
 =?us-ascii?Q?nIMjf5x+3KaYwz/HNj3KEFdPTjXNwmij/nRtD/n6fEQIiG/9nXnXpPc4ykZ7?=
 =?us-ascii?Q?9RqenMyQRM3Djiakn7Ngq3Fh/ioxKGe2knmrXGGoJAgqCgOoLGpVvsn9eRAt?=
 =?us-ascii?Q?I7xbaeO5uzLUBYMiD4i1/lImbuJoi6pc+zgL6yA8t46FNI9rvFN37l+Swj2L?=
 =?us-ascii?Q?9EpyydZeIOh4uVjuOcPBa3jZWdtjkL42ZblBibtO4D2AAl2Y+c3yhFHT9dez?=
 =?us-ascii?Q?UA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 611c806c-56d9-4d28-6c1e-08db515059f3
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2937.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 12:16:15.3566
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZFxkIfQTKz4LxOSbG3MQfrYgqsX/qYC1uGJoBgiemHxQzbb0GAsRVU3R/pvhErHMA3Dj1Clu+XScWj/cT3KFIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4607
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2023 at 07:11:46PM +0800, Ding Hui wrote:
> The patchset fix two issues which can be reproduced by the following script:
> 
> [root@host ~]# cat repro.sh
> #!/bin/bash
> 
> pf_dbsf="0000:41:00.0"
> vf0_dbsf="0000:41:02.0"
> g_pids=()
> 
> function do_set_numvf()
> {
>     echo 2 >/sys/bus/pci/devices/${pf_dbsf}/sriov_numvfs
>     sleep $((RANDOM%3+1))
>     echo 0 >/sys/bus/pci/devices/${pf_dbsf}/sriov_numvfs
>     sleep $((RANDOM%3+1))
> }
> 
> function do_set_channel()
> {
>     local nic=$(ls -1 --indicator-style=none /sys/bus/pci/devices/${vf0_dbsf}/net/)
>     [ -z "$nic" ] && { sleep $((RANDOM%3)) ; return 1; }
>     ifconfig $nic 192.168.18.5 netmask 255.255.255.0
>     ifconfig $nic up
>     ethtool -L $nic combined 1
>     ethtool -L $nic combined 4
>     sleep $((RANDOM%3))
> }
> 
> function on_exit()
> {
>     local pid
>     for pid in "${g_pids[@]}"; do
>         kill -0 "$pid" &>/dev/null && kill "$pid" &>/dev/null
>     done
>     g_pids=()
> }
> 
> trap "on_exit; exit" EXIT
> 
> while :; do do_set_numvf ; done &
> g_pids+=($!)
> while :; do do_set_channel ; done &
> g_pids+=($!)
> 
> wait
> 
> 
> Ding Hui (2):
>   iavf: Fix use-after-free in free_netdev
>   iavf: Fix out-of-bounds when setting channels on remove
> 
>  drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 4 +++-
>  drivers/net/ethernet/intel/iavf/iavf_main.c    | 6 +-----
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> -- 
> 2.17.1
> 

For the series:
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>

Thanks,
Michal