Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a5fdd37e-6f42-2f37-357f-ad5bb082fa7d@arinc9.com>
Date:   Wed, 10 May 2023 14:59:44 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] mips: dts: ralink: Clarify usage of MT7621 ethernet phy
 arguments
To:     Liviu Dudau <liviu@dudau.co.uk>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Paul Burton <paulburton@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Sergio Paracuellos <sergio.paracuellos@gmail.com>,
        linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20230509200032.308934-1-liviu@dudau.co.uk>
Content-Language: en-US
From:   =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
In-Reply-To: <20230509200032.308934-1-liviu@dudau.co.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 9.05.2023 22:00, Liviu Dudau wrote:
> The device tree uses numbers as arguments to the phys property that are
> confusing for newcomers. Define names for the values and use them in the
> device tree.
> 
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>

You should document this on 
Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml instead 
of doing this. Under the phys property, add 'description:' and explain this.

Arınç