Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230508164650.3217164-1-revest@chromium.org> <11481869-52a9-037a-c7a4-ebbc7d426229@huawei.com>
In-Reply-To: <11481869-52a9-037a-c7a4-ebbc7d426229@huawei.com>
From:   Florent Revest <revest@chromium.org>
Date:   Wed, 10 May 2023 15:53:58 +0200
Message-ID: <CABRcYmK_J83T6C+9tqaQ1R5BfQ0D7FQQDFK5h7_UwBEcbu2QsQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next] arm64,bpf: Support struct arguments in the BPF trampoline
To:     Xu Kuohai <xukuohai@huawei.com>
Cc:     bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        KP Singh <kpsingh@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Xu Kuohai <xukuohai@huaweicloud.com>,
        Zi Shen Lim <zlim.lnx@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 9:07=E2=80=AFAM Xu Kuohai <xukuohai@huawei.com> wro=
te:
>
> On 5/9/2023 12:46 AM, Florent Revest wrote:
> > @@ -1799,7 +1799,7 @@ static int prepare_trampoline(struct jit_ctx *ctx=
, struct bpf_tramp_image *im,
> >        *                  [ ...               ]
> >        * SP + args_off    [ arg1              ]
> >        *
> > -      * SP + nargs_off   [ args count        ]
> > +      * SP + nregs_off   [ arg regs count    ]
>
> For description consistency, should arg1 ... argN in the previous
> lines also be changed to arg reg 1 ... arg reg N?

Sure, sounds good :) I'll send a v2

(for some reason your email ended up in my spam folder, lucky I noticed it)