Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <34fa94f5-359f-f3e7-92ae-fcdc06ff19b8@amd.com>
Date:   Wed, 10 May 2023 09:59:36 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Cc:     yazen.ghannam@amd.com, tglx@linutronix.de, mingo@redhat.com,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        baolin.wang@linux.alibaba.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mce/amd: init mce severity to handle deferred memory
 failure
Content-Language: en-US
To:     Shuai Xue <xueshuai@linux.alibaba.com>, bp@alien8.de,
        tony.luck@intel.com
References: <20230425121829.61755-1-xueshuai@linux.alibaba.com>
 <f629820c-50cf-7366-975e-68215b3f2bc5@amd.com>
 <b384d621-6b2d-7aab-adbf-7045f23f4af9@linux.alibaba.com>
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <b384d621-6b2d-7aab-adbf-7045f23f4af9@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVJGQWdKRzRYSi8xTVRONElPUUwzbHV4eVFRR3VJcEhzNnJyaFJrK2VIRzVN?=
 =?utf-8?B?YXE1T3lpckk1amJtbU8xbzBrUEhNMnR6UHdOeUxtMlZCM25LVkZRazVuRUdG?=
 =?utf-8?B?Q1dJcXo0V2JtRElSaldSTDdiTlRMbnVJYUFzd3B6bmlqRTltdzhvRVZkcEta?=
 =?utf-8?B?eUZRaHlFTHMwQ2VBb1VYd05xcnRIS0NmbEV2Rm5rTldKSm5mcVdEWEJNbk5N?=
 =?utf-8?B?U00yZ1ZwTWhTbkRUamVoRWdha2RZS0NXVXF0KzBvajI4ZDFzaUVUaU1HOXFw?=
 =?utf-8?B?eTBuYTRFbWhPLzFxZTMydHVpMkprRXNtbTV4UzY3T2FpVHlLdXA4R2hoVWpE?=
 =?utf-8?B?YW5MRXB2Rld0MUg0MnF3RUNyT3E0T3Z4VlpWUWczcEdaWFJXU0xKNW5jQTl3?=
 =?utf-8?B?YnRlMk90cFlKK1BnVXpTbjlMcDY2amhLSjc0S0NaekFQMjdZaWo5ajVJMWJl?=
 =?utf-8?B?Tzh2SVBrSUhoSjJsWXNuRGlCSTNtWDkzM1psZHV3TEhxWW5EbGtuZE5vdCtt?=
 =?utf-8?B?Nk9RN1I5cXRsYUx5NjdwK1lCYTV5enpSTCt5VHRBRDVScW14T2JKTzQweUl6?=
 =?utf-8?B?eWhyY1R0K2JHT2tUSDF2RmsrSk0wbUZ5SUYwMzR2ZVpUcm43bFIzQnhUenBx?=
 =?utf-8?B?ZURpQm01elhyemEySzFpcVlGeGoyRGdwOWNGOSthcHdrTnIvUUszUWtNajYv?=
 =?utf-8?B?VXZJZUJWVG10WUhvUlEzT2NYVmFXQURtSkx1dUZWOU5ZcHVENEx4M0hVZUZO?=
 =?utf-8?B?aGNldW10NjFtS1FBNHR2dDFUUVZNcno1RUFPQWhBb0xLRnBrdXlHK2I5L2ln?=
 =?utf-8?B?d3hwT1JNUTJkYXMwbEVwcVhZSjY2UnNiWjZuNmFCcHpmdytvUm5yQkFoT3V0?=
 =?utf-8?B?dGtjOXBqSGkwQk1EcDFyL3QzN3g4TERtNjBkRkZEZk9BNkVzbTNlVzI3Mmsx?=
 =?utf-8?B?cTJzN1F3dU0zVHpNWjFIOVFwL1E5enM0UGJtR0NXZWJDZitoQWsvbDd3allX?=
 =?utf-8?B?TFB2RFVFaHByNWhNaEtlM2o4d0lsYkVyTDZIN251ZUw4eFUvdTVLTjQ3VXdV?=
 =?utf-8?B?ZTB4NDRVSmYvTEdqSjdnOEgybmpFbnFKMDdKTXhydFA4a2JFRW5QUUtkMmw5?=
 =?utf-8?B?Ni9Rcmc5SXlQU0MrUTRjaEcrdFF4UVJIL0lnMEw3eURwU3dIdjdhbThkeHpl?=
 =?utf-8?B?VHlOWkdtYlRmM2dtZ2RIa2lqNUVITldEajU2NDdtYUtKb1NBaUFvUmRaSzFo?=
 =?utf-8?B?M01jT1R1OG9OREV5OXNRdUNHUDJrWkJSWlVlVmZ2YVdXalNCZjFYQzFBTFJP?=
 =?utf-8?B?b2ZrZWRrcUovcWxmZnhjQkJrUVdWcklaK3I4Qk9zQUQrVHBrc21KNlFoV213?=
 =?utf-8?B?OHhOSWE0Q2t3bThTd3hyeERPNVpDZHhiMml1MWZZRE1EMHB3Mm1tdkxpWk9H?=
 =?utf-8?B?WTc5Z1dybGZnQ3pVRDY5Zjdsb1dpTTdwRWVHZG51aUhocDZJY1o4bUg1ZnRF?=
 =?utf-8?B?NEdNZHZtQ2I4V3MxcTB1ZFlRN3F0eFFtbzRtcU14L3JLWnFXWFNjcSswZzN4?=
 =?utf-8?B?dnlDU0lNa1BLZ2ViV1A0azJ5ZzN0aFdzQUV0YytuTGRCdGxqUzFBWCttRFBi?=
 =?utf-8?B?enNMa1FNaURqWVRTYS9OalJYSW1zd0E1b2xJdUxGSG9IWUNJOEEvV21Jd08w?=
 =?utf-8?B?Z1Zqa2pzS3ZHdEcrK1NlMDVLZ0NQSDZseGRKN1l3ZSs4WWkrR25mczBFUG1O?=
 =?utf-8?B?RkpCU2EyWW1sVkVoazhEUHR3ODc1VFJWTk02VHM1SjArS015RTQySjNSRFJh?=
 =?utf-8?B?MzFhbnRmT0E1dFU5azR5UytQZlZ1a0dHTzNLU1l0TW9SSWJzWWNUSXdMaGdx?=
 =?utf-8?B?Mm5NbVhXb2srTG55bTFvbWk1WXZqWGdyVkU3MU9STTFrZ1d3SjlmTkszeU1L?=
 =?utf-8?B?dDFLdUdodW1HRndZU1d1RlhsVm4rWFJrRVQ2QzRsYUxOWFFIbDkwSW9vMkRY?=
 =?utf-8?B?ZjIvN0dBQ3JkTEJsUDBEVXNRbTB0bDh3OWllTHp6RWQrblVYenRnM29BYXNi?=
 =?utf-8?B?TlpDclI3aUxOenZhZnJ0MkpvaXFUUW43YWpxWFUxSXlUZ3RjU2VPeTJzY2Nx?=
 =?utf-8?Q?gOEQ4AvcE7zfSZ4ulmPuGH4w+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a237b6dc-186a-49d0-6052-08db515ecbef
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2023 13:59:39.4697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cnfRRtSWSD8k4w5zwvLGpK028sR5s3kSTfStVrobcf+GucnblcJMUdgvrK4awuCBwoyPGzw4aoCl7sPFrcEeZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8465
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/9/23 10:17 PM, Shuai Xue wrote:
> 
> 
> On 2023/5/9 22:25, Yazen Ghannam wrote:
>> On 4/25/23 8:18 AM, Shuai Xue wrote:
>>> When a deferred UE error is detected, e.g by background patrol scruber, it
>>> will be handled in APIC interrupt handler amd_deferred_error_interrupt().
>>> The handler will collect MCA banks, init mce struct and process it by
>>> nofitying the registered MCE decode chain.
>>>
>>> The uc_decode_notifier, one of MCE decode chain, will process memory
>>> failure but only limit to MCE_AO_SEVERITY and MCE_DEFERRED_SEVERITY.
>>> However, APIC interrupt handler does not init mce severity and the
>>> uninitialized severity is 0 (MCE_NO_SEVERITY).
>>>
>>> To handle the deferred memory failure case, init mce severity when logging
>>> MCA banks.
>>>
>>> Signed-off-by: Shuai Xue <xueshuai@linux.alibaba.com>
>>>
>>
>> Hi Shuai Xue,
>>
>> I think this patch is fair to do. But it won't have the intended effect
>> in practice.
>>
>> The value in MCA_ADDR for DRAM ECC errors will be a memory controller
>> "normalized address". This is not a system physical address that the OS
>> can use to take action.
>>
>> The mce_usable_address() function needs to be updated to handle this.
>> I'll send a patchset this week to do so. Afterwards, the
>> uc_decode_notifier will not attempt to handle these errors.
> 
> From the experience of other platforms (e.g. ARM64 RAS and Intel MCA),
> uc_decode_notifier should handle these error to hard offline the corrupted
> page. If the corrupted page is a free buddy page, we can isolate it and avoid
> using the page in the future.
> 
> In my test case, the error is detected by patrol scrubber in memory controller.
> The scrubber may lack of system address space perspective, and only reports
> "normalized address". But we can decode the "normalized address" to system address
> by EDAC (umc_normaddr_to_sysaddr), right?
> 
> (I am not quite familiar with AMD RAS, please correct me if I am wrong)
>

Yes, that's correct.

The address translation requires some updates that are still in-review.
Afterwards, we can investigate ways to use the translated address. It
may require some rework in the MCE notifier chain or, more simply,
calling memory_failure() from the EDAC module itself.

Thanks,
Yazen