Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1ffc9474-0a05-44d8-0cc0-24a065443b18@quicinc.com>
Date:   Wed, 10 May 2023 20:00:50 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v6 4/4] pinctrl: qcom: Add SDX75 pincontrol driver
Content-Language: en-US
To:     <andy.shevchenko@gmail.com>
CC:     <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <linus.walleij@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <richardcochran@gmail.com>, <manivannan.sadhasivam@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
References: <1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com>
 <1683718725-14869-5-git-send-email-quic_rohiagar@quicinc.com>
 <ZFun8m5y-r0yUHhq@surfacebook>
From:   Rohit Agarwal <quic_rohiagar@quicinc.com>
In-Reply-To: <ZFun8m5y-r0yUHhq@surfacebook>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/10/2023 7:49 PM, andy.shevchenko@gmail.com wrote:
> Wed, May 10, 2023 at 05:08:45PM +0530, Rohit Agarwal kirjoitti:
>> Add initial Qualcomm SDX75 pinctrl driver to support pin configuration
>> with pinctrl framework for SDX75 SoC.
>> While at it, reordering the SDX65 entry.
> ...
>
>> +#define FUNCTION(n)							\
>> +	[msm_mux_##n] = {						\
>> +			.func = PINCTRL_PINFUNCTION(#n,			\
>> +					n##_groups,			\
>> +					ARRAY_SIZE(n##_groups))		\
>> +			}
> But don't you now have MSM_PIN_FUNCTION() macro?

So Sorry, a mistake from my end. Will immediately update.

Thanks for reviewing.
Rohit.


>