Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 10 May 2023 16:40:26 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Peter De Schrijver <pdeschrijver@nvidia.com>
Cc:     jonathanh@nvidia.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, stefank@nvidia.com
Subject: Re: [PATCH v2 5/6] dt-bindings: memory-region property for
 tegra186-bpmp
Message-ID: <ZFus2s7rdIS4hf0S@orome>
References: <20230510113129.4167493-1-pdeschrijver@nvidia.com>
 <20230510113129.4167493-6-pdeschrijver@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="Cys7xdI4J5nU1kTN"
Content-Disposition: inline
In-Reply-To: <20230510113129.4167493-6-pdeschrijver@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--Cys7xdI4J5nU1kTN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 10, 2023 at 02:31:34PM +0300, Peter De Schrijver wrote:
> Add memory-region property to the tegra186-bpmp binding to support
> DRAM MRQ GSCs.
>=20
> Co-developed-by: Stefan Kristiansson <stefank@nvidia.com>
> Signed-off-by: Stefan Kristiansson <stefank@nvidia.com>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
> ---
>  .../firmware/nvidia,tegra186-bpmp.yaml        | 37 +++++++++++++++++--
>  1 file changed, 34 insertions(+), 3 deletions(-)

We usually use a longer subject prefix, even though that makes the whole
subject usually become longer than the recommended 50 (or so)
characters.

Maybe you also want to add a verb to the subject to make it more
descriptive. As it is the subject doesn't indicate what's happening with
the memory-region property. It could equally well get removed.

Thierry

--Cys7xdI4J5nU1kTN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmRbrNoACgkQ3SOs138+
s6Forg/+J9Eemk8vswIOaDn+qZ4RRD/PyuaHP2irl7MoioAXpR7tA3qM7x/ltwUz
odt+2aGX9dR2PfOE/oT6EIHP0Ho8AMyM2R+o9Ii76mqk6GaO0xiluG3PmyZHkkUS
sziQN5KGVdp74+GiQ8btD6zTn9fO9x9WQ9CXrqU8e/TzlhnPFG3qqEqU5ixH5IH1
txXMLUuecKr/NAKU0uhEU96hgrw+D7dLPTO877RFhwx4JZ2xcZjTp1qGanfBt+Ep
K5oXX0NlmcvnG3tYMLTpuwJ4lpIns+PhiANBMRyqH7Fn4fytqb9fmHZPRSPSnT7r
80+GTZRmd+vXuWI+JkKU714EOkPuJ71XF/hqg/qZHeNeUF/YC0w9GI6KTZQ2d36y
03yMm3Anvc0VBj2jWJQymgVjZdW5Yc5j1JY9AlJjX2hjNA4fvWwl1fA0YdzGnHxT
T07cl29tsBBPQlo/1ZtfKaFpcLV8IGfTdokbGirMCse1vaXgF36s1tNFqwp+7Ond
TFk/AiM91zxDRiN4dUMvpuOmtMN6J6Npj0VZmKLk6RnZn3rbJPJFwarSUJVGYC0r
A1s2XFEJo8VX5Rb+Pkk7LlTHEG17joDoVm0yCyZQ7Hm/Lvi4JoWJ8tXFqRnlYVIM
XDWqlm1JQBOZDodV1zxkzK1+19YmGjmB42HmPhS1mchieVU2c50=
=QylG
-----END PGP SIGNATURE-----

--Cys7xdI4J5nU1kTN--