Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp7416857rwr; Wed, 10 May 2023 08:02:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ZphfAq+mb7DwB5Mw5J0WBTdyYD8YoOOpCI0Nf4oNXlqFN0NxNqJYk6EohLhYyEDAUh6hM X-Received: by 2002:a25:5802:0:b0:ba6:5a6e:f7e8 with SMTP id m2-20020a255802000000b00ba65a6ef7e8mr1248226ybb.8.1683730926945; Wed, 10 May 2023 08:02:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683730926; cv=none; d=google.com; s=arc-20160816; b=QZgR/IJ1K64CCAm8SVlglYk5A0dKB2stqjQ3Oc4fk3DzJx79l8hiPN0wD+cXumIoNv Lw+rZ79+5eN66jY0tmuYq/0B8bZxVSA+cCiyj9GiBx3lAdugkThfMjcm86PeYsX9A3Ql 7XW0mbiMxJd1Cs7eADheBsqRInttny38Vpddc8Dr0I3ibtsD73DNWGoAgYrKPjzoHfIK zeQZ0idGszUP7aoiCZhHY88MW74fuC0YZqQD2FwpeaGnD/rtT8s0fimehpUA9GTXnlhS Fuczpm7mZ54f/07S50YR7Y7af6gcs2Skl0XVGk4Rko9GOz/oGvChJZ2cFdoiDBFlFxny XFkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=rw1MLlzzJH/+STgxvKYi/t/faSj/QeBANMCtgkem3lM=; b=VmgUgs1P0xQRpzuwl7Z3CVmva1QcGnuk+Eb11GubJ9kghAN3EPlF95rrs8PSVvlk9u YzonljfeBxDDSNwcieWV201Rraj9NKpHOF9+5W9XZn11ITI7kZqfm/EFPqA/kd+nVggZ v3LPBsgRC0T5x4SBuH+qbrMhICNcIuWyBnqFd1BtoQGYOh+FIUTWARy0TEg/fVv4qlq1 BHD1QHfIXxM/FnuTT8UaxayIjy4KoRczvaUD0eTAHO2AUJOJQhqwGMPmHCRVX8nNmPab fwY9XzEJ2WrCg8ISHRYw+Zxumz/WyO45J+BfjFXC51swEq+VMrSFQveFVDWGfrCz4K18 6Qmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=g+zH5fnw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b125-20020a251b83000000b00ba040511f0csi12010364ybb.523.2023.05.10.08.01.47; Wed, 10 May 2023 08:02:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=g+zH5fnw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237365AbjEJObU (ORCPT + 99 others); Wed, 10 May 2023 10:31:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237374AbjEJObR (ORCPT ); Wed, 10 May 2023 10:31:17 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 452323C0B for ; Wed, 10 May 2023 07:31:15 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-50bc5197d33so13576974a12.1 for ; Wed, 10 May 2023 07:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1683729073; x=1686321073; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rw1MLlzzJH/+STgxvKYi/t/faSj/QeBANMCtgkem3lM=; b=g+zH5fnw/H7+bg71JqmY1XT6HACMA8B7hk9/64yMwh8ocGg1RpDgnwtwQE2dQUOGYO 16GNFtGL+vmQwQWJK8EQKgKYw330gpxqbpywwqfCCj9Bt/s2pm8iYTvA/mf+kfeHYEZY 7/iC0jBVMpW7yAHgKjLCsU5b2SKMzfz/AaDFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683729073; x=1686321073; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rw1MLlzzJH/+STgxvKYi/t/faSj/QeBANMCtgkem3lM=; b=XcnUrWybZBAPI6w05c8got4XAO+Pr8HfH7VVZpDEUAWubii3CX+NK9pHnd8WlJ7yg+ EW2eZ5AxeYUmqFowPWO+8zAXVvlxFg8tJ0uqz+8CrNGttXpnEk3NjzdmU/kUniTuNGLb cXtMEqMMKAIamnEAAZ2BWI6uSudxz8l2T5e4DFL7cmIMKivV5803iMH4QbGnByKsdz3f 5vEUM/tCBOuwViOygTyuucHjK7KPlXIIIYxoYgJnY/JhY+WL+maZjY1y/OacFYeRzmQi O3h+Xl18AFlaX/f/Fu2EHvqUQq5tVsHL3xaA8xeOo7HtzrXJy6evGSGJ/etivxy08Ed9 V+DA== X-Gm-Message-State: AC+VfDwm1Op+0iXkpfAimEB5N+o2eAekUCzEmsZlI8YEDKKHDuZfFab9 iNvblzYE2XLeTdSRsxs+abNK3R4EZ20N5varkn3q+A== X-Received: by 2002:a05:6402:295:b0:50b:c6c9:2146 with SMTP id l21-20020a056402029500b0050bc6c92146mr12960129edv.24.1683729073416; Wed, 10 May 2023 07:31:13 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id g8-20020aa7d1c8000000b00501d73cfc86sm1919937edp.9.2023.05.10.07.31.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 07:31:12 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-9661047f8b8so925154066b.0 for ; Wed, 10 May 2023 07:31:12 -0700 (PDT) X-Received: by 2002:a17:907:31c4:b0:94e:8431:4767 with SMTP id xf4-20020a17090731c400b0094e84314767mr14327246ejb.38.1683729072247; Wed, 10 May 2023 07:31:12 -0700 (PDT) MIME-Version: 1.0 References: <20230510030752.542340-1-tj@kernel.org> <20230510030752.542340-4-tj@kernel.org> In-Reply-To: <20230510030752.542340-4-tj@kernel.org> From: Linus Torvalds Date: Wed, 10 May 2023 09:30:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/6] workqueue: Move worker_set/clr_flags() upwards To: Tejun Heo Cc: jiangshanlai@gmail.com, peterz@infradead.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 9, 2023 at 10:08=E2=80=AFPM Tejun Heo wrote: > > They're gonna be used wq_worker_stopping(). Move them upwards. I got points deducted in fifth grade for using "gonna" instead of "going to". Here I am, 40+ years later, and I still feel it. Please use "going to". And add the missing "in" while at it. Linus "scarred for life" Torvalds