Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1683718725-14869-1-git-send-email-quic_rohiagar@quicinc.com>
 <1683718725-14869-5-git-send-email-quic_rohiagar@quicinc.com>
 <ZFun8m5y-r0yUHhq@surfacebook> <1ffc9474-0a05-44d8-0cc0-24a065443b18@quicinc.com>
In-Reply-To: <1ffc9474-0a05-44d8-0cc0-24a065443b18@quicinc.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 10 May 2023 17:34:08 +0300
Message-ID: <CAHp75VcCYo2uF2VY6x3jFb3v-whXrCW_U_bKnnWAfzg+dAe1zQ@mail.gmail.com>
Subject: Re: [PATCH v6 4/4] pinctrl: qcom: Add SDX75 pincontrol driver
To:     Rohit Agarwal <quic_rohiagar@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org,
        linus.walleij@linaro.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, richardcochran@gmail.com,
        manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 5:31=E2=80=AFPM Rohit Agarwal <quic_rohiagar@quicin=
c.com> wrote:
> On 5/10/2023 7:49 PM, andy.shevchenko@gmail.com wrote:
> > Wed, May 10, 2023 at 05:08:45PM +0530, Rohit Agarwal kirjoitti:

...

> >> +#define FUNCTION(n)                                                 \
> >> +    [msm_mux_##n] =3D {                                              =
 \
> >> +                    .func =3D PINCTRL_PINFUNCTION(#n,                =
 \
> >> +                                    n##_groups,                     \
> >> +                                    ARRAY_SIZE(n##_groups))         \
> >> +                    }
> > But don't you now have MSM_PIN_FUNCTION() macro?
>
> So Sorry, a mistake from my end. Will immediately update.

Don't forget to collect my tags for the other patches.

--=20
With Best Regards,
Andy Shevchenko