Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230424112313.3408363-1-glider@google.com> <6446ad55.170a0220.c82cd.cedc@mx.google.com>
 <CAG_fn=UzQ-jnQrxzvLE6EV37zSVCOGPmsVTxyfp1wXzBir4vAg@mail.gmail.com> <CAG_fn=XmSbaMQQAwCWVmZ8UYDrsmeQWiqi92Vi4CQqy4GK+0ug@mail.gmail.com>
In-Reply-To: <CAG_fn=XmSbaMQQAwCWVmZ8UYDrsmeQWiqi92Vi4CQqy4GK+0ug@mail.gmail.com>
From:   Alexander Potapenko <glider@google.com>
Date:   Wed, 10 May 2023 18:07:44 +0200
Message-ID: <CAG_fn=VgkA0OdjqJg1FCBX5FcXtm96h9PTTTwAt3qWa0n0oNyw@mail.gmail.com>
Subject: Re: [PATCH] string: use __builtin_memcpy() in strlcpy/strlcat
To:     Kees Cook <keescook@chromium.org>, akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org, elver@google.com,
        dvyukov@google.com, kasan-dev@googlegroups.com, andy@kernel.org,
        ndesaulniers@google.com, nathan@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, May 10, 2023 at 9:48=E2=80=AFAM Alexander Potapenko <glider@google.=
com> wrote:
>
>
>
> On Fri, Apr 28, 2023 at 3:48=E2=80=AFPM Alexander Potapenko <glider@googl=
e.com> wrote:
>>

>> > I *think* this isn't a problem for CONFIG_FORTIFY, since these will be
>> > replaced and checked separately -- but it still seems strange that you
>> > need to explicitly use __builtin_memcpy.
>>
>
> Or did you mean we'd better use __underlying_memcpy() here instead? I am =
a bit puzzled.

Kees told me offline that the patch in question is fine.
@Andrew, would it be possible to queue it for 6.4?

--
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg